similar to: [PATCH libguestfs 0/2] build: Allow programs using libguestfs to be compiled from against build dir.

You have to use: ../libguestfs/run ./configure ../libguestfs/run make Use of the second ../libguestfs/run against make is unfortunate but I believe it's unavoidable due to the way that ocamlfind works. --- .gitignore | 1 + ocaml/Makefile.am | 19 ++++++++++++++++++- run.in | 2 ++ 3 files changed, 21 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore

For these simple compile tests where we want to ensure that a basic external program could be compiled using libnbd, we shouldn't include <config.h>. This is because we want to test here that <libnbd.h> can stand alone, without needing anything defined by the GNU autotools infrastructure. Of course we can use <config.h> in other test programs where we aren't evaluating

Here are some of the patches that I have maintained in the patch queue of my packages that I maintain within the Debian distribution (http://packages.qa.debian.org/libg/libguestfs.html). All of them address FTBFS (fail to build from source) errors that happened with the particular configuration that is used for building the Debian package. Cheers, -Hilko

On Friday, 29 November 2019 13:09:47 CET Richard W.M. Jones wrote: > So, the difficulty of git submodules aside, we have now split off > virt-v2v and virt-p2v into separate projects. > > I also yesterday split off the boot analysis tools into a repo which > is likely to be rarely used and which I'll probably not bother to > package in Fedora. >

<https://github.com/Chocrates> Apologies if this is the wrong list, I initially opened a github ticket before reading that github isn't the right spot. Trying to compile libguestfs and in the process need to get hivex compiled and installed. Hivex compiles and installs fine (I think), but ocamlfind doesn't seem to pick up hivex after the install causing the autogen.sh script in

Version 2: https://www.redhat.com/archives/libguestfs/2020-April/thread.html#00166 Version 3 contains all changes discussed in the previous review. Rich.

From: Jim Meyering <meyering at redhat.com> * lib/hivex.c (hivex_node_set_value): Remove unnecessary test-before-free. --- lib/hivex.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/lib/hivex.c b/lib/hivex.c index d042f4f..a72fa77 100644 --- a/lib/hivex.c +++ b/lib/hivex.c @@ -2748,8 +2748,7 @@ hivex_node_set_value (hive_h *h, hive_node_h node, leave_partial:

OCaml 4.02 introduced the 'bytes' type, a mutable string intended to replace the existing 'string' type for those cases where the byte array can be mutated. In future the 'string' type will become immutable. This is not the default now, but it can be forced using the '-safe-string' compile option. I tested this on Fedora 24 (OCaml 4.02) & RHEL 7 (OCaml 4.01).

Simplifies the build a bit. This is on top of the previous SELinux relabelling patch set, although not related to it. Rich.

While there is only one OCaml source, build it as small library: this way it is easier to use, and there is no need to copy the sources from here. --- .gitignore | 1 + mlv2v/Makefile.am | 71 ++++++++++++++++++++++++++++++++++++++++++++--- mlv2v/dummy.c | 2 ++ 3 files changed, 70 insertions(+), 4 deletions(-) create mode 100644 mlv2v/dummy.c diff --git a/.gitignore b/.gitignore

We use a similar trick to libvirt to allow external C programs that use libguestfs to be compiled against the built (but not installed) libguestfs with: ../libguestfs/run ./configure make What actually happens is we have a second pkg-config file (lib/local/libguestfs.pc) which points to the locally built libguestfs. The ./run script sets up PKG_CONFIG_PATH to point to this directory.

Without this option, configure will fail when there is no display. Signed-off-by: Masami HIRATA <msmhrt at gmail.com> --- configure.ac | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index de8a064..61d6f69 100644 --- a/configure.ac +++ b/configure.ac @@ -593,16 +593,16 @@ working. AC_MSG_FAILURE([$QEMU version must be >=

Version 1 was here: https://www.redhat.com/archives/libguestfs/2020-April/thread.html#00160 Version 2 side-steps the objections to the first patch by using a well-formed alternate nbdkit.pc file and running ordinary pkg-config against it, so any parsing of --cflags etc will be done by pkg-config. The first patch is essentially the same idea as:

On 3/10/20 10:05 AM, Richard W.M. Jones wrote: > We use a similar trick to libvirt to allow external C programs that > use libguestfs to be compiled against the built (but not installed) > libguestfs with: > > ../libguestfs/run ./configure > make > > What actually happens is we have a second pkg-config file > (lib/local/libguestfs.pc) which points to the locally

--- mllib/common_utils_tests.ml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/mllib/common_utils_tests.ml b/mllib/common_utils_tests.ml index 09d5c51..283e9a1 100644 --- a/mllib/common_utils_tests.ml +++ b/mllib/common_utils_tests.ml @@ -27,6 +27,7 @@ let prog = "common_utils_tests" let assert_equal_string = assert_equal ~printer:(fun x -> x) let

Followup/fix of commit 61d4891ef48df171a27873efe90aab51a9b711ef. --- builder/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/Makefile.am b/builder/Makefile.am index 09ae4ae..e64c899 100644 --- a/builder/Makefile.am +++ b/builder/Makefile.am @@ -311,7 +311,7 @@ depend: .depend .depend: $(wildcard $(abs_srcdir)/*.mli) $(wildcard $(abs_srcdir)/*.ml) rm -f

Hi Libguestfs team, I'm trying to build guestfs on Ubuntu 22.04, but getting below error. #17 8.021 checking for OCaml findlib package augeas... not found #17 8.024 configure: error: the OCaml module 'augeas' is required By guestfs-building doc I need to get the package from https://people.redhat.com/~rjones/augeas/. But there is not instructions on how and where to place the package

This is just the utilities part of the patch series from: https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html I believe this addresses everything raised in comments on that patch series. Rich.

As I'm now working through the enormous virt-v2v/virt-p2v bug list, we need a high quality set of tests to ensure that we don't accidentally regress some old OS/hypervisor combination while making changes. The test cases are going to be huge, so we cannot possibly distribute them in libguestfs. Furthermore many of them have licensing problems which means we cannot redistribute them at

This patch is incomplete but it illustrates the idea. virt-sysprep is rewritten as a modular tool in OCaml. Only the 'utmp' and 'hostname' operations are implemented at the moment. Rich.