similar to: [PATCH v2] virt-make-fs: add '--blocksize' option support

From: Nikolay Ivanets <stenavin@gmail.com> This patch adds '--blocksize' command line option for virt-make-fs tool. This option allows specifying disk sector size as described in 'guestfs_add_drive_opts' libguestfs API. --- make-fs/make-fs.c | 28 ++++++++++++++++++++++++++-- make-fs/test-virt-make-fs.sh | 5 ++++- make-fs/virt-make-fs.pod | 10 ++++++++++

From: Nikolay Ivanets <stenavin@gmail.com> This patch adds 4096 bytes sector size for output disk. Side notes: While working on this patch I reveal long standing issue: virt-make-fs can fail if source directory/archive contains certain amount of really small or empty files or wide tree of directories. That is because of lack of available inodes on a small file system to keep files

It should be very compatible with the Perl version. --- .gitignore | 3 + Makefile.am | 2 +- configure.ac | 1 + make-fs/Makefile.am | 82 +++++ make-fs/make-fs.c | 736 +++++++++++++++++++++++++++++++++++++++++++ make-fs/test-virt-make-fs.sh | 96 ++++++ make-fs/virt-make-fs.pod | 252 +++++++++++++++ po/POTFILES

If specified, pass the label for the new filesystem directly to the mkfs (or mkfs_btrfs) call. This saves one set_label call, mostly. --- format/format.c | 10 ++++++---- make-fs/make-fs.c | 28 +++++++++++++++++----------- 2 files changed, 23 insertions(+), 15 deletions(-) diff --git a/format/format.c b/format/format.c index 4e6069f..cc371ab 100644 --- a/format/format.c +++ b/format/format.c

This makes a bit easier to diagnose failures on mkfs, without the need to restart the filesystem creation with verbose output (which will produce a lot more output). --- make-fs/make-fs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/make-fs/make-fs.c b/make-fs/make-fs.c index ff291a1..561c6ae 100644 --- a/make-fs/make-fs.c +++ b/make-fs/make-fs.c @@ -773,8 +773,8 @@

From: Nikolay Ivanets <stenavin@gmail.com> This patch adds '--blocksize' command line option for virt-get-kernel tool. This option allows specifying disk sector size as described in 'guestfs_add_drive_opts' libguestfs API. --- get-kernel/get_kernel.ml | 22 ++++++++++++---------- get-kernel/virt-get-kernel.pod | 8 ++++++++ 2 files changed, 20 insertions(+), 10

From: Nikolay Ivanets <stenavin@gmail.com> This patch adds '--blocksize' command line option for guestfish and other C-based tools. This option allows specifying disk sector size. --- align/scan.c | 8 ++++++++ align/virt-alignment-scan.pod | 12 ++++++++++++ cat/cat.c | 8 ++++++++ cat/filesystems.c | 8 ++++++++ cat/log.c

From: Nikolay Ivanets <stenavin@gmail.com> This patch adds '--blocksize' command line option parsing and handling for guestfish and other C-based tools which share the same code from this sub-module. '--blocksize' will be a common for almost all libguestfs-based tools and thus parameter description will be repeated all the time. Let's move it into blocksize-option.pod

Add the 'label' optional argument to the mkfs action, so it is possible to set a filesystem label direct when creating it. There may be filesystems not supporting changing the label of existing filesystems but only setting it at creation time, so this new optarg will help. Implement it for the most common filesystems (ext*, fat, ntfs, btrfs, xfs), giving an error for all the others, just

--- filters/blocksize/nbdkit-blocksize-filter.pod | 4 ++-- filters/blocksize/blocksize.c | 19 +++++++++++++++++++ 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/filters/blocksize/nbdkit-blocksize-filter.pod b/filters/blocksize/nbdkit-blocksize-filter.pod index b6cf4dd..0abed2f 100644 --- a/filters/blocksize/nbdkit-blocksize-filter.pod +++

Allow `launch` call to accept an optional argument, called `blocksize`. Example: $ guestfish --listen -a raw.img $ guestfish --remote -- launch blocksize:4096 The actual qemu command is: [...] -device virtio-scsi-ccw,id=scsi -drive file=raw.img,cache=writeback,id=hd0,if=none -device scsi-hd,drive=hd0,physical_block_size=4096,logical_block_size=4096 [...] Signed-off-by: Tuan Hoang

I examined each filter to see which ones implement a cache and do not properly consider consistency across clients for flush requests. For these filters we should force .can_multi_conn to return false. I believe only one filter (blocksize) needs to be updated and all the other ones are safe. --- filters/blocksize/blocksize.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git

From: Nikolay Ivanets <stenavin@gmail.com> This patch adds '--blocksize' command line option for guestfish and other C-based tools. This option allows specifying disk sector size. --- align/Makefile.am | 1 + align/scan.c | 8 ++++++++ align/virt-alignment-scan.pod | 2 ++ cat/Makefile.am | 1 + cat/cat.c | 8 ++++++++

пн, 24 лют. 2020 о 22:53 Richard W.M. Jones <rjones@redhat.com> пише: > > Since the blocksize option was added since the minimum version of > libguestfs for virt-v2v, we need to make it conditional so that > virt-v2v can still be compiled with the older libguestfs. > > This commit does the minimum fix to make it build. It doesn't > conditionalize the --blocksize

On 1/5/19 8:50 AM, Richard W.M. Jones wrote: > I examined each filter to see which ones implement a cache and do not > properly consider consistency across clients for flush requests. For > these filters we should force .can_multi_conn to return false. > > I believe only one filter (blocksize) needs to be updated and all the > other ones are safe. > --- >

It is easy to demonstrate that our blocksize filter has a bug: if the minblock= setting is a higher granularity than the underlying plugin actually supports, and the client is trying to collect block status for the entire disk, a mid-block transition in the plugin can result in the filter rounding a request so small that it no longer makes progress, causing the client to see: nbd.Error:

From: Nikolay Ivanets <stenavin@gmail.com> This patch adds '--blocksize' command line option parsing and handling for guestfish and other C-based tools which share the same code. --- options/options.c | 13 ++++- options/options.h | 125 +++++++++++++++++++++++++++------------------- 2 files changed, 86 insertions(+), 52 deletions(-) diff --git a/options/options.c

Since the blocksize option was added since the minimum version of libguestfs for virt-v2v, we need to make it conditional so that virt-v2v can still be compiled with the older libguestfs. This commit does the minimum fix to make it build. It doesn't conditionalize the --blocksize option altogether. However I believe, at least for virt-v2v, that is OK since the --blocksize option is not used

When --blocksize <val> is provided, qemu command line would add physical_block_size=<val>,physical_logical_size=<val> to -device directive. Example: qemu-kvm \ -drive file=raw.img,cache=writeback,id=hd0,if=none \ -device scsi-hd,drive=hd0,physical_block_size=4096,logical_block_size=4096 \ Signed-off-by: Tuan Hoang <tmhoang@linux.ibm.com> --- fish/fish.c |

Hi I've got serious problem with my Vorbis-Decoder. The error seems to happen in the inverse Mdct. Before the imdct the values seems to be correct (compared with those of jOrbis (www.jcraft.com/jorbis/)). But after the transformation the values shows a strange behaviour. In [0, blocksize/2] the values are correct, but in [blocksize/2, blocksize] the values are wrong. The difference in