similar to: [v2v PATCH v2 0/3] Use libosinfo for query device drivers

This patch series integrates libosinfo in virt-v2v to get the list of files for Windows from libosinfo, if possible. The actual data is still from virtio-win, just unpacked. Pino Toscano (3): build: require libosinfo v2v: add a minimal libosinfo interface v2v: try to get windows driver files from libosinfo m4/guestfs-v2v.m4 | 3 + v2v/Makefile.am | 9 +-

Avoid using an auto-cleanup for OsinfoList, duplicating the cleanup everywhere needed. --- v2v/libosinfo-c.c | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/v2v/libosinfo-c.c b/v2v/libosinfo-c.c index 322e7d3d..75c2fae4 100644 --- a/v2v/libosinfo-c.c +++ b/v2v/libosinfo-c.c @@ -49,17 +49,6 @@ #if !IS_LIBOSINFO_VERSION(1, 8, 0)

Hi Pino: I've suppressed some OCaml and libosinfo valgrind errors in virt-v2v. The remaining valgrind errors are here: http://oirase.annexia.org/tmp/v2vvg/ They all seem to be basically the same. But I couldn't work out if these are expected leaks in the libosinfo code (in which case we should suppress them), or if they are actual bugs because we are missing a true destructor here:

On Tue, Apr 14, 2020 at 12:37:07PM +0200, Pino Toscano wrote: > > Unfortunately we never free the database. > > Hm it is never freed? Wouldn't that result in actual leaks, since > OsinfoDb_t_finalize (g_object_unref'ing the OsinfoDb) wouldn't be > called? I was thinking because of this:

libosinfo 1.8.0 declares them automatically for all of its classes, so there is no need to declare ours. This requires fixing the definition of the IS_LIBOSINFO_VERSION macro to wrap its body in brackets. While in the process, simplify the workaround for a related bug by removing a now-useless check. --- v2v/libosinfo-c.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff

libosinfo changed the way OsinfoList is declared in 1.7.0, however that was changed back to the old way in 1.8.0; the change was an ABI break, and made OsinfoList a Module class. Starting from 2.63.3, Module classes have already auto-cleanup functions declared for them, leading to double declarations in certain setups. Hence, do some version check dance to declare the OsinfoList only when using

Hi All, I'm attempting to compile virt-v2v 1.42.0 on Debian testing. With gcc 9.3.0, libosinfo 1.7.1, and glib 2.64.2, `./configure && make` fails on libosinfo-c.c with the following error message: -8<-------------------------------------------------------------------- In file included from /usr/lib/x86_64-linux-gnu/glib-2.0/include/glibconfig.h:9, from

Hi folks! i created a server with this XML file: <domain type='lxc'> <name>lxctest1</name> <uuid>227bd347-dd1d-4bfd-81e1-01052e91ffe2</uuid> <metadata> <libosinfo:libosinfo xmlns:libosinfo="http://libosinfo.org/xmlns/libvirt/domain/1.0"> <libosinfo:os id="http://centos.org/centos/6.9"/>

There's a standardized libosinfo namespace for libvirt domain metadata. For now it supports the id of the OS only. However that is still a very helpful feature that is already supported in gnome-boxes and virt-manager (at least). The discussion happened here: https://www.redhat.com/archives/libosinfo/2018-September/msg00003.html So let's add the support to local and libvirt outputs.

Query libosinfo to get the list of files for drivers of Windows guests, copying them if they are local files only. In case it is not possible (e.g. no driver files are listed, or their location is a non-local URL, or they do not exists), the manual filtering of the virtio-win content is done as before. --- v2v/windows_virtio.ml | 78 ++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 74

On Tuesday, 14 April 2020 11:53:30 CEST Richard W.M. Jones wrote: > I've suppressed some OCaml and libosinfo valgrind errors in virt-v2v. > > The remaining valgrind errors are here: > > http://oirase.annexia.org/tmp/v2vvg/ > > They all seem to be basically the same. But I couldn't work out if > these are expected leaks in the libosinfo code (in which case we

On Fri, Nov 23, 2018 at 11:53:05AM +0000, Richard W.M. Jones wrote: >On Fri, Nov 23, 2018 at 12:39:44PM +0100, Martin Kletzander wrote: >> There's a standardized libosinfo namespace for libvirt domain metadata. For now >> it supports the id of the OS only. However that is still a very helpful feature >> that is already supported in gnome-boxes and virt-manager (at

On Tuesday, 14 April 2020 15:16:49 CEST Richard W.M. Jones wrote: > On Tue, Apr 14, 2020 at 12:37:07PM +0200, Pino Toscano wrote: > > > Unfortunately we never free the database. > > > > Hm it is never freed? Wouldn't that result in actual leaks, since > > OsinfoDb_t_finalize (g_object_unref'ing the OsinfoDb) wouldn't be > > called? > > I was

Query libosinfo to get the list of files for drivers of Windows guests, copying them if they are local files only. In case it is not possible (e.g. no driver files are listed, or their location is a non-local URL, or they do not exists), the manual filtering of the virtio-win content is done as before. --- v2v/windows_virtio.ml | 63 ++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 59

Upstream dropped[1] support for '--os-variant list' in favor of using `osinfo-query` tool provided by the libosinfo project. To get a list of all accepted operating systems, invoke: osinfo-query os [1] https://git.fedorahosted.org/cgit/virt-manager.git/commit/?id=bcb60f0 --- builder/virt-builder.pod | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

On Tuesday, 12 September 2017 09:03:08 CEST Cédric Bosdonnat wrote: > From: Pino Toscano <ptoscano@redhat.com> > > The C osinfo database parser has been deprecated, reimplement the base > of it in ocaml for virt-builder-repository to use. This provides an > Osinfo.iterate_db() function traversing the files of the osinfo database > and calling a function on each of them.

On Fri, Nov 23, 2018 at 01:16:55PM +0000, Richard W.M. Jones wrote: >On Fri, Nov 23, 2018 at 02:10:01PM +0100, Martin Kletzander wrote: >> On Fri, Nov 23, 2018 at 11:53:05AM +0000, Richard W.M. Jones wrote: >> >On Fri, Nov 23, 2018 at 12:39:44PM +0100, Martin Kletzander wrote: >> >>There's a standardized libosinfo namespace for libvirt domain metadata. For now

On Tuesday, 7 March 2017 15:26:57 CET Cédric Bosdonnat wrote: > In order to further reuse the osinfo database parsing in OCAML, this > commit extracts the XML processing for the distro ISOs and places it > into a newly created callback. > > This will later help other code to traverse the osinfo DB files and > let them extract what they need from them. > --- Mostly LGTM, just

On Thu, Oct 05, 2017 at 04:58:30PM +0200, Cédric Bosdonnat wrote: > virt-builder-repository allows users to easily create or update > a virt-builder source repository out of disk images. The tool can > be run in either interactive or automated mode. > --- > .gitignore | 3 + > builder/Makefile.am | 86 +++++- >

Starting from glib 2.63.3, Module classes have already auto-cleanup functions declared for them. Reported by: Kevin Locke. --- v2v/libosinfo-c.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/v2v/libosinfo-c.c b/v2v/libosinfo-c.c index 1ab6bb4d..e6827f76 100644 --- a/v2v/libosinfo-c.c +++ b/v2v/libosinfo-c.c @@ -44,7 +44,9 @@ G_DEFINE_AUTOPTR_CLEANUP_FUNC(OsinfoFilter, g_object_unref)