similar to: [PATCH 0/7] Various Python pycodestyle fixes

Fixes all the pycodestyle issues in the Python bindings, overring one that does not make sense to change (and it's in setup.py, so almost irrelevant). Add a simple optional pycodestyle-based test to avoid regressions in the future. Pino Toscano (8): python: PEP 8: adapt empty lines python: PEP 8: adapt whitespaces in lines python: tests: catch specific exception python: tests:

Hi, this series cleans up the Python sources, either static or generated, including also tests, to make them PEP 8 compliant; see https://www.python.org/dev/peps/pep-0008/ and tools like pep8. Almost all the issues reported by pep8 are fixed, reducing the issues from 3818 to 7. The changes should have no effect on the actual code, while it will help Python users with consistency with other

Instead of running all the tests manually, the unittest module has a 'discovery' mode to run tests by importing them from a directory: this requires the tests to have different filenames, since they need to be imported as modules now (hence an empty __init__.py is added), and the current naming does not match the convention. Using unittest as loader/runner brings another change: tests

Signed-off-by: Hiroyuki Katsura <hiroyuki.katsura.0513@gmail.com> --- python/t/test020Create.py | 25 ++++++++++++++ python/t/test030CreateFlags.py | 27 +++++++++++++++ python/t/test040CreateMultiple.py | 32 ++++++++++++++++++ python/t/test050HandleProperties.py | 50 +++++++++++++++++++++++++++ python/t/test430ProgressMessages.py | 52 +++++++++++++++++++++++++++++ 5

--- generator/ruby.ml | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/generator/ruby.ml b/generator/ruby.ml index 97ccfdc..0f71ccc 100644 --- a/generator/ruby.ml +++ b/generator/ruby.ml @@ -404,15 +404,17 @@ event_callback_wrapper_wrapper (VALUE argvv) return Qnil; } +/* Callbacks aren't supposed to throw exceptions. We just print the + * exception on

I was going to post this as a patch, but I realize the patch is just working around an actual bug in the libvirt backend [not in libvirt]. Anyway, posting it here so we don't forget about it. Rich.

'tc_410_close_event.rb' was not being run. You could prove this by simply inserting "exit 1" into that test. The reason is unclear, but by renaming every class and method in the tests to be unique, this ensures the tests are run. --- ruby/t/tc_010_load.rb | 4 ++-- ruby/t/tc_020_create.rb | 4 ++-- ruby/t/tc_030_create_flags.rb | 4 ++--

Fixes commit cad3ea9e74bcff0dd42dc2a3710c6b3fa6e868b1 in case Python is disabled, or not available. --- m4/guestfs-python.m4 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/m4/guestfs-python.m4 b/m4/guestfs-python.m4 index 505eba5df..2e736875c 100644 --- a/m4/guestfs-python.m4 +++ b/m4/guestfs-python.m4 @@ -88,7 +88,6 @@ AS_IF([test "x$enable_python" !=

*** BLURB HERE *** Pino Toscano (3): python: modernize inspect_vm example perl: silence usage of add_cdrom in test python: silence usage of add_cdrom in test perl/t/060-handle-properties.t | 7 +++++-- python/examples/inspect_vm.py | 26 ++++++++++++-------------- python/t/test050HandleProperties.py | 5 ++++- 3 files changed, 21 insertions(+), 17 deletions(-) -- 2.20.1

Fixes the majority of the pycodestyle issues in the Python scripts, and fix the existing test-v2v-python-syntax.sh to use pycodestyle to actually perform style checks. Pino Toscano (6): PEP 8: adapt whitespaces in lines PEP 8: move imports at the top PEP 8: adapt empty lines tests: find all the Python scripts for syntax checks -o rhv-upload: remove unused Python imports Revamp check

- use assertIsInstance, assertNotEqual, and assertIsNotNone as more specific checks (will produce better logging) - use assertRaises when expecting exceptions being thrown - when testing internal_test_rhashtable, instead of checking type and elements of the return values just check the return value as a whole (easier and already getting all the work needed by unittest) ---

Look for pycodestyle, and use it to check all the Python sources (tests and auxiliary scripts included) of the Python bindings. --- config.sh.in | 1 + m4/guestfs-python.m4 | 3 +++ python/Makefile.am | 5 +++++ python/test-pycodestyle.sh | 28 ++++++++++++++++++++++++++++ 4 files changed, 37 insertions(+) create mode 100755 python/test-pycodestyle.sh diff --git

Look for pycodestyle, and use it to check all the Python sources (tests and auxiliary scripts included) of the Python bindings. --- config.sh.in | 1 + m4/guestfs-python.m4 | 3 +++ python/Makefile.am | 5 +++++ python/test-pycodestyle.sh | 30 ++++++++++++++++++++++++++++++ 4 files changed, 39 insertions(+) create mode 100755 python/test-pycodestyle.sh diff --git

It turns out that a) the standalone pep8 executable is deprecated in favour of pycodestyle b) $python-pep8 does not exist in modern distros and thus the style checks for Python scripts have been skipped for a long time. Instead, switch to pycodestyle directly, updating the list of ignored issues to the two categories left. --- config.sh.in | 1 + m4/guestfs-progs.m4 |

One test explicitly tests add_cdrom, so silence the deprecation warning only for that function. --- python/t/test050HandleProperties.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/python/t/test050HandleProperties.py b/python/t/test050HandleProperties.py index e2b12f1dc..59de8b806 100644 --- a/python/t/test050HandleProperties.py +++ b/python/t/test050HandleProperties.py

On Thu, Dec 12, 2019 at 11:01:02AM +0100, Vincent Danjean wrote: > [resend to the good (cloned) bug, sorry for the message in the original bug, > it was a mistake] > > Hi, > > On Thu, 5 Dec 2019 11:12:56 +0000 "Richard W.M. Jones" <rjones@redhat.com> wrote: > > I believe this is a new bug and nothing much to do with: > >

Verify the returned values of Python Object constructor functions are not NULL before adding them to a collection. This is particularly relevant when constructing Unicode strings in Python 3 as they will return NULL if non UTF-8 characters are present. Signed-off-by: Matteo Cafasso <noxdafox@gmail.com> --- generator/python.ml | 102 ++++++++++++++++++++++++++---------------

Make sure they can build also in no as-neede setups. Pino Toscano (1): utils: split string list functions in own file build: use split stringlist functions from common/utils utils/Makefile.am | 2 + utils/guestfs-stringlists-utils.h | 30 +++++ utils/guestfs-utils.h | 7 +- utils/stringlists-utils.c | 197 ++++++++++++++++++++++++++++++ utils/utils.c

Cast the value to the "int_type" representing the "long" value for test_rint64, so the test works again with Python 3. --- python/t/test090RetValues.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/python/t/test090RetValues.py b/python/t/test090RetValues.py index 7ff51f0..24d97b4 100644 --- a/python/t/test090RetValues.py +++

The OCaml and Python bindings directly use the utils.c source in common/utils, mostly for guestfs_int_free_string_list. That source contained also functions using gnulib functions, however without linking to gnulib. When building with default build flags (e.g. without as-needed mode), the gnulib symbols cannot be resolved, leading to unusable OCaml and Python libraries. As solution, update the