similar to: [PATCH] python: remove also __pycache__ directories on clean

The OCaml and Python bindings directly use the utils.c source in common/utils, mostly for guestfs_int_free_string_list. That source contained also functions using gnulib functions, however without linking to gnulib. When building with default build flags (e.g. without as-needed mode), the gnulib symbols cannot be resolved, leading to unusable OCaml and Python libraries. As solution, update the

Make sure they can build also in no as-neede setups. Pino Toscano (1): utils: split string list functions in own file build: use split stringlist functions from common/utils utils/Makefile.am | 2 + utils/guestfs-stringlists-utils.h | 30 +++++ utils/guestfs-utils.h | 7 +- utils/stringlists-utils.c | 197 ++++++++++++++++++++++++++++++ utils/utils.c

'make distcheck' calls us out for leaving files behind after 'make distclean' that were not present in the tarball. Either these files are expensive enough that end users should not be required to regenerate them (so they should be distributed), or they should be cleaned when a user asks to get back to the pristine tarball state. Automake suggests this hierarchy of cleaning:

Use CLEANFILES to remove the generated symlinks, and just ignore the errors when copying the scripts in srcdir!=builddir situations. Followup of commit 40ac54829d4e71b1bac76343872a2674a40c7ac0. --- bash/Makefile.am | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/bash/Makefile.am b/bash/Makefile.am index 780da64..ee9c10c 100644 --- a/bash/Makefile.am +++

By adding common CLEANFILES and DISTCLEANFILES variables to common-rules.mk, we can remove these from most other Makefiles, and also clean files more consistently. Note that bin_PROGRAMS are already cleaned by 'make clean', so I removed cases where these were unnecessarily added to CLEANFILES. --- .gitignore | 1 + Makefile.am | 6

--- configure.ac | 2 +- golang/Makefile.am | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 4e2bc65..9abec95 100644 --- a/configure.ac +++ b/configure.ac @@ -1530,7 +1530,7 @@ AS_IF([test "x$enable_golang" != "xno"],[ AC_CHECK_PROG([GOLANG],[go],[go],[no]) AS_IF([test "x$GOLANG" !=

There were a few "infelicities" that kept the "make distcheck" test from passing. These three patches combine to fix all of them, punting on only one by disabling the install-data-hook rule. >From 7504acedcb71bd80d99abe412e6669b267cade38 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Fri, 21 Aug 2009 13:37:18 +0200 Subject: [PATCH 1/3]

Make the tests 'check_DATA' so they only get built when running the tests. This saves a couple of seconds on the build time. --- ocaml/Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am index e781363..a535b43 100644 --- a/ocaml/Makefile.am +++ b/ocaml/Makefile.am @@ -142,9 +142,9 @@ endif TESTS = run-bindtests

some files depend on nodes.h, but there is no dependency for that fact. olaf@mandarine:~/klibc-0.87> grep -Er 'include.*nodes.h' ash/ | sed 's-^[^/]\+/\([^.]*\).*-\1.o-' | xargs echo OBJ_NODES = OBJ_NODES = cd.o eval.o exec.o expand.o jobs.o main.o nodes.o options.o parser.o redir.o show.o trap.o var.o make spotless doesnt work reliable, the patch adds a few more targets. Is

--- mllib/Makefile.am | 2 +- src/Makefile.am | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mllib/Makefile.am b/mllib/Makefile.am index 0e317b2..ec624c9 100644 --- a/mllib/Makefile.am +++ b/mllib/Makefile.am @@ -18,7 +18,7 @@ include $(top_srcdir)/subdir-rules.mk EXTRA_DIST = \ - $(SOURCES) + $(filter-out config.ml.in,$(SOURCES)) CLEANFILES = *~ *.cmi *.cmo *.cmx

--- ruby/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ruby/Makefile.am b/ruby/Makefile.am index b6654d3..e78ab59 100644 --- a/ruby/Makefile.am +++ b/ruby/Makefile.am @@ -51,7 +51,7 @@ RUBY_SITEARCH := $(shell $(RUBY) -rrbconfig -e "puts RbConfig::CONFIG['sitearchd install: $(MKDIR_P) $(DESTDIR)$(RUBY_SITELIB) $(MKDIR_P)

On Thu, Dec 13, 2018 at 08:55:41AM -0600, Eric Blake wrote: > diff --git a/tests/Makefile.am b/tests/Makefile.am > index 4c7b59c..55db593 100644 > --- a/tests/Makefile.am > +++ b/tests/Makefile.am > @@ -32,7 +32,8 @@ > > include $(top_srcdir)/common-rules.mk > > -MAINTAINERCLEANFILES = > +CLEANFILES = Because common-rules.mk defines CLEANFILES, this should be

Patch #7 depends on: https://www.redhat.com/archives/libguestfs/2020-January/msg00035.html No, Python < 3 support is not dropped yet, however it will be easier after this series. Pino Toscano (7): build: enforce a minimum Python version python: drop code for Python < 2.5 python: assume support for Capsules python: remove compile time check for PyString_AsString python: replace

You have to use: ../libguestfs/run ./configure ../libguestfs/run make Use of the second ../libguestfs/run against make is unfortunate but I believe it's unavoidable due to the way that ocamlfind works. --- .gitignore | 1 + ocaml/Makefile.am | 19 ++++++++++++++++++- run.in | 2 ++ 3 files changed, 21 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore

Steps to do gluster clean up 1. umount -f /export/home/ecmsftp 2. Remove the /export/home/ecmsftp mount point line from /etc/fstab file if it exists. 3. Delete gluster file system volume if it exists; ignore if it does not exist. # gluster gluster>volume list eftpVol gluster> volume stop eftpVol Stopping volume will make its data inaccessible. Do you want to

# HG changeset patch # User Tim Deegan <tim@xen.org> # Date 1333621466 -3600 # Node ID 4b6bf18b6790e3713ddc4fdc1d63e54b4635c57b # Parent d690c7e896a26c54a5ab85458824059de72d5cba tools/blktap2: fix ''make clean'' Signed-off-by: Tim Deegan <tim@xen.org> diff -r d690c7e896a2 -r 4b6bf18b6790 tools/blktap2/lvm/Makefile --- a/tools/blktap2/lvm/Makefile Thu Apr 05 11:06:03

Traverse the po-docs directory before the subdirectories with translated documentations, so we can make sure that libguestfs-docs.pot and the translated .pod files have been generated. As a consequence of that, when generating the translated manpages for documentations, all the needed .pod files should be already there. --- po-docs/Makefile.am | 6 +++++- 1 file changed, 5 insertions(+), 1

--- configure.ac | 2 +- images/Makefile.am | 5 +++-- lib/Makefile.am | 14 +++++++------- ocaml/Makefile.am | 3 ++- ocaml/t/hivex_300_fold.ml | 3 +-- python/run-python-tests | 25 ------------------------- python/run-python-tests.in | 25 +++++++++++++++++++++++++ 7 files changed, 39 insertions(+), 38 deletions(-) delete mode

Without this change all the tests in the haskell bindings are rebuilt every time. The primary motivation for this change is to fix this. The fix for the above also allows parallel builds to be re-enabled. --- haskell/Makefile.am | 56 +++++++++++++++++++++++++++++++++++++++-------------- 1 file changed, 41 insertions(+), 15 deletions(-) diff --git a/haskell/Makefile.am b/haskell/Makefile.am

This change avoids the hard requirement for qemu-tools during package build. Signed-off-by: Olaf Hering <olaf@aepfle.de> --- The current OPTGROUP_SD_JOURNAL_NOT_AVAILABLE failure blocks a complete build for me, I think the build got past the point of the failure fixed by this patch. tests/data/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git