similar to: [PATCH 0/2] tests: simpler way to use configure results

Run xmllint to validate the XML output files of virt-inspector, so the schema is checked against actual output of virt-inspector. --- .gitignore | 1 + configure.ac | 2 ++ inspector/{test-virt-inspector.sh => test-virt-inspector.sh.in} | 2 ++ 3 files changed, 5 insertions(+) rename

v2: - Changes as suggested by Pino in previous review.

[This email is either empty or too large to be displayed at this time]

Instead of generating test scripts from configure with the path of xmllint, export that path in config.sh, so the tests can be static scripts again. --- .gitignore | 3 --- config.sh.in | 2 ++ configure.ac | 6 ------ ...irt-inspector-luks.sh.in =>

Run xmllint to validate the XML output files of virt-inspector, so the schema is checked against actual output of virt-inspector. --- inspector/test-virt-inspector.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/inspector/test-virt-inspector.sh b/inspector/test-virt-inspector.sh index 2f55cdc..33d749c 100755 --- a/inspector/test-virt-inspector.sh +++ b/inspector/test-virt-inspector.sh @@

Here's what I needed to build and run 1.20 on Debian/unstable. Perhaps the libcap2 dependency in the packagelist should only be added if libcap has actually been used in building guestfsd...

Fix one dist issue, and various builddir!=srcdir issues, also with the patch proposed in the Debian bug #946594. Patch #3 applies also to the virt-v2v repository, and will be committed there too (with references to the libguestfs commit). Pino Toscano (3): inspector: ship the actual test script tests: fix srcdir references build: fix make implicit dependencies on ml/mli files

This is my proposed alternative to the complicated test framework (https://www.redhat.com/archives/libguestfs/2015-August/msg00022.html). In this patch, when we want to run tests on installed packages we just copy in the installed binaries over the source directory, and run the test suite as normal. This is basically the same as the current (not used) contrib/make-check-on-installed.pl script,

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2168506 This small set covers the new /dev/mapper/VG-LV "--key" ID format in the LUKS-on-LVM virt-inspector test. Thanks, Laszlo Laszlo Ersek (3): update common submodule inspector: rename VGs and LVs in LUKS-on-LVM test inspector: test /dev/mapper/VG-LV translation in LUKS-on-LVM test common

--- daemon/Makefile.am | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index e23ce86..af075d7 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -42,10 +42,10 @@ noinst_LIBRARIES = libprotocol.a libprotocol_a_SOURCES = guestfs_protocol.c guestfs_protocol.h libprotocol_a_CFLAGS = -Wall -Wno-unused -fno-strict-aliasing

We observed a while back that the Perl-based libguestfs tools were not being localized. In fact I've tracked this problem down to a regression some time ago and some subsequent changes we made. These two patches fix everything. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many

This has got to the stage where it actually works, both for running the tests in-tree and installed. The 'test-harness' script has become rather over-complex in the process however. Rich.

Since v4: - More tests have been converted. - Testing local guests fixed. - Drop no-exec-stack test.

After we upgraded to 1.2.12, we've been having issues with libvirt... it complains that our formerly valid guest definitions are now invalid: error: Failed to start domain XXXX error: internal error: Cannot instantiate filter due to unresolvable variables or unavailable list elements: DHCPSERVER We looked into this, and found that it's the XML validation that's failing: # xmllint

These are my thoughts on adding a test harness to run tests instead of using automake. The aim of this exercise is to allow us to run the full test suite on an installed copy of libguestfs. Another aim is to allow us to work around all the limitations and problems of automake. The first patch makes an observation that since the ./run script sets up $PATH to contain all the directories

Hi, thanks for your response. Based from your advice I try to check the XML used the command "xmllint --noout /etc/icecast2/icecast.xml" . Because I got response "xmllint: command not found", I installed xmllint (sudo apt-get install libxml2-utils). After that, I check again (xmllint --noout /etc/icecast2/icecast.xml) and the result just return to the prompt (which means XML

This converts more of the tests (basically everything under tests/) to use the test harness, revealing some problems which have subsequently been fixed. Rich.

For v6: This is mainly just a rebase, but I have also added tests in the ocaml/ language bindings directory, and for all the OCaml-written virt tools. Rich.

v7: The only changes since v6 are those suggested by Pino in the review of v5.

I should probably start by saying this patch series isn't ready for review yet. This patch series adds a test harness to libguestfs. It allows us to run the tests outside the ordinary 'make check' path in the build tree. In particular, you can use this to run tests when libguestfs has been installed. 'make check' and the other 'make check-*' rules still work. The