similar to: Long running nbdkit tests

I pushed a change which should reduce the time taken in the test-cache-* and test-cow.sh tests. Again note this is double TCG which is the worst case for these tests and explains the excessively long times which wouldn't be seen on a normal build system. Updated results: 01:04:18 PASS: test-readahead 01:02:32 PASS: test-cow.sh 00:37:25 PASS: test-floppy.sh 00:34:57 PASS: test-shell 00:34:53

--- .../nbdkit-partitioning-plugin.pod | 29 ++-- plugins/partitioning/virtual-disk.h | 12 +- plugins/partitioning/partition-mbr.c | 132 +++++++++++++++--- plugins/partitioning/partitioning.c | 28 ++-- plugins/partitioning/virtual-disk.c | 42 +++++- tests/Makefile.am | 4 +- tests/test-partitioning5.sh

This is a revised version of the two series previously posted here: https://www.redhat.com/archives/libguestfs/2019-January/msg00137.html https://www.redhat.com/archives/libguestfs/2019-January/msg00139.html There have been many smaller changes but the highlights are: - Using SECTOR_SIZE instead of hard-coding 512 everywhere. - Additional safety checks that the EBR chain doesn't jump

An evolution of the patch I posted yesterday to qemu-devel (https://www.mail-archive.com/qemu-devel@nongnu.org/msg588920.html) which (a) works and (b) has a test. Rich.

v1 was here: https://www.redhat.com/archives/libguestfs/2019-January/thread.html#00198 For v2 I changed most existing prerequisite tests to use the new mechanism. I only changed simple tests. There are a few more complex tests that don't fit the “requires model” and those are not changed. I normalized qemu-io/qemu-img testing to always use the --version flag, where previously we used a mix

--- tests/functions.sh.in | 17 ++++++++++++++++- tests/test-cache-max-size.sh | 18 +++--------------- tests/test-data-7E.sh | 8 ++------ tests/test-data-base64.sh | 12 ++++-------- tests/test-data-file.sh | 8 ++------ tests/test-data-raw.sh | 8 ++------ tests/test-eflags.sh | 13

Since both the partitioning plugin and partition filter now support MBR logical partitions, the original test for GPT (test-partitioning4.sh) can be duplicated and modified to test MBR. --- tests/Makefile.am | 4 +- tests/test-partitioning4.sh | 2 +- tests/test-partitioning6.sh | 92 +++++++++++++++++++++++++++++++++++++ 3 files changed, 96 insertions(+), 2 deletions(-) diff --git

On 1/23/19 9:36 AM, Richard W.M. Jones wrote: > +++ b/tests/functions.sh.in > @@ -1,7 +1,7 @@ > # nbdkit > # Common functions used by the tests. > # @configure_input@ > -# Copyright (C) 2017-2018 Red Hat Inc. > +# Copyright (C) 2017-2019 Red Hat Inc. > # All rights reserved. > # > # Redistribution and use in source and binary forms, with or without > @@

I think this addresses everything in Eric's v2 review. Note that the first patch is best viewed using ‘-w’ to ignore whitespaces changes. Rich.

This time it should hopefully work. I tested all 3 combinations: autoconf ./configure [--disable-linuxdisk | --enable-linuxdisk | <nothing> ] make clean && make && make check and they all appear to do the right thing. Rich.

On 1/21/19 12:15 PM, Richard W.M. Jones wrote: > --- > .../nbdkit-partitioning-plugin.pod | 29 ++-- > plugins/partitioning/virtual-disk.h | 12 +- > plugins/partitioning/partition-mbr.c | 132 +++++++++++++++--- > plugins/partitioning/partitioning.c | 28 ++-- > plugins/partitioning/virtual-disk.c | 42 +++++- >

This implements support for MBR logical partitions in nbdkit-partition-filter, complementing existing support in the partitioning plugin. Rich.

Test the partition filter against real life partition tables created by sfdisk. --- tests/test-partition.c | 101 --------------------------- README | 2 + tests/Makefile.am | 7 +- tests/test-partition.sh | 148 ++++++++++++++++++++++++++++++++++++++++ 4 files changed, 152 insertions(+), 106 deletions(-) diff --git a/tests/test-partition.c b/tests/test-partition.c

Test the partition filter against real life partition tables created by sfdisk. --- tests/test-partition.c | 101 ------------------------ README | 2 + tests/Makefile.am | 7 +- tests/test-partition1.sh | 165 +++++++++++++++++++++++++++++++++++++++ 4 files changed, 169 insertions(+), 106 deletions(-) diff --git a/tests/test-partition.c b/tests/test-partition.c

On Wed, Jan 23, 2019 at 10:02:18AM -0600, Eric Blake wrote: > > +++ b/tests/test-ip.sh > > @@ -37,26 +37,17 @@ > > source ./functions.sh > > set -e > > > > -rm -f ip.pid ipv4.out ipv6.out > > -cleanup_fn rm -f ip.pid ipv4.out ipv6.out > > +requires ss --version > > +requires ip -V > > +requires qemu-img --version > > > >

Another interesting thing you can do with this plugin: https://rwmj.wordpress.com/2019/02/19/nbdkit-linuxdisk-plugin/ v2: - Fix inconsistent tab/space. - All 3 plugins now contain a block of text pointing to the other 2 plugins. - TMDIR -> TMPDIR - Unlink the temporary file and other cleanups along error paths. - fclose -> pclose, and check the return value for errors. -

Turns out Japanese trains are good for coding! In supermin we have a bunch of code to create the libguestfs appliance. It creates it directly using libext2fs (part of e2fsprogs). We can use the same technique to create ext2 virtual disks in nbdkit, which is what this new plugin does. Why a new plugin instead of modifying the floppy plugin? See the 4/4 commit message for an explanation. The

From: "Richard W.M. Jones" <rjones@redhat.com> This plugin allows you to create a complete ext2, ext3 or ext4 filesystem in a GPT partitioned disk image. This can be attached as a disk to a Linux virtual machine. It is implemented using e2fsprogs mke2fs ‘-d’ option thus allowing the implementation to be very small and simple, with all the hard work done by mke2fs. Although

For v3 I reimplemented this using mke2fs -d. This obviously makes the implementation a whole lot simpler, but cannot support multiple directory merging. Patches 1-3 are the same as before. I've also reproduced the notes from v2 below. v2: - Fix inconsistent tab/space. - All 3 plugins now contain a block of text pointing to the other 2 plugins. - TMDIR -> TMPDIR - Unlink the

From: "Richard W.M. Jones" <rjones@redhat.com> This plugin allows you to create a complete ext2 filesystem in a GPT partitioned disk image. This can be attached as a disk to a Linux virtual machine. It is implemented using libext2fs (the same as supermin). Although there is some overlap with nbdkit-iso-plugin and nbdkit-floppy-plugin, the implementations and use cases of all