similar to: [libnbd PATCH] docs: Ensure .3 files get built

‘make clean && make’ was not rebuilding the docs/*.3 files. The reason is obscure: - docs/Makefile has rules: MANS = $(man_MANS) all: all-am all-am: Makefile $(MANS) - sinclude docs/Makefile.inc happened long after MANS is defined, so MANS held the earlier version of $(man_MANS) without the api-built man pages listed. This was confirmed by looking at the output of

Automake insists that any file present in a Makefile.am 'include' must be present, but it has no idea about the GNU make extension 'sinclude'. Use this to our advantage: as long as Makefile.inc has nothing other than variable modifications (done in the previous patch), and our rules properly generate it when needed (thanks to generator_built), then running 'make' will

Rich recently patched things to generate one man page per function rather than libnbd-api.3 (nice), but in doing so got stumped by a problem with a fresh git clone (automake fails for any 'include' directive that does not already exist). I've figured out how to hack around it, but the hack requires GNU make. We already use GNU make constructs elsewhere (such as $(wildcard)), but

Copies heavily after a similar addition recently made in nbdkit. --- docs/Makefile.am | 7 +++++++ docs/libnbd-security.pod | 32 ++++++++++++++++++++++++++++++++ docs/libnbd.pod | 1 + Makefile.am | 1 + .gitignore | 3 ++- SECURITY | 14 ++++++++++++++ 6 files changed, 57 insertions(+), 1 deletion(-) create mode 100644

Copies heavily after a similar addition recently made in nbdkit. --- I'm not sure if .1 or .3 fits better for the man page. With nbdkit, .1 made sense because 'nbdkit' is a standalone program; but with libnbd, our only standalone is nbdsh, yet naming it nbdsh-security seems off. docs/Makefile.am | 7 +++++++ docs/libnbd-security.pod | 32 ++++++++++++++++++++++++++++++++

This borrows from a trick in libvirt - by defining $(NULL) to expand to an empty string, we can more consistently write multi-line macros where all useful lines terminate with \, making it easier to add/remove lines without worrying about whether \ needs to be touched up on neighboring lines. --- Looks big, but is fairly mechanical. I'm also doing a similar patch for nbdkit, where it would

Greetings everyone. I have 2 quick questions about ao/ao.m4, ogg/ogg.m4, and vorbis/vorbis.m4. 1. Is there any reason that the macros are named AM_PATH_AO, AM_PATH_OGG, and AM_PATH_VORBIS? Can we change them to something else? I ran into a problem when trying to add support for ogg/vorbis into a package today: Automake assumes that anything beginning with AM_ belongs to automake -- these two

We use a similar trick to libvirt and libguestfs to allow external C programs that use libnbd to be compiled against the built (but not installed) libnbd with: ../libnbd/run ./configure make What actually happens is we have a second pkg-config file (lib/local/libnbd.pc) which points to the locally built libnbd. The ./run script sets up PKG_CONFIG_PATH to point to this directory. Assuming

From: "Richard W.M. Jones" <rjones at redhat.com> To allow us to name the socket passed down to the NBD server when calling nbd_connect_systemd_socket_activation(3), we need to add the field to the handle and add access functions. [Laszlo's notes: - Originally posted by Rich at <https://listman.redhat.com/archives/libguestfs/2023-January/030557.html> (Message-Id:

This simply compiles, passes tests, but is only able open a handle. This commit does not contain the full bindings. --- Makefile.am | 2 + configure.ac | 32 +++++ generator/GoLang.ml | 116 ++++++++++++++++++ generator/GoLang.mli | 19 +++ generator/Makefile.am

On 4/17/23 18:44, Nir Soffer wrote: > When building from git we need autoconf, automake and libtool. > > Signed-off-by: Nir Soffer <nsoffer at redhat.com> > --- > > Changes sinve v1: > - Remove `,` between package namses (Laszlo) > > README.md | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/README.md b/README.md > index

This simply compiles, passes tests, but is only able open a handle. This commit does not contain the full bindings. --- Makefile.am | 2 + configure.ac | 32 ++++ generator/GoLang.ml | 150 ++++++++++++++++++ generator/GoLang.mli | 19 +++ generator/Makefile.am

This patch cleans up the vorbis-tools Makefile.am files so they work with both automake 1.4 and 1.6. Some changes to configure.in were also needed in order to get things to work (and to fix some ac 2.50 issues). Please remove config.h from cvs as it is a generated file and empty anyway. automake 1.6 isn't really incompatable with 1.4, it's just more picky about you sticking to the rules:

Wrap "copy/nbd-ops.c" at 80 characters. I couldn't find a way to test that this change is unobservable. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2172516 Acked-by: Richard W.M. Jones <rjones at redhat.com> Signed-off-by: Laszlo Ersek <lersek at redhat.com> --- Notes: v2: - pick up Rich's ACK copy/nbd-ops.c | 5 ++++- 1 file changed, 4

This is just a basic ugly support, not meant to be pushed (at least for now). There is quite a lot missing, but there is an example which shows that it really works. And valgrind reports that all allocations were freed. The way the code is generated is also not nice, I wish there was more code actually written in some files and not generated by the generator (as much hard-coded static strings as

On Thu, Dec 12, 2019 at 06:05:05PM +0100, Pino Toscano wrote: > src/lib.rs is not created by the generator, while src/guestfs.rs is. > --- > rust/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/rust/Makefile.am b/rust/Makefile.am > index edcccffa1..cb16e021f 100644 > --- a/rust/Makefile.am > +++ b/rust/Makefile.am > @@ -19,7

Based on Laszlo's approval of my idea here: https://listman.redhat.com/archives/libguestfs/2023-September/032661.html but as I would like to resync human-size.h back to nbdkit, I'm reluctant to apply patch 1 this until I get Rich's consent to relicensing (this email serves as my consent for my contribution here): https://listman.redhat.com/archives/libguestfs/2023-October/032755.html

When building from git we need autoconf, automake and libtool. Signed-off-by: Nir Soffer <nsoffer at redhat.com> --- README.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/README.md b/README.md index c7166613..42a187c0 100644 --- a/README.md +++ b/README.md @@ -32,10 +32,17 @@ ## License very liberal license. ## Building from source +Building from source requires

On 4/17/23 18:36, Nir Soffer wrote: > When building from git we need autoconf, automake and libtool. > > Signed-off-by: Nir Soffer <nsoffer at redhat.com> > --- > README.md | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/README.md b/README.md > index c7166613..42a187c0 100644 > --- a/README.md > +++ b/README.md > @@ -32,10 +32,17 @@ ##

When building from git we need autoconf, automake and libtool. Signed-off-by: Nir Soffer <nsoffer at redhat.com> --- Changes sinve v1: - Remove `,` between package namses (Laszlo) README.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/README.md b/README.md index c7166613..7eed0e31 100644 --- a/README.md +++ b/README.md @@ -32,10 +32,17 @@ ## License very liberal license.