similar to: [PATCH] v2v: -o rhv-upload: fix the phony ovirtsdk4 module

Add the missing objects, methods, variables, and relations among the various objects. Followup/fixes commit c49aa4fe01aac82d4776dd2a3524ce16e6deed06, and commit 8118f28b6ff93c11f92fd65873285c2eba10ea0a. --- .../ovirtsdk4/__init__.py | 25 +++++++++++++------ .../ovirtsdk4/types.py | 19 ++++++++++---- 2 files changed, 31 insertions(+), 13 deletions(-)

In the precheck script, check that the target cluster actually exists. This will avoid errors when creating the VM after the data copying. --- v2v/rhv-upload-precheck.py | 10 ++++++++++ v2v/test-v2v-o-rhv-upload-module/ovirtsdk4/__init__.py | 7 +++++++ 2 files changed, 17 insertions(+) diff --git a/v2v/rhv-upload-precheck.py b/v2v/rhv-upload-precheck.py index

v1 was here: https://www.redhat.com/archives/libguestfs/2018-September/msg00121.html v2: - Rewrote patch 2 from scratch so it incorporates Nir's suggestions. - Add fake module to EXTRA_DIST. - Retested. Unfortunately I am no longer able to test the ordinary conversion path because ovirtsdk4 is incompatible with Fedora 29 / Python 3.7:

This adds a test of -o rhv-upload. Obviously for an upstream test we cannot require a working oVirt server. This test works by faking the ovirtsdk4 Python module, setting PYTHONPATH so that the fake module is picked up instead of the real module (if installed). However it's more complex than that because the nbdkit plugin also expects to talk to a working imageio HTTPS server. Therefore

Fixes the majority of the pycodestyle issues in the Python scripts, and fix the existing test-v2v-python-syntax.sh to use pycodestyle to actually perform style checks. Pino Toscano (6): PEP 8: adapt whitespaces in lines PEP 8: move imports at the top PEP 8: adapt empty lines tests: find all the Python scripts for syntax checks -o rhv-upload: remove unused Python imports Revamp check

Previously this output method was almost completely untested. This commit adds a fake ovirtsdk4 module so we can test the -o rhv-upload method fairly completely without needing an actual oVirt instance around. --- v2v/Makefile.am | 4 + .../ovirtsdk4/__init__.py | 146 ++++++++++++++++++ .../ovirtsdk4/types.py | 125

On Thu, Sep 20, 2018 at 11:51 AM Richard W.M. Jones <rjones@redhat.com> wrote: > Previously this output method was almost completely untested. > > This commit adds a fake ovirtsdk4 module so we can test the > -o rhv-upload method fairly completely without needing an actual > oVirt instance around. > --- > v2v/Makefile.am | 4 + >

We were not considering failures while initializing the transfer. In this case the transfer phase can change to PAUSED_SYSTEM or FINISHED_FAILURE, and transfer_url will be None, which failed the upload with a misleading error: RuntimeError: direct upload to host not supported, requires ovirt-engine >= 4.2 and only works when virt-v2v is run within the oVirt/RHV environment, eg. on

On Fri, Dec 7, 2018, 10:34 Richard W.M. Jones <rjones@redhat.com wrote: > On Fri, Dec 07, 2018 at 02:44:21AM +0200, Nir Soffer wrote: > > Fix rhv-cafile option access, broken by commit 6694028f9827 (v2v: -o > > rhv-upload: Only set SSL context for https connections). > > Ugh yes indeed. Strong typing FTW _again_ "pylint -E" may detect such issues. ... >

Check earlier whether the ovirtsdk4 Python can be imported correctly, to avoid errors later on during the migration. --- v2v/output_rhv_upload.ml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/v2v/output_rhv_upload.ml b/v2v/output_rhv_upload.ml index 0152b8d5a..63fa2411a 100644 --- a/v2v/output_rhv_upload.ml +++ b/v2v/output_rhv_upload.ml @@ -126,6 +126,13 @@ class output_rhv_upload

On Mon, Oct 15, 2018 at 05:13:31PM +0100, Richard W.M. Jones wrote: > On Mon, Oct 15, 2018 at 06:43:10PM +0300, Nir Soffer wrote: > > On Mon, Oct 15, 2018 at 6:21 PM Richard W.M. Jones <rjones@redhat.com> > > wrote: > > > > > On Tue, Oct 09, 2018 at 02:28:10PM +0300, Nir Soffer wrote: > > > > > +# Create a background thread running a web server

On Mon, Mar 18, 2019 at 06:51:26PM +0200, Daniel Erez wrote: > After invoking transfer_service.finalize, check operation > status by examining DiskStatus. > This is done instead of failing after a predefined timeout > regardless the status. > > * not verified * > > Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1680361 > --- > v2v/rhv-upload-plugin.py | 19

On Fri, Aug 09, 2019 at 02:58:18AM +0300, Nir Soffer wrote: > On Thu, Aug 8, 2019 at 5:05 PM Richard W.M. Jones <rjones@redhat.com> wrote: > > > > + if disk.status == types.DiskStatus.OK: > > > + debug("finalized after %s seconds", time.time() - > > start) > > > > Maybe this was the real error? (using ,

After invoking transfer_service.finalize, check operation status by examining ImageTransferPhase and DiskStatus. This is done instead of failing after a predefined timeout regardless the status. * not verified * Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1680361 --- v2v/rhv-upload-plugin.py | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git

It will be used to do extra checks in the output before copying the disks. Partially revert commit 3bafec4e693a25ef1c84abc0fd1bc3251862c7de. --- v2v/output_glance.ml | 2 +- v2v/output_json.ml | 2 +- v2v/output_libvirt.ml | 2 +- v2v/output_local.ml | 2 +- v2v/output_null.ml | 2 +- v2v/output_openstack.ml | 2 +- v2v/output_qemu.ml | 2 +- v2v/output_rhv.ml

On Thursday, 19 September 2019 08:23:46 CEST Pino Toscano wrote: > Add the missing objects, methods, variables, and relations among the > various objects. > > Followup/fixes commit c49aa4fe01aac82d4776dd2a3524ce16e6deed06, and > commit 8118f28b6ff93c11f92fd65873285c2eba10ea0a. > --- Consider the following change squashed to this commit: diff --git

The first four patches are straightforward. The final patch adds the -o rhv-upload output mode. It is still spooling into a temporary file because I've had some trouble getting streaming conversions working. There are other problems as outlined in the commit message, so this patch is not ready for upstream but is good for discussion. Also I hit this, which I'm assuming for now will be

On Thu, Nov 28, 2019 at 09:34:18PM +0200, Nir Soffer wrote: > We were not considering failures while initializing the transfer. In > this case the transfer phase can change to PAUSED_SYSTEM or > FINISHED_FAILURE, and transfer_url will be None, which failed the > upload with a misleading error: > > RuntimeError: direct upload to host not supported, requires >

This is actually not required, because ovirtsdk4 will use the system's global trust store if necessary. Therefore we can make it optional in all cases. --- docs/virt-v2v-output-rhv.pod | 5 ++++- v2v/output_rhv_upload.ml | 2 -- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/virt-v2v-output-rhv.pod b/docs/virt-v2v-output-rhv.pod index 04a894268..4520c9184 100644 ---

On Mon, Oct 15, 2018 at 6:21 PM Richard W.M. Jones <rjones@redhat.com> wrote: > On Tue, Oct 09, 2018 at 02:28:10PM +0300, Nir Soffer wrote: > > > +# Create a background thread running a web server which is > > > +# simulating the imageio server. > > > > > > > This functionality should be separated from the fake SDK module, since > it is > >