similar to: Versioning of rust bindings

On Tue, Aug 06, 2019 at 06:04:22PM +0900, Hiroyuki Katsura wrote: > In the last patch, I let the version of Rust bindings be the same as the > version of libguestfs. However, I came to think it is not preferable in > terms of the custom of Rust crate versioning. > > After a version of a crate is published to crates.io, no one can republish > the crate with the same version. This

On Monday, 5 August 2019 08:59:31 CEST Hiroyuki Katsura wrote: > Without clarifying handle's lifetime, it is unable > to see how long the callbacks which the handle > owns will live. Then, Rust compiler will infer > that the callbacks have 'static lifetime. It is > not convenient for users. > --- My initial idea was to split the Handle -> Handle<'a> change

On Fri, Jul 05, 2019 at 08:37:20AM +0100, Richard W.M. Jones wrote: >On Fri, Jul 05, 2019 at 01:28:12PM +0900, Hiroyuki Katsura wrote: >> > Have you decided whether we need to commit the generated files >> > (Cargo.toml, Cargo.lock)? It looks like in this series those files >> > are still included and not added to .gitignore. >> >> I'm sorry I forgot

`cargo doc` will generate docs with long descriptions. I did not add the settings of outputting these docs to `/website`. This is because - by publishing this crate to crates.io, users can see the docs in `docs.rs` like `https://docs.rs/guestfs/<version>/guestfs/`. It is easy to hold multiple documents corresponding to each version. - the style of the documents generated by `cargo doc`

I fixed based on comments. I'll send these two patches to this mailing list. - Fix Handle -> Handle<'a> - Add events Regards, Hiroyuki 2019年8月1日(木) 0:01 Pino Toscano <ptoscano@redhat.com>: > Hi Hiroyuki, > > On Tuesday, 30 July 2019 07:51:37 CEST Hiroyuki Katsura wrote: > > This patch includes: > > > > - Event callback handlers > > -

> Have you decided whether we need to commit the generated files > (Cargo.toml, Cargo.lock)? It looks like in this series those files > are still included and not added to .gitignore. I'm sorry I forgot adding Cargo.lock to .gitignore. I'll add it to .gitignore. However, I think Cargo.toml should be staged. This is because this is a file managed by hands. It contains

This patch includes: - Event callback handlers - Tests related to events(410-430) --- generator/rust.ml | 38 ++++++- rust/src/base.rs | 24 +++-- rust/src/error.rs | 8 +- rust/src/event.rs | 158 ++++++++++++++++++++++++++++ rust/src/lib.rs | 2 + rust/tests/040_create_multiple.rs | 2 +-

I added - data required to publish this crate to `crates.io`. - README.md which contains the details of how to publish this crate. --- rust/Cargo.toml.in | 5 ++++- rust/README.md | 42 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 46 insertions(+), 1 deletion(-) create mode 100644 rust/README.md diff --git a/rust/Cargo.toml.in b/rust/Cargo.toml.in index b61e3ec7f..d217a530e

On Mon, Jul 08, 2019 at 10:10:10AM +0200, Pino Toscano wrote: >On Saturday, 6 July 2019 13:03:24 CEST Martin Kletzander wrote: >> Just one thing, the Cargo.toml includes a version under which the crate would be >> published. I presume the version would be the same as the one of the project >> itself, i.e. when releasing libguestfs-x.y.z, we publish guestfs-rs-x.y.z to

On Thu, Jun 27, 2019 at 06:27:05PM +0900, Hiroyuki Katsura wrote: > > I guess this is a stray debug message? > > Yes. I'm sorry... > > > we did *not* check them into git. > > Really? Does it mean that every time you build the library, Cargo.toml is > generated? That's how it has worked in nbdkit. Whether it's right or not I don't know. Normally

On Thu, Jun 27, 2019 at 05:06:04PM +0900, Hiroyuki Katsura wrote: > From: Hiroyuki_Katsura <hiroyuki.katsura.0513@gmail.com> > > --- > generator/rust.ml | 13 ++++++++--- > run.in | 9 ++++++++ > rust/Cargo.lock | 6 +++++ > rust/Cargo.toml | 4 +--- > rust/tests/010_load.rs

Hello @R-devel I needed some statistical functions for a project I was working on in Rust, and I've used the R math library as a standalone solution. I thought the R developers would be interested in the fact that their work is being used elsewhere, and I also wanted to say thanks for some code I do NOT want to have to write myself! The "crate" (Rust's name for a package) is at

The existing Rust bindings for nbdkit aren't very idiomatic Rust, and they are missing a lot of features. So I've rewritten them. The new bindings aren't backwards compatible, but I doubt that's a problem. Most likely, nobody has tried to use them yet, since the crate hasn't even published to crates.io. Please review the attached patch. -Alan

On Mon, Jun 15, 2020 at 02:22:32PM +0100, Richard W.M. Jones wrote: > On Thu, Jun 11, 2020 at 04:19:08PM -0600, alan somers wrote: > > The existing Rust bindings for nbdkit aren't very idiomatic Rust, and they > > are missing a lot of features. So I've rewritten them. The new bindings > > aren't backwards compatible, but I doubt that's a problem. Most

I fixed this patch based on comments. I merged all commits to a single commit. I'll send this final patch to this list. Regards, Hiroyuki 2019年7月8日(月) 19:36 Martin Kletzander <mkletzan@redhat.com>: > On Mon, Jul 08, 2019 at 10:04:57AM +0100, Richard W.M. Jones wrote: > >On Mon, Jul 08, 2019 at 10:49:55AM +0200, Martin Kletzander wrote: > >> On Mon, Jul 08, 2019 at

This patch includes: - Event callback handlers - Tests related to events(410-430) src/bin/event.rs and src/bin/event_leak.rs are the PoCs that Boxes related to callbacks are not leaked. --- rust/src/bin/.gitkeep | 0 rust/src/bin/event.rs | 29 ++++++ rust/src/bin/event_leak.rs | 30 ++++++ rust/src/error.rs | 6 ++ rust/src/event.rs

I found a bug in the bindings, so I fixed it. I'm sorry about sending you the patch many times. Regards, Hiroyuki 2019年7月20日(土) 16:23 Hiroyuki Katsura <hiroyuki.katsura.0513@gmail.com>: > From: Hiroyuki_Katsura <hiroyuki.katsura.0513@gmail.com> > > Rust bindings: Add create / close functions > > Rust bindings: Add 4 bindings tests > > Rust bindings: Add

From: Hiroyuki_Katsura <hiroyuki.katsura.0513@gmail.com> This patch includes Actions and their tests. Missing: - Events - Examples Rust bindings: Add create / close functions Rust bindings: Add 4 bindings tests Rust bindings: Add generator of structs Rust bindings: Add generator of structs for optional arguments Rust bindings: Add generator of function signatures Rust bindings:

Hi Hiroyuki, On Tuesday, 30 July 2019 07:51:37 CEST Hiroyuki Katsura wrote: > This patch includes: > > - Event callback handlers > - Tests related to events(410-430) > --- Would it be possible to split the Handle -> Handle<'a> change in an own small patch? This way it can be documented why it was changed. > +pub fn event_to_string(events: &[guestfs::Event])

On Mon, Jun 15, 2020 at 08:11:47AM -0600, alan somers wrote: > On Mon, Jun 15, 2020 at 8:04 AM Daniel P. Berrangé <berrange@redhat.com> > wrote: > > > On Mon, Jun 15, 2020 at 02:22:32PM +0100, Richard W.M. Jones wrote: > > > On Thu, Jun 11, 2020 at 04:19:08PM -0600, alan somers wrote: > > > > The existing Rust bindings for nbdkit aren't very idiomatic