similar to: [libnbd PATCH] pread_structured: Change callback type to use Mutable error

A Closure is a list of (usually one, but can be more) closures. In C there is also a singe ‘void *user_data’ parameter which is passed by the caller into the function and through as the first parameter of each callback invocation. By grouping the previously separate Opaque and Callback* parameters together we can avoid the awkward situation where we have to scan through the argument list to try

This is a bitmask so using an unsigned type is slightly safer. This is not an ABI change since the types are compatible. Thanks: Eric Blake. --- examples/strict-structured-reads.c | 2 +- generator/generator | 67 ++++++++++++++++-------------- interop/structured-read.c | 2 +- lib/internal.h | 2 +- tests/oldstyle.c | 2 +- 5

Previously closures had a crude flag which tells if they are persistent or transient. Transient closures (flag = false) last for the lifetime of the currently called libnbd function. Persistent closures had an indefinite lifetime which could last for as long as the handle. In language bindings handling persistent closures was wasteful as we needed to register a "close callback" to

Previously closures had a crude flag which tells if they are persistent or transient. Transient closures (flag = false) last for the lifetime of the currently called libnbd function. Persistent closures had an indefinite lifetime which could last for as long as the handle. In language bindings handling persistent closures was wasteful as we needed to register a "close callback" to

Previously closures had a crude flag which tells if they are persistent or transient. Transient closures (flag = false) last for the lifetime of the currently called libnbd function. Persistent closures had an indefinite lifetime which could last for as long as the handle. In language bindings handling persistent closures was wasteful as we needed to register a "close callback" to

Now that we have a way to pass Mutable(Int "error") to callbacks, that's a much nicer way for language bindings to use than relying on the value of errno after returning -1. Update the semantics for block status to match what pread_structured does, getting errno out of the equation, and changing things to call the callback for a second context even after an earlier callback failure

The freeing feature can now be done by associating a free callback with a closure's user_data, so having the valid_flag is no longer necessary and it can be completely removed. This mostly reverts commit 2d9b98e96772e282d51dafac07f16387dadc8afa. --- TODO | 2 - docs/libnbd.pod | 64 ++-------------- examples/glib-main-loop.c |

Since v1: - rebase to applied patches - split out support for Int in callbacks - sort of test that callbacks work in OCaml (see comment in patch 5) - rename API to nbd_pread_structured - expose error as explicit parameter to callback Eric Blake (5): generator: Allow Int in callbacks states: Wire in a read callback states: Add nbd_pread_structured API states: Add tests for

Change the way that we deal with freeing closures in language bindings: * The valid_flag is removed (mostly reverting commit 2d9b98e96772e282d51dafac07f16387dadc8afa). * An extra ‘free’ parameter is added to all callback structures. This is called by the library whenever the closure won't be called again (so the user_data can be freed). This is analogous to valid_flag ==

Time to wire up user access to react to structured reads as the chunks come in, exposing the framework added in the last patch. I chose to use Int for the callback status rather than an enum for ease of wiring things up to the various language bindings. It's easy to test callback behavior for LIBNBD_READ_DATA/HOLE (the next patch will add interop tests with qemu-nbd), but at present, I

When structured replies are negotiated, the server may advertise support for the DF flag (the server promises to return at most one data/hole chunk, or to fail with NBD_EOVERFLOW if the chunk would be too large). As both nbdkit and qemu-nbd support this flag (the former only trivially, but the latter by not compressing holes over the wire), it is worth exposing to clients, if only for testing

As before, but this one has working Python bindings. OCaml still TBD. Rich.

On 7/16/19 6:04 AM, Richard W.M. Jones wrote: > A Closure is a list of (usually one, but can be more) closures. In C > there is also a singe ‘void *user_data’ parameter which is passed by > the caller into the function and through as the first parameter of > each callback invocation. > > By grouping the previously separate Opaque and Callback* parameters > together we can

Hello All, I just discovered that the last I unfortunately I send only to Louis - not the list. So below are my answers included (and log outputs that were requested). Never the less in meantime I have investigated further into SAMBA & winbind. I was able to setup samba dc based on previous instructions and guidelines successfully. I additionally setup a debian samba member with winbind.

> > Hi > > > > > > I have multi domain environment with root domain and subdomain. > > Forest and domain level windows 2003 native. > > > Also forest prep and domain prep did for sccm 2007 ocs 2007 and > > Exchange 2003. > > > > > > After join Samba to domain like ad dc I had some problem with > > replication: > >

This patch fixes IO deadlocks in the vtpm hotplug scripts. Signed off by: Matthew Fioravante matthew.fioravante@jhuapl.edu --- Changed since previous: * rebased off of latest xen stable * replaced instances of gawk with awk diff --git a/tools/hotplug/Linux/vtpm b/tools/hotplug/Linux/vtpm --- a/tools/hotplug/Linux/vtpm +++ b/tools/hotplug/Linux/vtpm @@ -1,22 +1,18 @@ #!/bin/bash +export

Demonstrate a use of the new nbd_pread_structured_verify API by writing a strict validation that a server's structured replies comply with the specification (well, 99% strict, as I did not check that the server does not return an error at the same offset twice). I was able to test that qemu-nbd is compliant. An example run: $ qemu-img create -f qcow2 file 32m $ for i in `seq 32`; do

Hi I have multi domain environment with root domain and subdomain. Forest and domain level windows 2003 native. Also forest prep and domain prep did for sccm 2007 ocs 2007 and Exchange 2003. After join Samba to domain like ad dc I had some problem with replication: ################################################# [root at dc03 ~]# samba-tool drs replicate dc02 dc03

We?ve been seeing this a lot lately on generic CentOS 6 rpm installs: rpm -qa | grep libguestfs libguestfs-java-1.16.19-1.el6.x86_64 libguestfs-java-devel-1.16.19-1.el6.x86_64 libguestfs-1.16.19-1.el6.x86_64 libguestfs-tools-1.16.19-1.el6.x86_64 libguestfs-javadoc-1.16.19-1.el6.x86_64 libguestfs-devel-1.16.19-1.el6.x86_64 libguestfs-tools-c-1.16.19-1.el6.x86_64

Another simple internal macro, this time encapsulating calling a callback. --- generator/states-reply-simple.c | 8 ++++---- generator/states-reply-structured.c | 31 ++++++++++++++--------------- generator/states-reply.c | 2 +- generator/states.c | 2 +- lib/debug.c | 2 +- lib/internal.h | 4 ++++ 6 files