similar to: [RFC: nbdkit PATCH] cleanup: Assert mutex sanity

The CLEANUP_FREE macro and friends can be useful to filters and in-tree plugins; as such, move them to common/ so more than just the server/ code can take advantage of our compiler magic. Signed-off-by: Eric Blake <eblake@redhat.com> --- common/utils/cleanup.h | 48 ++++++++++++++++++++++++++++++ server/internal.h | 12 +------- {server =>

There's more that can be done (in particular, use of CLEANUP_FREE), but this is enough to at least see if I'm on the right track. I couldn't figure out an obvious difference between common/include and common/utils, but it looks like the former is for things that are inlineable via .h only, while the latter is when you need to link in a convenience library, so this landed in the

Provides automatic cleanup of ‘struct nbdkit_extents_map *’ on exit from a scope or function. --- server/internal.h | 2 ++ server/cleanup.c | 8 +++++++- server/Makefile.am | 3 ++- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/server/internal.h b/server/internal.h index d0da213..825dd3e 100644 --- a/server/internal.h +++ b/server/internal.h @@ -139,6 +139,8 @@ extern void

This automatically frees an argv-style list of strings, such as a copy of environ. --- common/utils/cleanup.h | 3 +++ common/utils/cleanup.c | 13 +++++++++++++ 2 files changed, 16 insertions(+) diff --git a/common/utils/cleanup.h b/common/utils/cleanup.h index 7070290d..14ffc7ff 100644 --- a/common/utils/cleanup.h +++ b/common/utils/cleanup.h @@ -40,6 +40,9 @@ extern void cleanup_free (void

I've posted some of these patches or ideas before; but now I'm confident enough with the series that it should be ready to push; at any rate, I can now run test-socket-activation in a tight loop without triggering any crashes or hangs. With this in place, I'm going back to work on making the nbd forwarder wort with the parallel thread model. Eric Blake (8): sockets: Use

On Mon, Jun 9, 2014 at 1:21 PM, David Chisnall <David.Chisnall at cl.cam.ac.uk> wrote: > On 9 Jun 2014, at 10:19, Kostya Serebryany <kcc at google.com> wrote: > > > tsan's deadlock detector (as well as helgrind and many other similar > tools) detects lock order inversion, i.e. a situation which may potentially > lead to a deadlock. > > Yes, that's what

It was brought to my attention that dumping a registry hive causes a lot of time spent in disk I/O activity because iconv_open() and iconv_close() are called for every key. Every iconv_open() call causes /usr/lib/.../gconv/$ENCODING.so to be opened and mapped. The iconv_t handles are now cached in the hive_h struct; they are opened on-demand and re-used. On my ~10 year old Lenovo T60, I have

On Fri, Feb 09, 2018 at 01:52:52AM +0100, Hilko Bengen wrote: > It was brought to my attention that dumping a registry hive causes a > lot of time spent in disk I/O activity because iconv_open() and > iconv_close() are called for every key. Every iconv_open() call causes > /usr/lib/.../gconv/$ENCODING.so to be opened and mapped. > > The iconv_t handles are now cached in the

I do have a question about whether patch 2 is right, or whether I've exposed a bigger problem in the truncate (and possibly other) filter, but the rest seem fairly straightforward. Eric Blake (4): server: Check for pthread lock failures truncate: Factor out reading real_size under mutex plugins: Check for mutex failures filters: Check for mutex failures filters/cache/cache.c

This was a rather longer trip around the houses than I anticipated! The basic purpose of the patch series is to set $nbdkit_stdio_safe to "0" or "1" in sh and eval plugin scripts. To do that, I ended up adding a nicer way to manipulate environ lists, and to do that, I ended up adding a whole generic vector implementation which is applicable in a lot of different places.

On Thu, May 16, 2019 at 06:27:45PM +0200, Thomas Zimmermann wrote: > The new interfaces drm_gem_vram_{pin/unpin}_reserved() are variants of the > GEM VRAM pin/unpin functions that do not reserve the BO during validation. > The mgag200 driver requires this behavior for its cursor handling. The > patch also converts the driver to use the new interfaces. > > Signed-off-by: Thomas

On Thu, May 16, 2019 at 06:27:45PM +0200, Thomas Zimmermann wrote: > The new interfaces drm_gem_vram_{pin/unpin}_reserved() are variants of the > GEM VRAM pin/unpin functions that do not reserve the BO during validation. > The mgag200 driver requires this behavior for its cursor handling. The > patch also converts the driver to use the new interfaces. > > Signed-off-by: Thomas

Not sure what version we're up to, but this reimplements extents using the new simpler structure described in this thread: https://www.redhat.com/archives/libguestfs/2019-March/msg00077.html I also fixed most of the things that Eric pointed out in the previous review, although I need to go back over his replies and check I've got everything. This needs a bit more testing. However the

All - desperate plea for help here. Overview Centos 4.5 Kernel 2.6.9.55.0.9.EL with source dell Latitude 810 Im totally at my wits end... Ive tried like mad to get ndiswrapper to work for my lynksys WPC54GS wireless card. No matter what I try ndis gives some kind of error on installing the module after about a dozen attempts 8 kernels, and 5 days- I finally GAVE UP! unreal So, I

Hi all, The code that I checked in yesterday that seemed to work just fine now fails. When I run this: require "win32/file" fh = File.nopen("C:\\test.txt") fh.close I now get: test.rb:12:in `initialize'': Invalid argument (Errno::EINVAL) from test.rb:12:in `nopen'' Specifically, it''s failing on this in file.c: args[0] =

Hi all, Windows 2000 VC++ 6 Well, it turns out I''m not insane. The rb_class_new_instance() chokes with RC9. However, when I rolled back to RC7, it worked fine. So, either something is broken in RC9 or this is some sort of VC6 vs VC7 issue. Can anyone else confirm? Regards, Dan

Hi all I''m just getting started with script.aculo.us, and prototype etc. My first mini-project was to use Draggable to adjust the column widths in a page. Here''s the code (which seems to work) and any feedback would be appreciated - especially if I''m doing things the wrong way. Here''s the code: var colSpacer function initPage() { colSpacer = new

Hi, The sanity check which refuses write access to disks configured read-only is at the wrong place. This patch fixes it. please apply, Gerd _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel

Hi all, in a somewhat unrelated discussion, a user wanted to run gpg in an initramfs generated by the Debian initramfs-tools package. Whether that is a good idea or not is a different discussion, but he noted that /dev/tty won't work in the initramfs because no controlling console has been setup yet (I think init is the first program to do so). So, I was wondering if it might be a good idea

Having briefly fallen for the notion that the negative.binomial family in MASS could be used in glmer, I want to use these lists for a sanity check on my final (?) plans. I want to use glmer for logistic regression and for poisson regression on a data set of 10,000 items. There will be two crossed random effects. For the logistic regression, I want odds ratios with confidence intervals.For the