similar to: Plan for nbdkit 1.12

I’m pleased to announce the next stable release of nbdkit. This release concentrates on numerous feature enhancements - see the release notes below. NBD — Network Block Device — is a protocol for accessing Block Devices (hard disks and disk-like things) over a Network. nbdkit is a toolkit for creating NBD servers. The key features are: * Multithreaded NBD server written in C with good

On Thu, Mar 28, 2019 at 10:44:42PM -0500, Eric Blake wrote: > The DF flag is only available to clients that negotiated structured > replies, and even then, the spec does not require that it be > implemented. However, since our current implementation can't fragment > NBD_CMD_READ replies, we trivially implement the flag (by ignoring > it); we don't even have to pass it on to

Qemu was able to demonstrate that knowing whether a zero operation is fast is useful when copying from one image to another: there is a choice between bulk pre-zeroing and then revisiting the data sections (fewer transactions, but depends on the zeroing to be fast), vs. visiting every portion of the disk only once (more transactions, but no time lost to duplicated I/O due to slow zeroes). As

On Fri, Mar 29, 2019 at 12:43:33PM +0000, Richard W.M. Jones wrote: >On Thu, Mar 28, 2019 at 10:44:42PM -0500, Eric Blake wrote: >> The DF flag is only available to clients that negotiated structured >> replies, and even then, the spec does not require that it be >> implemented. However, since our current implementation can't fragment >> NBD_CMD_READ replies, we

Eventually nbdkit will install this as a public header file and we will be able to consume it from $includedir. In the mean time synchronize with the copy in nbdkit. --- lib/nbd-protocol.h | 57 +++++++++++++++++++++++----------------------- 1 file changed, 28 insertions(+), 29 deletions(-) diff --git a/lib/nbd-protocol.h b/lib/nbd-protocol.h index 699aa22..7df411a 100644 ---

The DF flag is only available to clients that negotiated structured replies, and even then, the spec does not require that it be implemented. However, since our current implementation can't fragment NBD_CMD_READ replies, we trivially implement the flag (by ignoring it); we don't even have to pass it on to the plugins. Enhance some documentation about sparse reads while at it (when we

On 9/24/19 4:07 PM, Richard W.M. Jones wrote: > Eventually nbdkit will install this as a public header file and we > will be able to consume it from $includedir. In the mean time > synchronize with the copy in nbdkit. > --- > lib/nbd-protocol.h | 57 +++++++++++++++++++++++----------------------- > 1 file changed, 28 insertions(+), 29 deletions(-) > > /* Newstyle

On 3/18/19 11:59 AM, Richard W.M. Jones wrote: > This is a cheap way to find some use-after-free and uninitialized read > problems when using glibc. > > This in fact reveals a race during filter shutdown (which this > commit does not fix): > > Thread 2 (Thread 0x7f1caaa5ffc0 (LWP 7223)): > #0 0x00007f1cab0a05f8 in pthread_rwlock_wrlock () from /lib64/libpthread.so.0

This is a cheap way to find some use-after-free and uninitialized read problems when using glibc. This in fact reveals a race during filter shutdown (which this commit does not fix): Thread 2 (Thread 0x7f1caaa5ffc0 (LWP 7223)): #0 0x00007f1cab0a05f8 in pthread_rwlock_wrlock () from /lib64/libpthread.so.0 #1 0x0000000000408842 in lock_unload () at locks.c:97 #2 0x00000000004066ff in

This commit implements the core NBD protocol for the "base:allocation" Block Status replies. --- server/internal.h | 7 ++ server/protocol.h | 15 +++ server/protocol-handshake-newstyle.c | 81 ++++++++++++++- server/protocol.c | 141 ++++++++++++++++++++++++--- 4 files changed, 229 insertions(+), 15 deletions(-) diff --git

This commit implements the core NBD protocol for the "base:allocation" Block Status replies. --- server/internal.h | 7 + server/protocol.h | 17 +- server/protocol-handshake-newstyle.c | 79 ++++++++- server/protocol.c | 248 +++++++++++++++++++++++++-- 4 files changed, 335 insertions(+), 16 deletions(-) diff --git

On Fri, Mar 08, 2019 at 09:03:05AM -0600, Eric Blake wrote: > On 3/8/19 4:04 AM, Richard W.M. Jones wrote: > > Also we do not understand NBD_CMD_FLAG_DF, but that seems to be OK > > because (a) we don't advertize the feature and (b) we only send back a > > single chunk anyway. > > Or, we COULD advertise it because we always honor it (but that's a > larger

From: "Richard W.M. Jones" <rjones@redhat.com> This plugin allows you to create a complete ext2, ext3 or ext4 filesystem in a GPT partitioned disk image. This can be attached as a disk to a Linux virtual machine. It is implemented using e2fsprogs mke2fs ‘-d’ option thus allowing the implementation to be very small and simple, with all the hard work done by mke2fs. Although

On 3/11/19 2:44 PM, Richard W.M. Jones wrote: > On Fri, Mar 08, 2019 at 10:50:35AM -0600, Eric Blake wrote: >>> int extents (void *handle, uint32_t count, uint64_t offset, >>> uint32_t flags /* always 0? */, >> >> Unless we support the REQ_ONE flag (where the client specifically wants >> only one extent returned). > ... >>> nbdkit

From: "Richard W.M. Jones" <rjones@redhat.com> This plugin allows you to create a complete ext2 filesystem in a GPT partitioned disk image. This can be attached as a disk to a Linux virtual machine. It is implemented using libext2fs (the same as supermin). Although there is some overlap with nbdkit-iso-plugin and nbdkit-floppy-plugin, the implementations and use cases of all

On Tue, Mar 12, 2019 at 09:04:59AM +0100, Martin Kletzander wrote: > On Mon, Mar 11, 2019 at 02:53:55PM -0500, Eric Blake wrote: > >On 3/11/19 2:44 PM, Richard W.M. Jones wrote: > >>On Fri, Mar 08, 2019 at 10:50:35AM -0600, Eric Blake wrote: > >>>> int extents (void *handle, uint32_t count, uint64_t offset, > >>>> uint32_t flags /*

On Fri, Mar 08, 2019 at 10:50:35AM -0600, Eric Blake wrote: > > int extents (void *handle, uint32_t count, uint64_t offset, > > uint32_t flags /* always 0? */, > > Unless we support the REQ_ONE flag (where the client specifically wants > only one extent returned). ... > > nbdkit would need to do some massaging on this to get it into the > > right

When I was reviewing this I forgot the slightly ridiculous rules that autoconf uses for --enable/disable vs --with/without: https://www.gnu.org/software/autoconf/manual/autoconf-2.66/html_node/Package-Options.html https://www.gnu.org/software/autoconf/manual/autoconf-2.66/html_node/External-Software.html Since this is disabling an intrinsic feature of the software (a plugin) it should use

From: Alan Somers <asomers@gmail.com> This can be used to disable the linuxdisk plugin, which otherwise is always built if a suitable mke2fs command is present. --- configure.ac | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index f24c3734..c93e822b 100644 --- a/configure.ac +++ b/configure.ac @@ -483,18 +483,25 @@

This can be used for creating temporary disks to thin clients, as a kind of "remote tmpfs". See also: https://www.redhat.com/archives/libguestfs/2020-March/msg00134.html --- plugins/data/nbdkit-data-plugin.pod | 1 + plugins/file/nbdkit-file-plugin.pod | 1 + plugins/linuxdisk/nbdkit-linuxdisk-plugin.pod | 7 +- plugins/memory/nbdkit-memory-plugin.pod |