similar to: [supermin PATCH] rebuild the output it when SUPERMIN_KERNEL or SUPERMIN_MODULES are defined

On Monday, 4 March 2019 12:18:58 CET Masayoshi Mizuma wrote: > SUPERMIN_KERNEL and SUPERMIN_MODULES don't work to guestfish. > > Since guestfish sets --if-newer parameter to supermin, so the environment > variables are not used under the following conditions. > - the output directory exists and, > - the dates of both input files and package database are > older

In case we need to check whether the appliance must be rebuilt, check also the timestamp of the outputs of the mode, i.e. the kernel, initrd, and root files. This way, when either of these files does not exist or is older than the package manager DB we can rebuild the appliance. Add a simple test to verify this behaviour. --- src/mode_build.ml | 12 ++++++++ src/mode_build.mli

Add a function for each mode to return the list of potential outputs, so that the existance/timestamp checks done for --if-newer can take those into accounts. At the moment both modes return no outputs, so there is no behaviour change. --- src/mode_build.ml | 7 +++++++ src/mode_build.mli | 4 ++++ src/mode_prepare.ml | 9 ++++++++- src/mode_prepare.mli | 4 ++++ src/supermin.ml | 9

On Fri, Apr 03, 2020 at 12:20:57PM +0200, Pino Toscano wrote: > Add a function for each mode to return the list of potential outputs, so > that the existance/timestamp checks done for --if-newer can take those > into accounts. > > At the moment both modes return no outputs, so there is no behaviour > change. Patches 1, 2 and 4 are fine. I have a minor problem with this patch:

This is an attempt to make supermin check for the existing results of an output when checking whether the appliance must be rebuilt using --if-newer. At the moment it is implemented only for the build mode, and for its ext2 output format. Pino Toscano (4): build: factor ext2 filenames Tighten Unix_error check for missing outputdir Extend modes with list of outputs build: set

This is an attempt to make supermin check for the existing results of an output when checking whether the appliance must be rebuilt using --if-newer. At the moment it is implemented only for the ext2 output format of the build mode. Changes from v1: - drop empty stub for the prepare mode - add patch to ignore --if-newer on modes different than build - squash patch with stub for the build mode

--- test-tool/libguestfs-test-tool.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test-tool/libguestfs-test-tool.pod b/test-tool/libguestfs-test-tool.pod index c4284684f8c4ca3dfba0cb734d9cc46f0330b5b9..8999286848d79225c43c8fead674b998be93d4b3 100644 --- a/test-tool/libguestfs-test-tool.pod +++ b/test-tool/libguestfs-test-tool.pod @@ -87,7 +87,7 @@ variables

On Wed, Jun 04, 2014 at 01:18:47PM +0530, abhishek jain wrote: > Hi RIch > > Below are the necessary details of the system.. > > > *ls -l /boot/total 10200-rw-r--r-- 1 root root 5224765 Nov 22 2013 > uImage-rw-r--r-- 1 root root 5192861 Nov 22 2013 uImage.origls -l > /lib/modules/total 4drwxr-xr-x 3 ubuntu ubuntu 4096 Jun 3 07:21 > 3.8.13-rt9-QorIQ-SDK-V1.4uname

On Wed, Jun 04, 2014 at 02:25:58PM +0530, abhishek jain wrote: > Hi RIch > > > Below are the details of the powerpc ubuntu system ... > > ls -l /boot/ > total 10200 > -rw-r--r-- 1 root root 5224765 Nov 22 2013 uImage > -rw-r--r-- 1 root root 5192861 Nov 22 2013 uImage.orig > > > ls -l /lib/modules/ > total 4 > drwxr-xr-x 3 ubuntu ubuntu 4096 Jun 3

On Wed, Jun 04, 2014 at 03:29:11PM +0530, abhishek jain wrote: > supermin: kernel: SUPERMIN_KERNEL environment variable /boot/uImage > supermin: failed to find a suitable kernel (host_cpu=powerpc64). > > I looked for kernels in /boot and modules in /lib/modules. If you follow the code in src/kernel.ml you'll see that this means supermin was unable to get the kernel version from

Hi Rich Kindly ignore my previos mail. I have downloaded the latest version of supermin supermin-5.1.8 and have compiled it for powerpc.Moreover there was no need to patch the src/ kernel.ml file as the changes were already implemented on the latest version. But still when i run libguestfs-test-tool on powerpc ubuntu,I get the below logs.. libguestfs-test-tool

Hi Rich But there is no src/kernel.ml file on my ubuntu powerpc to which the above patch is reffering. I have installed supermin as supermin_5.1.8-2_powerpc.deb debian package. Thanks On Tue, Jun 3, 2014 at 7:16 PM, Richard W.M. Jones <rjones@redhat.com> wrote: > On Tue, Jun 03, 2014 at 06:55:49PM +0530, abhishek jain wrote: > > supermin: failed to find a suitable kernel

This patch series fixes several problems in the way that supermin handles kernels. The most pressing problem is that supermin doesn't handle bogus vmlinuz files which aren't actual kernels. Along the way there is a lot of clean up. The patches look much better if you view them with ‘-w’. This series will require plenty of time to be tested in Fedora, especially on non-x86 arches.

Hello, I am running into problems with virt-builder on my Ubuntu-14.04 install. Please find the checklist below: 1. What are you trying to achieve? I'm trying to build a standard Ubuntu 14.04 disk image. 2. What exact commands did you run? I ran "virt-builder ubuntu-14.04" 3. What was the precise error/output of these commands? The process gets stuck indefinitely at

Hi, Rich: I met a supermin issue on CentOS 7.1: supermin: version: 5.1.10 supermin: rpm: detected RPM version 4.11 supermin: package handler: fedora/rpm supermin: acquiring lock on /root/test/aaa/lock supermin: build: /usr/lib64/guestfs/supermin.d supermin: build: visiting /usr/lib64/guestfs/supermin.d/base.tar.gz type gzip base image (tar) supermin: build: visiting

Have finally managed to come up with a fix after checking out sys.calls() from within the as.Date.IDate debugger, which shows something like: [[1]] rbind(DF, DF) [[2]] rbind(deparse.level, ...) [[3]] `[<-`(`*tmp*`, ri, value = 18042L) [[4]] `[<-.Date`(`*tmp*`, ri, value = 18042L) [[5]] as.Date(value) [[6]] as.Date.IDate(value) I'm not sure why [<- is called, I guess the

Hi, few cleanups in the supermin codebase; no actual functional change. Thanks, -- Pino Toscano (3): ext2: simplify tracking of visited modules utils: remove unused run_python function Add and use an helper error function src/build.ml | 20 +++++----------- src/dpkg.ml | 4 +--- src/ext2_initrd.ml | 10 ++++---- src/kernel.ml | 27

On Sun, May 26, 2019 at 6:47 AM Joshua Ulrich <josh.m.ulrich at gmail.com> wrote: > > On Sun, May 26, 2019 at 4:06 AM Michael Chirico > <michaelchirico4 at gmail.com> wrote: > > > > Have finally managed to come up with a fix after checking out sys.calls() > > from within the as.Date.IDate debugger, which shows something like: > > > > [[1]]

Follow-up (inline) on my comment about a potential issue in `[<-.Date`. On Mon, May 27, 2019 at 9:31 AM Michael Chirico <michaelchirico4 at gmail.com> wrote: > > Yes, thanks for following up on thread here. And thanks again for clearing things up, your email was a finger snap of clarity on the whole issue. > > I'll add that actually it was data.table's code at fault

I thought it would be good to summarize my thoughts, since I made a few hypotheses that turned out to be false. This isn't a bug in base R, in either rbind() or `[<-.Date`. To summarize the root cause: base::rbind.data.frame() calls `[<-` for each column of the data.frame, and there is no `[<-.IDate` method to ensure the replacement value is converted to integer. And, in fact,