similar to: [nbdkit PATCH] maint: Adjust cleaning rules

A bit of refactoring to the HAVE_LIBGUESTFS conditional, coupled with the addition of a LIBGUESTFS_TESTS intermediate list, allows us to run a few more tests on CentOS 6 (adding some tests of command-line behavior and filters that was previously completely skipped). For the two tests that we can't run, using check_PROGRAMS still causes those programs to try to compile (which leads to compile

See commit 2a29634aa0589037b5625032097a3a2f7b1d5c7d and https://www.redhat.com/archives/libguestfs/2019-September/msg00366.html --- configure.ac | 4 +- plugins/data/nbdkit-data-plugin.pod | 2 +- plugins/{reflection => info}/Makefile.am | 20 ++++----- .../{reflection/reflection.c => info/info.c} | 42 +++++++++----------

On Thu, Dec 13, 2018 at 08:55:41AM -0600, Eric Blake wrote: > diff --git a/tests/Makefile.am b/tests/Makefile.am > index 4c7b59c..55db593 100644 > --- a/tests/Makefile.am > +++ b/tests/Makefile.am > @@ -32,7 +32,8 @@ > > include $(top_srcdir)/common-rules.mk > > -MAINTAINERCLEANFILES = > +CLEANFILES = Because common-rules.mk defines CLEANFILES, this should be

The source for the easter egg example is not included, but it is: org 0x7c00 ; clear screen mov ah,0 mov al,3 int 0x10 ; print string mov ah,0x13 mov bl,0xa mov al,1 mov cx,len mov dh,0 mov dl,0 mov bp,hello int 0x10 hlt hello: db "*** Hello from nbdkit! ***",0xd,0xa

The ocaml.opt compiler defaults to building things in the same directory as its input; we need explicit -o options to build in a VPATH $(builddir) when $(srcdir) is read-only (as is the case during 'make distcheck'). We also have to build any side effect files explicitly in cases where we can't directly use -o to control those outputs alongside the final product. Thanks: Richard W.M.

We do not promise API stability for non-C languages; this is an API break as follows: instead of calling 'NBDKit.register_plugin model plugin' with a static model, you can now add .thread_model :(unit -> thread_model) to plugin or default to PARALLEL. Since all existing OCaml plugins will have already thought about thread models, they can convert their existing model into the new

CentOS 6 has libguestfs-devel 1.20.11, which predates the support in guestfs_add_drive_opts() for requesting an nbd drive instead of a local file (annoyingly, guestfs documentation merely states the function was available since 0.3, without saying which later releases added new options); causing a compilation failure during 'make check'. Maybe the guestfs plugin should still be built,

When using ext2file=exportname to pick the file to server from the client's export name, we do not want to leak the underlying plugin's export list. While touching this, take advantage of string lifetimes via nbdkit_strdup_intern and similar for less cleanup bookkeeping. Note that we don't actually implement a full .list_exports; doing that with NBD_OPT_LIST is likely prohibitive

To make Btrfs code more robust, several return value checks where memory allocation can fail are introduced. I use BUG_ON where I don''t know how to handle the error properly, which increases the number of using the notorious BUG_ON, though. Signed-off-by: Yoshinori Sano <yoshinori.sano@gmail.com> --- fs/btrfs/compression.c | 6 ++++++ fs/btrfs/extent-tree.c | 2 ++

On 4/23/19 10:09 AM, Richard W.M. Jones wrote: > In the C part of the OCaml plugin we created a ‘bytes’ [byte array] > and passed it to the OCaml pread method. The plugin is supposed to > overwrite the array with the returned data. > > However if (eg. because of a bug) the plugin does not fill the array > then whatever was in the OCaml or possibly even the C heap before the

In the C part of the OCaml plugin we created a ‘bytes’ [byte array] and passed it to the OCaml pread method. The plugin is supposed to overwrite the array with the returned data. However if (eg. because of a bug) the plugin does not fill the array then whatever was in the OCaml or possibly even the C heap before the allocation is returned to the client, possibly resulting in a leak of sensitive

Hi all, I wonder whether, for an anova with multiple error strata, it is possible to produce the same diagnostoc plots than with a single-stratum anova. I can extract the residuals for each stratum with e.g. > resid(split1.aov[["block:plot"]]) > resid(split1.aov[["Within"]]) and then produce qqnorm plots etc manually, but is it possible to get all the plots

Hi all, I'd like to extract a value from an ANOVA table, but experience the following problem: ### This works: > s.pseudo <- summary(aov(m ~ block + mix*graz,data=split1)) > s.pseudo Df Sum Sq Mean Sq F value Pr(>F) block 2 1114.66 557.33 4.4296 0.04192 * mix 1 6.14 6.14 0.0488 0.82956 graz 2 1.45 0.72 0.0057 0.99427 mix:graz

Version 1 was here: https://www.redhat.com/archives/libguestfs/2019-April/msg00144.html Version 2 makes a couple of much larger changes: The OCaml patch changes the API of the pread method so it matches what other language bindings are already doing, ie. get the language plugin to return a newly allocated buffer, check it is long enough, copy out the data. The server patch implements a

Borrows heavily from the existing test-truncate-extents.sh (basically, adding another layer of nbdkit to prove that the nbd plugin doesn't change anything from what the truncate filter is already tested to do). Signed-off-by: Eric Blake <eblake@redhat.com> --- tests/Makefile.am | 3 + tests/test-nbd-extents.sh | 113 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 116

Hi, Are there any effort in making wxDocument, wxView, etc types of classes avaiable under wxRuby? For supporting SDI/MDI architecture. Cheers, Phuah Yee Keat

Make the tests 'check_DATA' so they only get built when running the tests. This saves a couple of seconds on the build time. --- ocaml/Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am index e781363..a535b43 100644 --- a/ocaml/Makefile.am +++ b/ocaml/Makefile.am @@ -142,9 +142,9 @@ endif TESTS = run-bindtests

--- tests/Makefile.am | 3 ++ tests/test-export-name.sh | 86 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 89 insertions(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index b5806bb..f54597b 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -395,6 +395,9 @@ endif HAVE_LIBGUESTFS # Test export flags. TESTS += test-eflags.sh +# Test export name. +TESTS +=

On 7/10/20 6:50 AM, Richard W.M. Jones wrote: > Turn the existing nbdkit-gzip-plugin into a filter so it can be > applied on top of files or other sources: > > nbdkit file --filter=gzip file.gz > nbdkit curl --filter=gzip https://example.com/disk.gz > > Because of the nature of the gzip format which is not blocked based > and thus not seekable, this filter caches

This borrows from a trick in libvirt - by defining $(NULL) to expand to an empty string, we can more consistently write multi-line macros where all useful lines terminate with \, making it easier to add/remove lines without worrying about whether \ needs to be touched up on neighboring lines. --- Looks big, but is fairly mechanical. I'm also doing a similar patch for nbdkit, where it would