similar to: [PATCH nbdkit 0/4] Multiple valgrind improvements and possible security fix.

On 12/2/18 10:39 AM, Richard W.M. Jones wrote: > By default valgrind suppresses many leaks. I'm not even sure exactly > how it decides which ones to suppress, but certainly global variables > pointing to malloc’d data are suppressed, which is not useful > behaviour. Here's my understanding of why that is the default - if you assign malloc()d storage into a global, then that

This patch series solves the FreeBSD shebang problem in a completely different way, and a few other things besides. I propose that we replace ./nbdkit with a C program. The C program is a straightforward translation of the shell script. Some advantages of this approach are: - We can parse options in exactly the same way as the real program. - Use the more accurate ‘is_short_name’ test for

v1 was here: https://www.redhat.com/archives/libguestfs/2018-November/msg00147.html v2 was here: https://www.redhat.com/archives/libguestfs/2018-November/msg00152.html v3: - Use optarg != NULL as a sentinel for has_arg. - Moved some variable decls into the inner loop. - Make nbdkit wrapper depend on config.status, so if srcdir or builddir changes then we rebuild the wrapper. It

v1 was here: https://www.redhat.com/archives/libguestfs/2018-November/msg00147.html v2: - Use stdbool for booleans. - Use __attribute__((format(printf))). - Don't abort on invalid options, exit with failure instead. - Preserve long/short option choices in the output. - Add '=' in long option output, ie. always use --longopt=arg. - Add "--" parameter

On 12/3/18 1:01 PM, Richard W.M. Jones wrote: > >>> passthru ("--error-exitcode=119"); >>> - passthru_format ("--suppressions=%s/valgrind-suppressions", srcdir); >>> + passthru_format ("--suppressions=%s/valgrind/suppressions", builddir); >> >> Is this still right under VPATH? > > I believe so ...? Note

Memory leak found by valgrind. --- p2v/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/p2v/main.c b/p2v/main.c index e1a7550..7f1e1c0 100644 --- a/p2v/main.c +++ b/p2v/main.c @@ -260,6 +260,7 @@ main (int argc, char *argv[]) } guestfs_int_free_string_list (cmdline); + free_config (config); exit (EXIT_SUCCESS); } -- 2.10.2

On 11/13/18 4:51 PM, Richard W.M. Jones wrote: > There are advantages to having the same code parse the options in the > ./nbdkit wrapper as in the real nbdkit: > > - We can parse options in exactly the same way as the real program. > > - Use the more accurate ‘is_short_name’ test for unadorned > plugin/filter names on the command line. > > - Fixes the FreeBSD

I had to add several suppressions because Python leaks memory by design, and also increase the max depth of valgrind stack traces because Python stack traces are very deep. Note that to do proper valgrinding of Python itself we would need to specially recompile Python: https://svn.python.org/projects/python/trunk/Misc/README.valgrind --- tests/test-lang-plugins.c | 3 +-

By default valgrind suppresses many leaks. I'm not even sure exactly how it decides which ones to suppress, but certainly global variables pointing to malloc’d data are suppressed, which is not useful behaviour. Tell valgrind to show all leaks. It won't give an error on them. However to do this we also need a much more comprehensive list of suppressions so that we don't constantly

When we are valgrinding we don't really care about the child processes, which might be qemu, libvirtd, etc. So disable tracing into children (at least, as far as is possible with valgrind, which is not entirely disabling it, but suppressing it). --- m4/guestfs_progs.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/guestfs_progs.m4 b/m4/guestfs_progs.m4 index

Previously posted here: https://www.redhat.com/archives/libguestfs/2015-June/msg00266.html Rich.

Fixes for various issues found while implementing my nbd forwarder plugin. I'm okay if you choose to take some but not others; the most important one is patch 3 which fixes a protocol violation that makes it impossible for a client to try and recover from EIO failures over a partially-flaky source block device. Eric Blake (3): maint: Add emacs hint file maint: Add NBDKIT_GDB support to

See individual patches for details. Pino Toscano (4): Add valgrind suppression file podwrapper: the tools here start with p2v Import some internal documentation podwrapper: adapt footer to p2v .gitignore | 6 + Makefile.am | 4 +- configure.ac | 1 + docs/Makefile.am | 65 ++++++++ docs/p2v-building.pod | 259

In v2: - Kernel command line parsing now moved to the appliance. - In the captive daemon test, the daemon cleanly shuts down on exit. - Add another btrfs test. Rich.

Currently we are unable to properly run guestfsd (the daemon) under valgrind. Attempts to run valgrind inside the appliance have not been successful (see patch 1/7). However we desperately need better valgrind coverage of the daemon, particularly because it is doing a lot of complex parsing of program output. This has been a problem for a long time. A better way to attack this problem is to

Hi all, I'm on Ubuntu 18.04, running R-4.0.0 which I compiled from source, and using valgrind I am always seeing the following message. Does anybody else see that? Is that a known false positive? Any ideas how to fix/suppress? Seems related to TRE, do I need to upgrade that? (base) tdhock at maude-MacBookPro:~/R/binsegRcpp$ R --vanilla -d valgrind -e 'extSoftVersion()' ==9565==

This is a minimal implementation of an NBD forwarder; it lets us convert between old and newstyle connections (great if a client expects one style but the real server only provides the other), or add TLS safety on top of a server without having to rewrite that server. Right now, the real server is expected to live on a named Unix socket, and the transactions are serialized rather than

Valgrind has two ways to control valgrinding into subprocesses, --child-silent-after-fork and --trace-children. --child-silent-after-fork=yes causes tracing to stop when the process forks. However in nbdkit we want to continue tracing nbdkit when it forks itself into the background, so I have removed this option now. --trace-children=no causes tracing to stop when the program calls one of the

Chris, I'm using a llvm_shutdown_obj object and it calls llvm_shutdown when I delete it. Do I need to call llvm_shutdown() again afterwards? It looks to me like the static object is being created after my program exits main(). From: Chris Lattner [mailto:clattner at apple.com] Sent: Friday, January 13, 2012 10:11 AM To: Villmow, Micah Cc: LLVM Developers Mailing List Subject: Re: [LLVMdev]

I think I am using objects according to the man page. This seems to be a valid regular expression. But whether I know what I'm doing or no, it still shouldn't be doing what valgrind seems to be saying it's doing. (IMHO) ---------- start of script ---------- Script started on Mon 01 Aug 2005 02:09:00 PM PDT linux$ printenv VALGRIND_OPTS --tool=3Dmemcheck linux$ cat bar.R foo <- 1