similar to: [nbdkit PATCH] ocaml: Make build VPATH aware

'make distcheck' calls us out for leaving files behind after 'make distclean' that were not present in the tarball. Either these files are expensive enough that end users should not be required to regenerate them (so they should be distributed), or they should be cleaned when a user asks to get back to the pristine tarball state. Automake suggests this hierarchy of cleaning:

Rather than always trying to install ocaml files into $(OCAMLLIBS), which is likely to be root-owned and therefore fail during a './configure --prefix=$HOME/subdir', we instead choose to always install relative to $(prefix) and let distro packagers take steps post-install to move the distro's pre-built copy into the correct location for the distro. This fixes a 'make

Add makefile variables to enable silent rules for simple command invocations, such as ocamlc, ocamlopt, javac, and erlc. This reduces the log output when building with silent rules, still showing the full command lines otherwise. --- erlang/Makefile.am | 2 +- java/Makefile.am | 6 +++--- ocaml/Makefile.am | 14 +++++++------- subdir-rules.mk | 20 +++++++++++++++++--- 4 files changed,

--- builder/Makefile.am | 18 +++++++++++++- configure.ac | 2 ++ mllib/Makefile.am | 60 +++++++++++++++++++++++++++++++--------------- ocaml/Makefile.am | 28 +++++++++++++++------- ocaml/examples/Makefile.am | 13 ++++++++++ resize/Makefile.am | 18 +++++++++++++- sparsify/Makefile.am | 18 +++++++++++++- sysprep/Makefile.am | 18

This is a first attempt to build libguestfs with just a ocaml bytecode compiler. The three tools written in ocaml will be build only when an ocamlopt compiler is available. Olaf --- Makefile.am | 5 ++++- configure.ac | 2 ++ ocaml/Makefile.am | 20 +++++++++++++++++--- resize/Makefile.am | 2 +- sparsify/Makefile.am | 2 +- sysprep/Makefile.am | 2 +- 6

On Fri, Dec 07, 2018 at 03:09:43PM -0600, Eric Blake wrote: > Rather than always trying to install ocaml files into $(OCAMLLIBS), > which is likely to be root-owned and therefore fail during a > './configure --prefix=$HOME/subdir', we instead choose to always > install relative to $(prefix) and let distro packagers take steps > post-install to move the distro's pre-built

I believe this patch has now been superseded by Hilko's commit here: https://github.com/libguestfs/libguestfs/commit/f75142c577255b30f2a8e1d27baa5fd185594197 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#)

On Thu, Jan 17, Richard W.M. Jones wrote: > On Wed, Jan 16, 2013 at 05:51:53PM +0100, Olaf Hering wrote: > > On Mon, Jan 14, Olaf Hering wrote: > > > This is a first attempt to build libguestfs with just a ocaml bytecode > > > compiler. The three tools written in ocaml will be build only when an > > > ocamlopt compiler is available. > > Here is a more

We do not promise API stability for non-C languages; this is an API break as follows: instead of calling 'NBDKit.register_plugin model plugin' with a static model, you can now add .thread_model :(unit -> thread_model) to plugin or default to PARALLEL. Since all existing OCaml plugins will have already thought about thread models, they can convert their existing model into the new

This just fixes 'make'. 'make check' is still broken. Further patches for that to follow tomorrow. Rich.

No change, just refactoring. --- builder/Makefile.am | 2 +- configure.ac | 6 ++++++ customize/Makefile.am | 2 +- generator/Makefile.am | 2 +- mllib/Makefile.am | 2 +- ocaml/Makefile.am | 2 +- resize/Makefile.am | 2 +- sparsify/Makefile.am | 2 +- sysprep/Makefile.am | 2 +- v2v/Makefile.am | 2 +- 10 files changed, 15 insertions(+), 9 deletions(-) diff --git

At the moment OpenStack uses kpartx and nbd to resize filesystems and inject files to guests. I sincerely hope they don't allow untrusted users to upload guest images / AMIs :-( To fix this I'm looking into adding libguestfs support as an optional backend in OpenStack. The only missing feature in libguestfs is the ability to call tune2fs on a filesystem. This patch series adds tune2fs

On Thu, Dec 13, 2018 at 08:55:41AM -0600, Eric Blake wrote: > diff --git a/tests/Makefile.am b/tests/Makefile.am > index 4c7b59c..55db593 100644 > --- a/tests/Makefile.am > +++ b/tests/Makefile.am > @@ -32,7 +32,8 @@ > > include $(top_srcdir)/common-rules.mk > > -MAINTAINERCLEANFILES = > +CLEANFILES = Because common-rules.mk defines CLEANFILES, this should be

On 4/23/19 10:09 AM, Richard W.M. Jones wrote: > In the C part of the OCaml plugin we created a ‘bytes’ [byte array] > and passed it to the OCaml pread method. The plugin is supposed to > overwrite the array with the returned data. > > However if (eg. because of a bug) the plugin does not fill the array > then whatever was in the OCaml or possibly even the C heap before the

In the C part of the OCaml plugin we created a ‘bytes’ [byte array] and passed it to the OCaml pread method. The plugin is supposed to overwrite the array with the returned data. However if (eg. because of a bug) the plugin does not fill the array then whatever was in the OCaml or possibly even the C heap before the allocation is returned to the client, possibly resulting in a leak of sensitive

* Richard W.M. Jones: > Yes, also this commit doesn't actually fix the problem. I still see > occasional problems building StringMap. I have reverted this commit. Here's another patch that should enable the native-code targets only if they can be built. Cheers, -Hilko

Hi: I've been seeing intermittent build failures with the extlinux target, and I believe I've tracked it down to a VPATH issue. See this make -d log: Finished prerequisites of target file `extlinux'. Prerequisite `extlinux.o' is newer than target `extlinux'. Prerequisite `setadv.o' is newer than target `extlinux'. Prerequisite

Hardcoding -ltinfo breaks on distros that do not build the sep library (which is the default ncurses behavior). Use pkg-config to look up the right libraries regardless of how the distro built things. --- builder/Makefile.am | 5 +++-- configure.ac | 18 ++++++------------ customize/Makefile.am | 2 +- mllib/Makefile.am | 6 +++--- resize/Makefile.am | 2 +-

Hello, c/s 17138 introduced the use of VPATH instead of symlinks to access to libelf files. However, that not only provides access to .c files, but also to .o files. That means that if one compiles the hypervisor before the tools, libxenguest.a contains .o files intended to the hypervisor, containing references to printk, etc. and thus is unusable. Is there a good reason against reverting to

I am trying to do VPATH builds of R3.1.3, i.e. binaries built outside the source directory. It works just fine on Linux but on Mac OSX (Mavericks) I get the following trace from make, after a successful configure step. Any insights gratefully received. make is GNU make 3.81 on both systems. bash-3.2$ make make make[1]: Nothing to be done for `R'. make[1]: Nothing to be done for `R'.