similar to: [PATCH] p2v: use newer GTK APIs if possible

Currently virt-p2v requires Gtk 2. This commit changes virt-p2v so it can be built with either Gtk 2 or 3. By careful use of macros, this code should compile on both recent Gtk 2 and Gtk 3. With no other options, ./configure will now prefer Gtk 3 if it finds it, or fall back to Gtk 2. But you can control this by setting './configure --with-gtk=2|3|check|no' where the options mean: *

v1 -> v2: Added a (now blue) underlined "Identify interface" link. It's not really a link, but it looks like one, so hopefully should resolve the previous UI issue. Rich.

GtkAboutDialog in GTK+ 3 can be configured with few standard licenses, including GPL2+. Thus, just set that property, so the about dialog will show its own license text, and there is no need for our custom one. --- p2v/gui.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/p2v/gui.c b/p2v/gui.c index 563e1a7..203ca2c 100644 --- a/p2v/gui.c +++ b/p2v/gui.c @@ -134,6 +134,7 @@ static

This version of the Gtk 2/3 patch gets alignment and padding mostly right. I still can't work out how to vertically align labels in the middle of a cell in a GtkGrid. The GtkTextView in the final dialog is still broken. Rich.

When the user clicks on the second column of the list of network interfaces, run 'ethtool --identify <if_name> 10', which (on supported cards) flashes a light on the physical interface for 10 seconds, allowing it to be identified by the operator. This has a nasty bit of hidden UI, basically because Gtk makes it near impossible to put a regular button into a GtkTreeView. ---

Now that virt-p2v has its own repository [1] and releases [2], it is time to remove it from libguestfs. [1] https://github.com/libguestfs/virt-p2v [2] http://download.libguestfs.org/virt-p2v/ Pino Toscano (2): Remove virt-p2v Remove remaining virt-p2v bits .gitignore | 4 - Makefile.am | 7 +- bash/Makefile.am

... and a small initial patch which makes it easier to test virt-p2v without having to start up a virtual machine. There is still a bug in Gtk 3 where the GtkTextView on the final (running) dialog ignores gtk_widget_set_size_request and so the window appears just a single pixel high. Rich.

This is basically the same as what I posted earlier today. The main difference is I split out the GDK thread sychronization (removal of) changes from the other Gtk 2/3 changes, which should make it a bit easier to review. Gtk 3 is still not quite perfect. Apart from the problem with the GtkTextView noted before, there are also vertical alignment and padding problems with labels in GtkGrid

This series for virt-p2v removes the usage of GTK deprecated stuff, and checks for a required Perl module used during build. Tested on: - RHEL 6 (GTK 2) - RHEL 7 (GTK 3) - Fedora 30 (GTK 2 & 3) - Fedora Rawhide/32 (GTK 2 & 3) Pino Toscano (3): Copy GtkAttachOptions from GTK >= 3.4 build: disable deprecated GTK stuff build: require List::MoreUtils Makefile.am | 1 +

As preliminary steps in splitting virt-p2v to an own repository, continue making p2v more independent within libguestfs. This is accomplished by the following changes: - have only the authors in the about dialog, and read them from a local AUTHORS file - few more cleanups This is still not complete, although I believe most of the work needed is done, and it still makes p2v usable within

It is used only for the about dialog, and this way it will be easier to disable. --- p2v/Makefile.am | 1 - p2v/about-license.c | 38 -------------------------------------- p2v/gui.c | 16 ++++++++++++++++ p2v/p2v.h | 3 --- 4 files changed, 16 insertions(+), 42 deletions(-) delete mode 100644 p2v/about-license.c diff --git a/p2v/Makefile.am b/p2v/Makefile.am index

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1792141 Let the user pass "-oo" options from the kernel cmdline and from the GUI to virt-v2v. This is primarily useful with the OpenStack output mode, so reenable that mode. Cc: Alban Lecorps <alban.lecorps at ubisoft.com> Laszlo Alban Lecorps (1): Introduce "p2v.output.misc" for passing "-oo" options

Hi Have been wrestling with the frequent GC segfaults on Windows. Seems they occur b/c Windows sends Events (UpdateUIEvents, I think) with the same pointer repeatedly. These get wrapped in a ruby Event object as they are processed, and a mapping stored through SWIG''s trackobjects. However, the ruby object isn''t referenced anywhere, so gets swept and destroyed by GC when it

Add a "Shutdown" action to the Shutdown button in the conversion dialog, before the Reboot action: this way it is possible to shutdown the physical server directly from the GUI after the conversion. --- p2v/gui.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/p2v/gui.c b/p2v/gui.c index 10fb2939a..7aea4afd5 100644 --- a/p2v/gui.c +++

Add a "Shutdown" action to the Shutdown button in the conversion dialog, before the Reboot action: this way it is possible to shutdown the physical server directly from the GUI after the conversion. --- p2v/gui.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/p2v/gui.c b/p2v/gui.c index 10fb2939a..e78f1186c 100644 --- a/p2v/gui.c +++

On my lab systems, the automatic updates were failing because of the problems with ipod libraries from EPEL being in the way. It turns out that was a good thing, because when I "fixed" it, a massive set of packages was updated, including the new gtk3. These packages are the ones causing problems, I think. gtk3-3.22.10-4.el7.x86_64 gtk3-devel-3.22.10-4.el7.x86_64 In the release notes,

passing in --hostname <value> will bypass the hostname form passing --username <value> --password <value> will bypass the login form passing in --vm <name> will attempt to connect to the vm on login --- internal.h | 9 ++++- main.c | 100 +++++++++++++++++++++++++++++++++++++++++++++++---------- wui_thread.c | 15 +-------- 3 files changed, 90 insertions(+),

This small series for p2v refactors the Reboot menu of the conversion dialog into something slightly more general, and add the possibility to shut the machine down. Lots of work to deal with old GTK versions ... Changes from v1: - fix shutdown command Pino Toscano (2): p2v: turn Reboot button into a Shutdown popup menu button p2v: add a Shutdown action (RHBZ#1642044) p2v/gui.c |

This small series for p2v refactors the Reboot menu of the conversion dialog into something slightly more general, and add the possibility to shut the machine down. Lots of work to deal with old GTK versions ... Pino Toscano (2): p2v: turn Reboot button into a Shutdown popup menu button p2v: add a Shutdown action (RHBZ#1642044) p2v/gui.c | 119

configure.ac | 2 +- libswfdec-gtk/swfdec_gtk_widget.c | 11 ++++------- libswfdec-gtk/swfdec_playback_alsa.c | 8 +++++++- libswfdec/swfdec_as_date.c | 18 ++++++++++-------- libswfdec/swfdec_as_interpret.c | 2 ++ libswfdec/swfdec_as_types.c | 5 +++++ libswfdec/swfdec_audio_flv.c | 2 +- libswfdec/swfdec_audio_flv.h