Displaying 20 results from an estimated 2000 matches similar to: "[PATCH RHEL 7.6 LP] RHEL 7.6 LP: Convert Python 3 to Python 2."
2018 Aug 28
2
[PATCH] v2v: rhv-upload-plugin: Use BrokenPipeError
With python 3, we have a nicer way to handle socket.error with errno set
to EPIPE (or ESHUTDOWN).
This is also more correct since in some cases (that I could not
reproduce yet with v2v), using e[0] with BrokenPipeError will fail with:
>>> OSError(errno.EPIPE, "Broken pipe")[0]
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
2018 Aug 28
0
[PATCH RHEL 7.6 LP] RHEL 7.6 LP: Convert Python 3 to Python 2.
From: "Richard W.M. Jones" <rjones@redhat.com>
Updates commit 8f250c00c8b028a614815f63b2713748504d7ef9 for RHEL 7.6 LP.
---
v2v/rhv-upload-plugin.py | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py
index 42c7065..3e561e6 100644
--- a/v2v/rhv-upload-plugin.py
+++ b/v2v/rhv-upload-plugin.py
@@ -383,8
2018 Dec 07
2
[PATCH] v2v: -o rhv-upload: Fix emulated zero
Replace python 2 only "buffer" with "memoryview".
Falling back to emulated zero would fail with:
NameError: name 'buffer' is not defined
I did not test the changed code but it was not tested before so it is
unlikely to be worse.
Detected by pylint.
---
v2v/rhv-upload-plugin.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
2018 Aug 20
3
[PATCH 0/2] v2v: rhv-upload-plugin: Improve error handling
These patches improve error handling when PUT request fail, including
the error response from oVirt server. This will make it easier to debug
issue when oVirt server logs have been rotated.
Nir Soffer (2):
v2v: rhv-upload-plugin: Handle send send failures
v2v: rhv-upload-plugin: Fix error formatting
v2v/rhv-upload-plugin.py | 24 +++++++++++++++++-------
1 file changed, 17 insertions(+), 7
2018 Jun 06
2
[PATCH v2] v2v: -o rhv-upload: Log full imageio response on failure.
v1 was here:
https://www.redhat.com/archives/libguestfs/2018-June/msg00015.html
v2 fixes all the issues raised in Nir's review. I tested it against
ovirt-engine-4.2.4.1-1.el7.noarch and it works, although I wasn't
easily able to trigger the error path so that code is not really
tested (except for syntax checking).
Rich.
2018 Jun 05
2
[PATCH] v2v: Log full imageio response on failure.
Thanks: Nir Soffer
---
v2v/rhv-upload-plugin.py | 66 ++++++++++++++++++++++++++++--------------------
1 file changed, 39 insertions(+), 27 deletions(-)
diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py
index 791c9e7d2..c3de7d555 100644
--- a/v2v/rhv-upload-plugin.py
+++ b/v2v/rhv-upload-plugin.py
@@ -228,6 +228,29 @@ def can_flush(h):
def get_size(h):
return
2018 Jun 29
2
[PATCH] v2v: rhv-upload-plugin: Remove unneeded auth
Old imageio proxy was using Authorization header for GET and PUT
requests. Remove unneeded authorization when sending OPTIONS request.
Remove unneeded duplicated comments about authorization for old
imageio, and replace them with a comment when we set needs_auth.
---
v2v/rhv-upload-plugin.py | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/v2v/rhv-upload-plugin.py
2019 Nov 21
1
[PATCH] rhv-upload: Handle any error in NBD handlers
Currently we handle only HTTP errors like getting unexpected response
code from imageio server. However if we could not send the request, or
some other error is raised, we failed to mark the handle as failed, and
finalized the transfer in close(). This may fool virt-v2v to create a VM
with an empty or partially uploaded disk.
Decorate all the NBD hander functions with a @failing decorator,
2018 Aug 28
0
Re: [PATCH] v2v: rhv-upload-plugin: Use BrokenPipeError
On Tue, Aug 28, 2018 at 11:50:56PM +0300, Nir Soffer wrote:
> With python 3, we have a nicer way to handle socket.error with errno set
> to EPIPE (or ESHUTDOWN).
>
> This is also more correct since in some cases (that I could not
> reproduce yet with v2v), using e[0] with BrokenPipeError will fail with:
>
> >>> OSError(errno.EPIPE, "Broken pipe")[0]
>
2018 Jun 25
2
[PATCH] v2v: rhv-upload-plugin: Fix name error
http was missing in emulate_zero, so the code would fail with NameError.
This can happen only when communicating with old imageio versions not
supporting the "zero" feature.
Testing with qemu-img 2.12 show that we never send emulated zero request
because of the highestwrite mechanism, but it can break with older
qemu-img-rhev used on RHEL.
---
v2v/rhv-upload-plugin.py | 2 ++
1 file
2018 Apr 05
2
[PATCH v8] v2v: Add -o rhv-upload output mode (RHBZ#1557273).
v7 was here:
https://www.redhat.com/archives/libguestfs/2018-March/msg00143.html
Since then:
- Earlier patches are now upstream.
- The to-do list is moved from the commit message to the TODO file.
- This version forces -of raw + -oa sparse and gives an error in
any other mode. We intend to lift these restrictions later.
- Tested against latest imageio which supports longer timeouts,
2018 Jun 14
5
[PATCH] v2v: -o rhv-upload: Optimize http request sending
When sending request with small or no payload, it is simpler and
possibly more efficient to use the high level HTTPSConnection.request(),
instead of the lower level APIs.
The only reason to use the lower level APIs is to avoid copying the
payload, or on python 2, to use a bigger buffer size when streaming a
file-like object.
---
v2v/rhv-upload-plugin.py | 35 ++++++++++++++++-------------------
2018 Apr 10
2
[PATCH v9] v2v: Add -o rhv-upload output mode (RHBZ#1557273).
v8 was here:
https://www.redhat.com/archives/libguestfs/2018-April/msg00022.html
v8 -> v9:
- Addresses the only feedback from Tomáš.
Rich.
2020 Jul 08
2
[PATCH] RFC: rhv-upload-plugin: Use imageio client
We can use now ImageioClient to communicate with ovirt-imageio server
on oVirt host.
Using the client greatly simplifies the plugin, and enables new features
like transparent proxy support. The client will use transfer_url if
possible, or fall back to proxy_url.
Since the client implements the buffer protocol, move to version 2 of
the API for more efficient pread().
Another advantage the client
2018 Jun 25
1
[PATCH] v2v: rhv-upload-plugin: Remove unused variables
Remove some instances of "transfer" and "transfer_service" that are not
used in current code.
---
v2v/rhv-upload-plugin.py | 4 ----
1 file changed, 4 deletions(-)
diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py
index 10887c031..5c036c46a 100644
--- a/v2v/rhv-upload-plugin.py
+++ b/v2v/rhv-upload-plugin.py
@@ -263,7 +263,6 @@ def request_failed(h, r, msg):
2018 Mar 12
2
[PATCH] v2v: -o rhv-upload: Support zero requests.
Only compile tested.
I'm keeping this as a separate patch for the moment until the
relevant change on the oVirt side goes upstream.
Rich.
2018 Jun 22
4
v2v: -o rhv-upload: Use Unix domain socket to access imageio (RHBZ#1588088).
v1 was here:
https://www.redhat.com/archives/libguestfs/2018-June/msg00099.html
v2:
- Just fixes the two problems noted in the review of the previous version.
Rich.
2018 Mar 26
4
Re: [PATCH v7 6/6] v2v: Add -o rhv-upload output mode (RHBZ#1557273).
On Mon, Mar 26, 2018 at 11:41 AM Richard W.M. Jones <rjones@redhat.com>
wrote:
> On Sun, Mar 25, 2018 at 08:05:14PM +0000, Nir Soffer wrote:
> > When using the sdk, you can select both the image format and sparse, so
> you
> > can create invalid combinations. oVirt selects the allocation for you.
> >
> > storage type image format sparse | allocation
2018 Mar 24
4
Re: [PATCH v7 6/6] v2v: Add -o rhv-upload output mode (RHBZ#1557273).
On Thu, Mar 22, 2018 at 5:25 PM Richard W.M. Jones <rjones@redhat.com>
wrote:
> PROBLEMS:
> - -of qcow2 does not work, with multiple problems
> * needs to set NBD size to something larger than virtual size
>
How is this related to the actual file size specified when you create a
disk?
In block storage, qcow2 image is always on a thin provisioned disk, which
in oVirt is a
2019 Nov 23
2
Re: [PATCH nbdkit v2 10/10] tests: Test the Python plugin thoroughly.
On Sat, Nov 23, 2019 at 3:10 PM Richard W.M. Jones <rjones@redhat.com> wrote:
>
> On Sat, Nov 23, 2019 at 01:42:15AM +0200, Nir Soffer wrote:
> > On Fri, Nov 22, 2019 at 9:55 PM Richard W.M. Jones <rjones@redhat.com> wrote:
> > > +def pread(h, count, offset, flags):
> > > + assert flags == 0
> > > + return