similar to: [PATCH v2] lib: Convert all drive socket parameters to an absolute path (RHBZ#1588451).

From: Nikolay Ivanets <stenavin@gmail.com> Nowadays there are hard drives and operating systems which support "4K native" sector size. In this mode physical and logical block size exposed to the operating system is equal to 4096 bytes. GPT partition table (as a known example) being created in this mode will place GPT header at LBA1 which is 4096 bytes. libguetfs is unable to

From: Nikolay Ivanets <stenavin@gmail.com> Nowadays there are hard drives and operating systems which support "4K native" sector size. In this mode physical and logical block size exposed to the operating system is equal to 4096 bytes. GPT partition table (as a known example) being created in this mode will place GPT header at LBA1 which is 4096 bytes. libguetfs is unable to

A disk of type 'volume' is stored as <source pool='pool_name' volume='volume_name'/> and its real location is inside the 'volume_name', as 'pool_name': in this case, query libvirt for the actual path of the specified volume in the specified pool. Adjust the code so that: - for_each_disk gets the virConnectPtr, needed to do operations with libvirt

On Tue, Sep 27, 2016 at 11:20:07AM +0200, Pino Toscano wrote: > When parsing the URI, drop the leading '/' from the path also when the > protocol is 'nbd': in this case, the path represents the export name, > which does not need the '/' coming from the URI format. > > Improve the coverage for nbd in test-add-uri.sh, adding a couple of > tests, and

When parsing the URI, drop the leading '/' from the path also when the protocol is 'nbd': in this case, the path represents the export name, which does not need the '/' coming from the URI format. Improve the coverage for nbd in test-add-uri.sh, adding a couple of tests, and adjusting the result of an existing one. --- fish/test-add-uri.sh | 8 +++++++- fish/uri.c

Instead of running all the tests manually, the unittest module has a 'discovery' mode to run tests by importing them from a directory: this requires the tests to have different filenames, since they need to be imported as modules now (hence an empty __init__.py is added), and the current naming does not match the convention. Using unittest as loader/runner brings another change: tests

Miscellaneous fixes to: - Handling of Ceph drives now works end-to-end (RHBZ#1026688). - In particular, you can now use rbd:/// URIs in guestfish (and they work). - Parse Ceph & NBD network drives from libvirt XML correctly, so that existing domains with Ceph/NBD drives can be added (eg. using guestfish -d option). - Add more testing of the above.

When possible, make the disk image format explicit when invoking tools or using add-drive. This avoids warnings from qemu about the unspecified format for the image, and also makes qemu slightly faster (skipping the disk image probing). Tests checking the image probing are not touched. This changes also: - old-style invocations of tools (`$tool $filename`) into new style (`$tool -a $filename`)

(apologies if you see this twice, forgot the CC the first time) In data venerdì 26 giugno 2015 18:50:16, Gabriel Hartmann ha scritto: > > > > > By default, when saving a URI using xmlSaveUri it escapes everything in > > the URI. QEMU doesn't want anything escaped, so now I unescape > > everything after the URI is generated. Unfortunately there's no flag to

Rename the existing tests according to the naming/numbering described in guestfs-hacking(1), and improve the current ones: - guestfs_php_001.phpt: rename to guestfs_020_create.phpt - guestfs_php_003.phpt: rename to guestfs_070_optargs.phpt - guestfs_php_bindtests.phpt: rename to guestfs_090_bindtests.phpt - guestfs_091_version.phpt: new, checks taken from the former guestfs_php_002.phpt -

https://bugzilla.redhat.com/show_bug.cgi?id=1588451 v2 was here: https://www.redhat.com/archives/libguestfs/2018-June/msg00067.html This is a greatly simplified version, which just changes the libvirt backend to make the path absolute. None of the tests need to be adjusted. Rich.

--- lib/launch-libvirt.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/lib/launch-libvirt.c b/lib/launch-libvirt.c index b279aa6b9..48404ef93 100644 --- a/lib/launch-libvirt.c +++ b/lib/launch-libvirt.c @@ -23,6 +23,7 @@ #include <stdarg.h> #include <stdbool.h> #include <unistd.h> +#include <limits.h> #include <fcntl.h>

On Mon, Jan 20, 2014 at 04:39:42PM +0100, Olaf Hering wrote: > > Is "luks-format" supposed to work with guestfish? Like guestfish <<EOF > luks-format /dev/sda4 0 > EOF > > Appearently it lacks an option to give the passphrase programmatically. > Was this option skipped on purpose? The underlying API takes a passphrase parameter, ie:

Please take a look. This feature is necessary for in-place image expanding. On 12/01/2015 06:28 PM, Maxim Perevedentsev wrote: > This action moves second(backup) GPT header to the end of the disk. > It is usable in in-place image expanding, since free space after > second GPT header is unusable. To use additional space, we have > to move second header. This is what sgdisk -e does.

The internal_yara_scan runs the Yara engine with the previously loaded rules against the given file. For each rule matching against the scanned file, a struct containing the file name and the rule identifier is returned. The gathered list of yara_detection structs is serialised into XDR format and written to a file. Signed-off-by: Matteo Cafasso <noxdafox@gmail.com> --- daemon/yara.c

This action moves second(backup) GPT header to the end of the disk. It is usable in in-place image expanding, since free space after second GPT header is unusable. To use additional space, we have to move second header. This is what sgdisk -e does. However, sgdisk -e may perform additional actions if the partition table has unexpected params (e.g. if we call sgdisk -e /dev/sda1, it may fix

> > > By default, when saving a URI using xmlSaveUri it escapes everything in > the URI. QEMU doesn't want anything escaped, so now I unescape > everything after the URI is generated. Unfortunately there's no flag to > change the default behavior. > > I'm not sure that's the actual issue here, but I'm somehow included to > think this is another

On Sat, Mar 14, 2020 at 04:48:24AM +0000, JP Zhang wrote: > HI Richard, > > Thanks for the quick reply. > > The Python program that works, that I mentioned earlier, uses subprocess to issue/run "guestfish" commands below in that order. > /libguestfs/run guestfish --listen -a <https storage-SAS-URL> -- ro > then the Python code exported $PID to the

This worked wonderfully!  What are the odds of getting this upstream in the near future?  I'd rather not build from source in production. # ./run guestfish --format=raw --ro -a rbd://[fd00::cefc:1]:6789/images/CentOS-7-x86_64-GenericCloud-1901 libguestfs: trace: set_verbose true libguestfs: trace: set_verbose = 0 libguestfs: trace: set_tmpdir "/root/libguestfs/tmp" libguestfs:

print "" is no more available in Python 3, and print(...) is available since Python 2.7; as one of the tests was using print(), use this form everywhere so the tests can run fine with Python 3. --- python/t/820-rhbz912499.py | 18 +++++++++--------- python/t/910-libvirt.py | 4 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/python/t/820-rhbz912499.py