similar to: [RFC] fuse: mount_local: Fix crash when called from Java binding

"localmountpoint" parameter is allocated in JNI before calling mount_local and freed afterward. But guestfs handle keeps reference to passed "localmountpoint" parameter and will try to access it in umount_local and free after mount_local_run caller thread ends which leads to a crash (an attempt to access to already freed memory). --- lib/fuse.c | 5 +++-- lib/handle.c | 1 +

This changes the proposed API slightly. Previously 'mount-local' generating a 'mounted' event when the filesystem was ready, and from the 'mounted' event you had to effectively do a fork. Now, 'mount-local' just initializes the mountpoint and you have to call 'mount-local-run' to enter the FUSE main loop. Between these calls you can do a fork or whatever

When initializing FUSE, use the program name as set (either automatically or manually) in the guestfs handle. --- lib/fuse.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/fuse.c b/lib/fuse.c index 0180f8f..98bbc8d 100644 --- a/lib/fuse.c +++ b/lib/fuse.c @@ -989,8 +989,7 @@ guestfs_impl_mount_local (guestfs_h *g, const char *localmountpoint, return -1; /*

This patch is just for review. It enables FUSE support in the API via two new calls, 'guestfs_mount_local' and 'guestfs_umount_local'. FUSE turns out to be very easy to deadlock (necessitating that the machine be rebooted). Running the test from the third patch is usually an effective way to demonstrate this. However I have not yet managed to produce a simple reproducer that

This version doesn't crash or cause hung processes or stuck mountpoints, so that's an improvement. Rich.

debug() adds it already. --- src/fuse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/fuse.c b/src/fuse.c index d684c84..288c02a 100644 --- a/src/fuse.c +++ b/src/fuse.c @@ -68,7 +68,7 @@ gl_lock_define_initialized (static, mount_local_lock); #define DEBUG_CALL(fs,...) \ if (g->ml_debug_calls) {

The 'localmountpoint' variable in the handle is available only when building with FUSE support, so guard it in a proper #ifdef block. Fixes commit 296370fb86e96eec095d86faf6de8f532395ea54. --- lib/handle.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/handle.c b/lib/handle.c index bc45d29b2..a47aaafab 100644 --- a/lib/handle.c +++ b/lib/handle.c @@ -399,7 +399,9 @@

When initializing FUSE, use the program name as set (either automatically or manually) in the guestfs handle. --- src/fuse.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/fuse.c b/src/fuse.c index 0180f8f..98bbc8d 100644 --- a/src/fuse.c +++ b/src/fuse.c @@ -989,8 +989,7 @@ guestfs_impl_mount_local (guestfs_h *g, const char *localmountpoint, return -1; /*

On Thu, Feb 02, 2017 at 02:32:45PM +0100, Pino Toscano wrote: > When initializing FUSE, use the program name as set (either > automatically or manually) in the guestfs handle. > --- > lib/fuse.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/lib/fuse.c b/lib/fuse.c > index 0180f8f..98bbc8d 100644 > --- a/lib/fuse.c > +++ b/lib/fuse.c >

[These two patches are for discussion only] Allow FUSE support to be used directly through the API. This is the second commit. In order to make this usable from guestfish, we have to also bind the events API in guestfish. This is the first commit. Rich.

Hi everyone, lately I've been getting familiar with library and working on slight re-layering of the library. It's about having locking layer in public API and tracing one layer below that (let's call it __t_ layer. I'm not very good at making up names, so this is temporary:) ). Then making sure that all generated public stuff call __t_ layer and all other internal stuff

Hi, Mr. Rich. I am sorry that I left too little information in the last email because I edited with my mobile phone. I wrote about my first question in the following link. https://rwmj.wordpress.com/2010/11/15/libguestfs-inspection-now-lists-windows-apps/ 2nd. Question After I call the mount_local() function in guestfs.py to operate on a disk, I hope to umount it. After calling the

The gobject bindings generate a large number of header files, which pollute /usr/include when installed. This patch moves them all into a guestfs-gobject/ subdirectory. guestfs-gobject.h remains in the same place. This change also moves generated source files into src/, because it makes the gobject directory a bit tidier. --- generator/Makefile.am | 3 +

Upon seeing RWM Jones article "Using mount-local API from C" I became curious because I thought there WAS a way to combine aspects of FUSE with the tools provided by libguestfs. So if I wanted to create my own filesystem using callbacks placed in the 'fuse_operations' struct (parameter to 'fuse_main()'), I could do so using guestfs. But after reading the article and

Inspired by libvirt's virCommand* internal mini-library, this adds some internal APIs for running commands. The first patch contains the new APIs. The subsequent patches change various parts of the library over to use it. Rich.

Add the option force and lazy for force and lazy umount. Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- daemon/mount.c | 25 +++++++++++++++++++++++-- generator/generator_actions.ml | 23 ++++++++++++----------- gobject/Makefile.inc | 2 ++ po/POTFILES | 1 + 4 files changed, 38 insertions(+), 13 deletions(-) diff --git

Add a macro DUP_RESOLVE_DEVICE_OR_PATH to resolve path or device. Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- daemon/daemon.h | 18 ++++++++++++++++++ daemon/mount.c | 13 ++----------- po/POTFILES | 8 ++++++++ 3 files changed, 28 insertions(+), 11 deletions(-) diff --git a/daemon/daemon.h b/daemon/daemon.h index 85eec45..39cc3f3 100644 --- a/daemon/daemon.h +++

Introduces private pool of muteces (per_handle_locks) guarded by read-write mutex (locks_lock) using guestfs__per_handle_lock_lock(g) and guestfs__per_handle_lock_unlock(g), where g is current valid guestfs_h handle. Above two are used in generator/c.ml at begin and end of each non-deamon call. New lock can be created using guestfs__per_handle_lock_add(g) and destroyed with

On Tuesday, 7 March 2017 15:26:57 CET Cédric Bosdonnat wrote: > In order to further reuse the osinfo database parsing in OCAML, this > commit extracts the XML processing for the distro ISOs and places it > into a newly created callback. > > This will later help other code to traverse the osinfo DB files and > let them extract what they need from them. > --- Mostly LGTM, just