similar to: Re: Change in ovirt-imageio[master]: Document the random I/O APIs

On Wed, Mar 21, 2018 at 11:20:13AM +0000, Nir Soffer wrote: > Hi, > > I updated the random I/O documentation patch: > https://gerrit.ovirt.org/#/c/89022/ > > I would to get your comments on this before we complete the implementation. Looks great to me, we can work with this. There's no mention of alignment, so can I assume that we can make arbitrarily aligned requests?

On Wed, Mar 21, 2018 at 11:20:13AM +0000, Nir Soffer wrote: > Hi, > > I updated the random I/O documentation patch: > https://gerrit.ovirt.org/#/c/89022/ > > I would to get your comments on this before we complete the implementation. I want to check a couple of things: (1) The OPTIONS request uses path ‘/images/%2A’ (ascii encoding of ‘*’). That is literally what is sent

Hi, I updated the random I/O documentation patch: https://gerrit.ovirt.org/#/c/89022/ I would to get your comments on this before we complete the implementation. Thanks, Nir

On Fri, Jun 22, 2018 at 2:59 PM Richard W.M. Jones <rjones@redhat.com> wrote: > In the case where virt-v2v runs on the same server as the imageio > daemon that we are talking to, it may be possible to optimize access > using a Unix domain socket. > > This is only an optimization. If it fails or if we're not running on > the same server it will fall back to the usual

We can use now ImageioClient to communicate with ovirt-imageio server on oVirt host. Using the client greatly simplifies the plugin, and enables new features like transparent proxy support. The client will use transfer_url if possible, or fall back to proxy_url. Since the client implements the buffer protocol, move to version 2 of the API for more efficient pread(). Another advantage the client

Fix the instructions so they should work now on CentOS 8.2: - Add note about oVirt setup - List all required packages - Add missing -W flag to the qemu-img command I tested this on Fedora 32, with ovirt-engine-sdk built from source, since the package is not available on Fedora 31 or 32, and the Fedora 30 package cannot be installed on Fedora 32. Signed-off-by: Nir Soffer

On 8/6/20 5:54 PM, Nir Soffer wrote: > This is mainly for testing the new parallel python threading model, but > it also an example how to manage multiple connection from a plugin. > > I tested this with local imageio server, serving qcow2 image on local > SSD. > > diff --git a/plugins/python/examples/imageio.py b/plugins/python/examples/imageio.py > new file mode 100644

On Thu, Jun 21, 2018 at 3:35 PM Richard W.M. Jones <rjones@redhat.com> wrote: > These two patches add support for using a Unix domain socket to > directly access imageio in the case where imageio is running on the > conversion host (usually that means virt-v2v is running on the RHV > node and something else -- eg. CFME scripts -- arranges that the RHV > node is the same one

On Wed, Mar 14, 2018 at 06:56:19PM +0000, Nir Soffer wrote: > I posted documentation for the new API optimized for random I/O: > https://gerrit.ovirt.org/#/c/89022/ Wish I'd had this documentation when I started the patch :-) Yes, it's much clearer. > I changed POST to PATCH to match the existing /tickets API, and > this also seems to be more standard way to do such

On Thu, Jul 09, 2020 at 01:51:44AM +0300, Nir Soffer wrote: > We can use now ImageioClient to communicate with ovirt-imageio server > on oVirt host. > > Using the client greatly simplifies the plugin, and enables new features > like transparent proxy support. The client will use transfer_url if > possible, or fall back to proxy_url. > > Since the client implements the

In the case where virt-v2v runs on the same server as the imageio daemon that we are talking to, it may be possible to optimize access using a Unix domain socket. This is only an optimization. If it fails or if we're not running on the same server it will fall back to the usual HTTPS over TCP connection. Thanks: Nir Soffer, Daniel Erez. --- v2v/rhv-upload-plugin.py | 61

On Thu, Jul 09, 2020 at 03:30:22PM +0300, Nir Soffer wrote: > Testing with a real server is easy. I have incomplete patch using > imageio server with some manual setup. [...] For a certain definition of "easy" :-) Our QE team tests -o rhv-upload from time to time, and will do an end-to-end test of the system when RHV 4.4 arrives with the new feature. For “make check” we need

On Thu, Jul 9, 2020 at 4:49 PM Nir Soffer <nsoffer@redhat.com> wrote: > > On Thu, Jul 9, 2020 at 4:12 PM Richard W.M. Jones <rjones@redhat.com> wrote: > > > > On Thu, Jul 09, 2020 at 03:30:22PM +0300, Nir Soffer wrote: > > > Testing with a real server is easy. I have incomplete patch using > > > imageio server with some manual setup. > > [...]

In the case where virt-v2v runs on the same server as the imageio daemon that we are talking to, it may be possible to optimize access using a Unix domain socket. This is only an optimization. If it fails or if we're not running on the same server it will fall back to the usual HTTPS over TCP connection. --- v2v/rhv-upload-plugin.py | 65 +++++++++++++++++++++++++++++++++++++++++++++--- 1

In the case where virt-v2v runs on the same server as the imageio daemon that we are talking to, it may be possible to optimize access using a Unix domain socket. This is only an optimization. If it fails or if we're not running on the same server it will fall back to the usual HTTPS over TCP connection. --- v2v/rhv-upload-plugin.py | 61 +++++++++++++++++++++++++++++++++++++++++++++++- 1

On Fri, Aug 7, 2020 at 1:54 AM Nir Soffer <nirsof@gmail.com> wrote: > > This is mainly for testing the new parallel python threading model, but > it also an example how to manage multiple connection from a plugin. > > I tested this with local imageio server, serving qcow2 image on local > SSD. > > Start imageio server from imageio source: > > ./ovirt-imageio

On Thu, Nov 21, 2019 at 05:50:18PM +0200, Nir Soffer wrote: > If we want to support recoverable errors, we can define a special > RecoverableError exception that signal the python plugin that this > request failed, but the error is not fatal. The problem is only the client knows if the error was recovered from. It's a pretty complicated problem and it seems we've got a good

On Tue, Jun 26, 2018 at 9:38 PM Nir Soffer <nsoffer@redhat.com> wrote: > On Tue, Jun 26, 2018 at 4:25 PM Richard W.M. Jones <rjones@redhat.com> > wrote: > >> In the case where virt-v2v runs on the same server as the imageio >> daemon that we are talking to, it may be possible to optimize access >> using a Unix domain socket. >> >> This is only an

Thanks: Nir Soffer --- v2v/rhv-upload-plugin.py | 69 +++++++++++++++++++++++++++++------------------- 1 file changed, 42 insertions(+), 27 deletions(-) diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py index 791c9e7d2..f43ad0097 100644 --- a/v2v/rhv-upload-plugin.py +++ b/v2v/rhv-upload-plugin.py @@ -228,6 +228,32 @@ def can_flush(h): def get_size(h): return

On Wed, Jun 27, 2018 at 12:37:20PM +0300, Nir Soffer wrote: > I tested the patch yesterday, and unix socket did not work - silently. > > After changing the code to: > > try: > with builtin_open("/etc/vdsm/vdsm.id") as f: > vdsm_id = f.readline().strip() > except Exception as e: > debug("cannot read host hardware id: