similar to: [PATCH] df: Handle block sizes smaller than 1024 bytes (RHBZ#1525241).

GCC 7.0.1 can determine if there is likely to be sufficient space in the output buffer when using sprintf/snprintf, based on the format string. The errors were all either of this form: bindtests.c:717:29: error: '%zu' directive output may be truncated writing between 1 and 19 bytes into a region of size 16 [-Werror=format-truncation=] snprintf (strs[i], 16, "%zu", i);

GCC 7.0.1 can determine if there is likely to be sufficient space in the output buffer when using sprintf/snprintf, based on the format string. The errors were all either of this form: bindtests.c:717:29: error: '%zu' directive output may be truncated writing between 1 and 19 bytes into a region of size 16 [-Werror=format-truncation=] snprintf (strs[i], 16, "%zu", i);

Previously we measured the total time and used it to calculate the rate of different operations. This is misleading and hiding the real throughput. Change single operation stats to use the time spent in this operation. To understand total system throughput, show also new "total" stats, summing ops, bytes of other operations, and using the total time. This works well for copying images

I find bytes and bits-per-second unhelpful and hard to parse. Add also size in GiB, and show rate in MiB per second. This works well for common disk images and storage. Here is an example run with this change: $ ./nbdkit --foreground \ --unix /tmp/nbd.sock \ --exportname '' \ --filter stats \ file file=/var/tmp/dst.img \ statsfile=/dev/stderr \ --run 'qemu-img

flush is usually called once but it can take significant time, so we need to include it. Here is an example run with this change: $ ./nbdkit --foreground \ --unix /tmp/nbd.sock \ --exportname '' \ --filter stats \ file file=/var/tmp/dst.img \ statsfile=/dev/stderr \ --run 'qemu-img convert -p -n -f raw -O raw -T none /var/tmp/fedora-30.img

Change the first line to show total ops, time, total size, and rate. The totals are useful for understanding the total throughput of the application. --- filters/stats/nbdkit-stats-filter.pod | 8 ++++---- filters/stats/stats.c | 19 ++++++++++++++++++- 2 files changed, 22 insertions(+), 5 deletions(-) diff --git a/filters/stats/nbdkit-stats-filter.pod

Simple utility to list information about a files. The utility which does the same thing as "ls -la". This is a useful test program. Signed-off-by: Alexey Gladkov <gladkov.alexey at gmail.com> --- usr/utils/Kbuild | 4 +- usr/utils/ls.c | 202 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 205 insertions(+), 1 deletions(-) create mode 100644

Simple utility to list information about a files. The utility which does the same thing as "ls -la". This is a useful test program. Signed-off-by: Alexey Gladkov <gladkov.alexey at gmail.com> --- usr/utils/Kbuild | 4 +- usr/utils/minils.c | 198 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 201 insertions(+), 1 deletions(-) create mode 100644

Commit-ID: 858e50330e2c7834bb81095fb666fd08ff0d4869 Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=858e50330e2c7834bb81095fb666fd08ff0d4869 Author: Herbert Xu <herbert at gondor.apana.org.au> AuthorDate: Mon, 27 Oct 2014 16:04:44 +0800 Committer: Ben Hutchings <ben at decadent.org.uk> CommitDate: Fri, 25 Jan 2019 02:57:21 +0000 [klibc] [BUILTIN] Remove

Commit-ID: bdfdde71b9ec8f4678f498445d38f5361bb08138 Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=bdfdde71b9ec8f4678f498445d38f5361bb08138 Author: Herbert Xu <herbert at gondor.apana.org.au> AuthorDate: Mon, 27 Oct 2014 16:04:44 +0800 Committer: Ben Hutchings <ben at decadent.org.uk> CommitDate: Sat, 28 Mar 2020 21:42:54 +0000 [klibc] dash: [BUILTIN]

Updating gnulib has caused -Wformat-signedness to be enabled. This has revealed many problems in C format strings. The fixes here fall into the following main categories: - Using %d with an unsigned parameter. - %x and %o expect an unsigned argument. - uid_t and gid_t are unsigned on Linux. The safe way to print these is to cast them to uintmax_t and then print then using the %ju

Updating gnulib has caused -Wformat-signedness to be enabled. This has revealed many problems in C format strings. The fixes here fall into the following main categories: - Using %d with an unsigned parameter. - %x and %o expect an unsigned argument. - uid_t and gid_t are unsigned on Linux. The safe way to print these is to cast them to uintmax_t and then print them using the %ju

Details of the changes in second patch set as outlined in the first mail of this series: -------------------------------------------------------------------------------------------------------------------------- diff --git a/usr/include/arch/aarch64/klibc/archconfig.h b/usr/include/arch/aarch64/klibc/archconfig.h index 5cc1e7e..5ee278d 100644 --- a/usr/include/arch/aarch64/klibc/archconfig.h +++

This is largely code motion. --- src/appliance.c | 40 +++++++----------------------------- src/guestfs-internal.h | 1 + src/tmpdirs.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 63 insertions(+), 33 deletions(-) diff --git a/src/appliance.c b/src/appliance.c index 2cf6374..d293c2b 100644 --- a/src/appliance.c +++ b/src/appliance.c @@ -48,7 +48,7

In case you're ok with not version-controlling files imported via autogen, ... >From 72c829395bb6a4800516d4f535e18af48195585b Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Mon, 3 Aug 2009 11:00:22 -0400 Subject: [PATCH] Remove files imported via autogen.sh. * m4/.gitignore: Ignore these files. * m4/codeset.m4: Remove file. * m4/gettext.m4: Likewise. *

- Use more friendly output with GiB and MiB/s - Measure time per operation, providing finer grain stats - Add total stats for understanding system throughput - Add missing stats for flush I hope that these changes will help to understand and improve virt-v2v performance. Changes since v1: - Keep bytes values - Increase precision to 0.001 GiB and 0.001 MiB/s - Add total stats - Show time before

Compiling krl.c with clang results in a slew of warnings like this one: /usr/src/secure/lib/libssh/../../../crypto/openssh/krl.c:505:37: warning: format specifies type 'unsigned long long' but the argument has type 'u_int64_t' (aka 'unsigned long') [-Wformat] This comes from incorrectly assuming that u_int64_t is defined as unsigned long long, whereas on

This happens with GCC 7.0.1. The errors were all of the form: qemu-speed-test.c: In function 'main': qemu-speed-test.c:153:7: error: this statement may fall through [-Werror=implicit-fallthrough=] usage (EXIT_SUCCESS); ^~~~~~~~~~~~~~~~~~~~ qemu-speed-test.c:155:5: note: here default: ^~~~~~~ --- builder/index-validate.c | 2 +-

Make stats output easier to parse and more useful for humans. Here is an example output with this change: elapsed time: 1.33377 s read: 248 ops, 4.75 MiB, 3.56 MiB/s write: 78 ops, 32.64 MiB, 24.48 MiB/s trim: 33 ops, 1.00 GiB, 767.75 MiB/s flush: 9 ops, 0 bytes, 0 bytes/s --- filters/stats/nbdkit-stats-filter.pod | 11 ++++---- filters/stats/stats.c | 36

hello johannes, i just discovered your wonderful plugin for dovecot. it was pretty much exactly what i was looking for, only that i didn't know that yet :) "Instead of moving mail into special folders, the user has two actions available: moving it out of the SPAM folder and moving it into the SPAM folder. The dovecot plugin watches these actions [...] and tells dspam that it made an