similar to: [PATCH] v2v: Fix RPM file owned test (RHBZ#1503958).

v1 was here: https://www.redhat.com/archives/libguestfs/2017-October/msg00183.html v2: - Adds back the Debian test, but simplified. - Adds tests on Fedora & Debian. Rich.

What was happening in file_owner function did not match the description in the comment. When a path is owned by multiple packages the returned string was in fact a concatenation of the names of all packages that own it. E.g. for `Linux.is_file_owned g inspect "/etc"` the returned value was "filesystemyum" (i.e. "filesystem" + "yum"). Signed-off-by: Tom??

Implement the 'remove', 'file_list_of_package', and 'file_owner' methods of the Linux module for the "deb" package manager (dpkg basically, on Debian and derived distributions). Also allow it for the main conversion code. --- v2v/convert_linux.ml | 2 +- v2v/linux.ml | 33 +++++++++++++++++++++++++++++++++ 2 files changed, 34 insertions(+), 1

On Mon, 8 Aug 2016 18:38:49 +0200 Pino Toscano <ptoscano@redhat.com> wrote: > Implement the 'remove', 'file_list_of_package', and 'file_owner' methods > of the Linux module for the "deb" package manager (dpkg basically, on > Debian and derived distributions). > > Also allow it for the main conversion code. > --- >

On Wed, 3 Aug 2016 11:14:26 +0100 "Richard W.M. Jones" <rjones@redhat.com> wrote: > On Mon, Aug 01, 2016 at 02:46:14PM +0200, Tomáš Golembiovský wrote: > > What was happening in file_owner function did not match the description > > in the comment. When a path is owned by multiple packages the returned > > string was in fact a concatenation of the names of all

On Tue, 09 Aug 2016 15:24:21 +0200 Pino Toscano <ptoscano@redhat.com> wrote: > On Tuesday, 9 August 2016 13:55:36 CEST Tomáš Golembiovský wrote: > > On Mon, 8 Aug 2016 18:38:49 +0200 > > Pino Toscano <ptoscano@redhat.com> wrote: > > > > > Implement the 'remove', 'file_list_of_package', and 'file_owner' methods > > > of

Hi, this series implements the first bits in v2v to convert Debian/Ubuntu (and derived) guests. The series does not complete the support (see known issues below), but all the patches here should be fit for review and inclusion. The series does not enable the conversion, yet. Known issues: * there is no grubby nor Bootloader::Tools Perl module available in Debian, so there is no way to know

Implement the 'remove', 'file_list_of_package', and 'file_owner' methods of the Linux module for the "deb" package manager (dpkg basically, on Debian and derived distributions). Also allow it for the main conversion code. --- v2v/convert_linux.ml | 2 +- v2v/linux.ml | 23 +++++++++++++++++++++++ 2 files changed, 24 insertions(+), 1 deletion(-) diff

On Tuesday, 9 August 2016 13:55:36 CEST Tomáš Golembiovský wrote: > On Mon, 8 Aug 2016 18:38:49 +0200 > Pino Toscano <ptoscano@redhat.com> wrote: > > > Implement the 'remove', 'file_list_of_package', and 'file_owner' methods > > of the Linux module for the "deb" package manager (dpkg basically, on > > Debian and derived

Hi, this series implements the first bits in v2v to convert Debian/Ubuntu (and derived) guests. The series does not complete the support (see known issues below), but all the patches here should be fit for review and inclusion. The series does not enable the conversion, yet. Known issues: * there is no grubby nor Bootloader::Tools Perl module available in Debian, so there is no way to know

On Mon, Aug 01, 2016 at 02:46:14PM +0200, Tomáš Golembiovský wrote: > What was happening in file_owner function did not match the description > in the comment. When a path is owned by multiple packages the returned > string was in fact a concatenation of the names of all packages that own > it. E.g. for `Linux.is_file_owned g inspect "/etc"` the returned value > was

The Invalid_argument exception is there to catch unexpected situation when rpm returns no output. Such situation should be reported rather then hidden. Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> --- v2v/linux.ml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/v2v/linux.ml b/v2v/linux.ml index e57dad6..46cb3ba 100644 --- a/v2v/linux.ml +++ b/v2v/linux.ml

Don't pass these flags to dozens of functions. --- builder/builder.ml | 47 +++++++++-------- builder/cache.ml | 4 +- builder/cache.mli | 2 +- builder/cmdline.ml | 13 ++--- builder/downloader.ml | 14 +++-- builder/downloader.mli

Add helper functions to get the typical extension of binary packages for a package manager, and the string for an architecture. --- v2v/linux.ml | 21 +++++++++++++++++++++ v2v/linux.mli | 8 ++++++++ 2 files changed, 29 insertions(+) diff --git a/v2v/linux.ml b/v2v/linux.ml index 99b0e0e7b..4949c8e16 100644 --- a/v2v/linux.ml +++ b/v2v/linux.ml @@ -179,3 +179,24 @@ let

.. and a lot of refactoring. https://bugzilla.redhat.com/show_bug.cgi?id=1167623 Rich.

https://bugzilla.redhat.com/show_bug.cgi?id=1167623

This series slightly improves the way qemu-ga is installed from the RHV Tools ISO, simplifying the feedback to the user. Patch #3 sort of conflicts with patch #2 of a related series by Tomáš Golembiovský: https://www.redhat.com/archives/libguestfs/2019-February/msg00016.html Pino Toscano (3): v2v: linux: add helper functions for pkg arch and extension v2v: try to pick the right arch for

Add a Common_utils.debug function for printing messages only when in verbose mode. Rich.

On Tuesday, 6 November 2018 11:44:14 CET Tomáš Golembiovský wrote: > Install packages from local files without touching network. > > Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> > --- In this case, better name it local_install/install_local (or something along these lines) to make it more clear it is not a "classic install". > +and do_install g {

On Fri, Aug 05, 2016 at 11:32:27AM +0200, Tomáš Golembiovský wrote: > The Invalid_argument exception is there to catch unexpected situation > when rpm returns no output. Such situation should be reported rather > then hidden. > > Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> > --- > v2v/linux.ml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)