similar to: [PATCH v2] daemon: proto: Make the guestfsd main loop messages consistent and useful.

If you spend your time looking at libguestfs debugging output you'll see many messages from the daemon main loop like this: guestfsd: main_loop: new request, len 0x54 guestfsd: main_loop: proc 278 (mkfs) took 0.02 seconds I don't think these messages really bring much value. This commit removes them entirely. An alternative might be to change them to make them shorter and/or less

Hello, This is the ouotput for fedora guest. ========================================== *#0 0xb73b7040 in exit () from /lib/libc.so.6* No symbol table info available. *#1 0xb76fb3a8 in main_loop (_sock=_sock@entry=3) at proto.c:112* xdr = {x_op = XDR_DECODE, x_ops = 0xb753db00 <xdrmem_ops>, x_public = 0x0, x_private = 0xbba929d8 ".0", x_base = 0xbba929b0

daemon.c does just a chroot, without chdir. The result is that pwd does not work correctly (it causes fs/dcache.c:prepend_unreachable() to add the unreachable string). A workaround is to add "cd /" before each sh command. ><fs> mount /dev/sda2 / ><fs> sh "cd / ; chroot / ; /bin/pwd" / ><fs> sh "/bin/pwd" (unreachable)/ ><fs> sh

When the COMMAND_FLAG_FOLD_STDOUT_ON_STDERR flag is passed to command*(), indicate that as stdout=e in debugging message. --- daemon/command.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/daemon/command.c b/daemon/command.c index 73fce56..2423a4e 100644 --- a/daemon/command.c +++ b/daemon/command.c @@ -185,6 +185,7 @@ commandrvf (char **stdoutput, char **stderror,

Improve readability of commandrvf() by replacing bare int values for file descriptors with their symbolic names STD{IN,OUT,ERR}_FILENO. Also add PIPE_READ and PIPE_WRITE for referencing relevant ends of a pipe. --- daemon/guestfsd.c | 79 +++++++++++++++++++++++++++++-------------------------- 1 file changed, 42 insertions(+), 37 deletions(-) diff --git a/daemon/guestfsd.c b/daemon/guestfsd.c

Useful for tracking down segfaults in the daemon. This is not upstreamable right now. Example usage: $ ./run guestfish -v -x -a /dev/null run : debug segv "" [...] libguestfs: trace: launch = 0 libguestfs: trace: debug "segv" "" guestfsd: main_loop: new request, len 0x34 Program received signal SIGSEGV, Segmentation fault. debug_segv (subcmd=0x4687050

[This email is either empty or too large to be displayed at this time]

Hi, On Wed, November 16, 2016 11:10 am, Richard W.M. Jones wrote: > >> It eventually did complete, after several hours. But I don't understand >> why this particular VM took so long when others (with similar disk >> sizes/usages/configurations) completed in only 1-2 minutes. Each VM is >> effectively exactly the same (it's a build slave), so it's just the

Hello, So in ubuntu1204 guest This is what i got : *(gdb)* bt full * #0* 0x005a9fc0 in exit () from /lib/i386-linux-gnu/libc.so.6 No symbol table info available. * #1* 0x0805f7dd in ?? () No symbol table info available. * #2* 0x0804aedf in ?? () No symbol table info available. *#3* 0x005904d3 in __libc_start_main () from /lib/i386-linux-gnu/libc.so.6 No symbol

On Tue, Feb 14, 2023 at 08:02:59PM +0200, Yonatan Shtarkman wrote: > The attached code snippet?reproduces the issue when running: > python3 libugestfs_segfault_repro.py > > With: > guestfs version: 1.48.6 > guestfs-python version: 1.48.6 Can confirm with {python3-,}libguestfs-1.51.1-1.fc39.x86_64 The stack trace is roughly the same as yours. Rich. > Stacktrace: > #0

On Sun, Aug 18, 2013 at 02:29:15PM +0200, Olaf Hering wrote: > > daemon.c does just a chroot, without chdir. The result is that pwd does not > work correctly (it causes fs/dcache.c:prepend_unreachable() to add the > unreachable string). A workaround is to add "cd /" before each sh command. > > ><fs> mount /dev/sda2 / > ><fs> sh "cd / ; chroot

Simple shortcut to easily cleanup a stringsbuf. --- daemon/daemon.h | 1 + daemon/guestfsd.c | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/daemon/daemon.h b/daemon/daemon.h index 53cb797..bed4dbc 100644 --- a/daemon/daemon.h +++ b/daemon/daemon.h @@ -92,6 +92,7 @@ extern int add_string (struct stringsbuf *sb, const char *str); extern int add_sprintf (struct stringsbuf *sb, const

08.10.2017, 08:09, "Richard W.M. Jones" <rjones@redhat.com>: > However virt-v2v has its own parser for libvirt XML and only parses a > (very) small subset of these fields. Generally you only need to take > that template and change a few fields, name, memory size, number of > vCPUs, and make sure there is one <disk> section per disk and one > <interface>

Use commandrvf() instead of commandvf() to execute e2fsck. A non-zero exit status does not always indicate a failure. Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr> --- daemon/ext2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/daemon/ext2.c b/daemon/ext2.c index 65ddae6..8ef6d5f 100644 --- a/daemon/ext2.c +++ b/daemon/ext2.c @@ -296,9 +296,9 @@ do_e2fsck

Hi Rich, On Wed, November 16, 2016 1:34 pm, Richard W.M. Jones wrote: > On Wed, Nov 16, 2016 at 11:31:40AM -0500, Derek Atkins wrote: >> > Running `virt-v2v -v -x ...' and observing the output will give you a >> > good idea of what precisely it was doing for those hours. >> >> Well, as I said in my original email, it was hanging at running >> setfiles:

The yara_load API allows to load a set of Yara rules contained within a file on the host. Rules can be in binary format, as when compiled with yarac command, or in source code format. In the latter case, the rules will be first compiled and then loaded. Subsequent calls of the yara_load API will result in the discard of the previously loaded rules. Signed-off-by: Matteo Cafasso

Hi, &nbsp; &nbsp; I have use&nbsp; kvm ? virsh ? virt&nbsp; &nbsp;for almost half year ?all things goes well ? &nbsp; &nbsp; but recently? I use virt-copy-in&nbsp; found some problem ? I&nbsp; have&nbsp; &nbsp;do&nbsp; nothing&nbsp; with my server&nbsp; ?but the problem appear .&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;

Hi,Tomas: &nbsp; &nbsp; &nbsp;here is the&nbsp; test info:&nbsp; &nbsp;Thanks for your kind help .&nbsp; &nbsp; &nbsp;************************************************************ &nbsp; &nbsp; &nbsp;*&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; IMPORTANT NOTICE &nbsp; &nbsp;

- add a flag to request chroot for the process, which is done only as very last (before chdir) operation before exec'ing the process in the child: this avoids using CHROOT_IN & CHROOT_OUT around command* invocations, and reduces the code spent in chroot mode - add failure checks for dup2 and open done in child, not proceeding to executing the process if they fail - open /dev/null

When running commands in the mounted guest (using the "command" API, and APIs based on it), provide the /dev/null from the appliance as open fd for stdin. Commands usually assume stdin is open if they didn't close it explicitly, so this should avoid crashes or misbehavings due to that. --- daemon/command.c | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-)