similar to: [PATCH] common/mlutils: fix f_type comparisons

On Tuesday, 3 October 2017 14:24:14 CEST Richard W.M. Jones wrote: > --- > builder/builder.ml | 84 +++++++++++++++++++++++++++++++++---------- Cannot comment on the actual logic in the planner, since I admit I did not have an in-depth look at it. > diff --git a/common/mlutils/unix_utils-c.c b/common/mlutils/unix_utils-c.c > index 657852ef2..340fdec44 100644 > ---

On Wed, Oct 04, 2017 at 03:20:53PM +0200, Pino Toscano wrote: > > + return Val_bool (buf.f_type == 0xff534d42 /* CIFS_MAGIC_NUMBER */ || > > + buf.f_type == 0x6969 /* NFS_SUPER_MAGIC */ || > > + buf.f_type == 0x517b /* SMB_SUPER_MAGIC */); > > Using linux/magic.h + the constants from it should avoid the hardcoded > numbers, and

Hi, I had following errors while I was compiling VLC 1.0.2 on CentOS 5.2: modules/access/file.c:52:28: error: linux/magic.h: No such file or directory ../../../modules/access/file.c: In function ?IsRemote?: ../../../modules/access/file.c:141: error: ?AFS_SUPER_MAGIC? undeclared (first use in this function) ../../../modules/access/file.c:141: error: (Each undeclared identifier is reported only

It started out as "this'll be just a simple fix ..." and turned into something a bit over-engineered in the end. Here it is anyway. Rich.

--- builder/builder.ml | 84 +++++++++++++++++++++++++++++++++---------- common/mlutils/unix_utils-c.c | 27 ++++++++++++++ common/mlutils/unix_utils.ml | 3 ++ common/mlutils/unix_utils.mli | 4 +++ m4/guestfs_libraries.m4 | 1 + 5 files changed, 100 insertions(+), 19 deletions(-) diff --git a/builder/builder.ml b/builder/builder.ml index d8e625f68..fd19aa7d9 100644 ---

v1 -> v2: - Removed the f_type field from StatVFS.statvfs structure. - New function StatVFS.filesystem_is_remote, written in C. [Thinking about it, this should probably be called ?is_network_filesystem?, but I can change that before pushing]. - Use statvfs instead of fstatvfs, and statfs instead of fstatfs. - Rejigged the comments in builder/builder.ml to make them simpler

v2 -> v3: - Drop gnulib fallback.

--- mlutils/unix_utils-c.c | 15 +++++++++++++++ mlutils/unix_utils.ml | 5 +++++ mlutils/unix_utils.mli | 9 +++++++++ 3 files changed, 29 insertions(+) diff --git a/mlutils/unix_utils-c.c b/mlutils/unix_utils-c.c index 3309961..8acf039 100644 --- a/mlutils/unix_utils-c.c +++ b/mlutils/unix_utils-c.c @@ -77,6 +77,7 @@ extern value guestfs_int_mllib_mkdtemp (value val_pattern); extern value

On Thursday, 15 June 2017 19:06:00 CEST Richard W.M. Jones wrote: > Create a module ‘C_utils’ containing functions like ‘drive_name’ and > ‘shell_unquote’ which come from the C utilities. > > The new directory ‘common/mlutils’ also contains the ‘Unix_utils’ > wrappers around POSIX functions missing from the OCaml stdlib. > --- I fear we are spreading the code among too many

Followup/fix of commit 61d4891ef48df171a27873efe90aab51a9b711ef. --- builder/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/Makefile.am b/builder/Makefile.am index 09ae4ae..e64c899 100644 --- a/builder/Makefile.am +++ b/builder/Makefile.am @@ -311,7 +311,7 @@ depend: .depend .depend: $(wildcard $(abs_srcdir)/*.mli) $(wildcard $(abs_srcdir)/*.ml) rm -f

Create a module ‘C_utils’ containing functions like ‘drive_name’ and ‘shell_unquote’ which come from the C utilities. The new directory ‘common/mlutils’ also contains the ‘Unix_utils’ wrappers around POSIX functions missing from the OCaml stdlib. --- .gitignore | 3 + Makefile.am | 24 ++--- builder/Makefile.am

The C function mkdtemp(3) requires that the string ends with 6 'X' characters, so appending a non-empty suffix causes the function to raise EINVAL. Luckily we only ever called this function with the last parameter "". --- builder/builder.ml | 2 +- builder/sigchecker.ml | 2 +- common/mlutils/unix_utils.ml | 4 ++--

This patch series copies the core of the tapdisk process from blktap2, with updates coming from blktap2.5. Signed-off-by: Thanos Makatos <thanos.makatos@citrix.com>

pod-arg-check.pl is run as part of the tests to ensure the documentation matches the options that the tool implements and vice versa. This commit includes scripts to run the tests and various fixes to the manual pages to ensure that the tests pass. --- cat/Makefile.am | 5 +- cat/test-docs.sh | 26 ++++++++ cat/virt-cat.pod | 4 +- cat/virt-ls.pod | 4 +-

qemu-wrapper isn't regenerated if QEMUDIR is changed, so just delete it and force regeneration. Additionally we can drop the silent binary check, since check-with-upstream-qemu-1 already does a similar test with --version that will actually report an error to the user. --- Makefile.am | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Makefile.am b/Makefile.am index

This was an older patch that had to be rebased against the current tip.

This includes a missed break and two spots where $ADDRESS was copied as $address instead.

config vector setup is version specific, do it indirectly. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_pci.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c index 68023e5..c8ca3f7 100644 --- a/drivers/virtio/virtio_pci.c +++ b/drivers/virtio/virtio_pci.c @@

config vector setup is version specific, do it indirectly. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_pci.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c index 68023e5..c8ca3f7 100644 --- a/drivers/virtio/virtio_pci.c +++ b/drivers/virtio/virtio_pci.c @@

From: Joerg Roedel <jroedel at suse.de> Move the assembly coded dispatch between page-faults and all other exceptions to C code to make it easier to maintain and extend. Signed-off-by: Joerg Roedel <jroedel at suse.de> --- arch/x86/kernel/head64.c | 20 ++++++++++++++++++++ arch/x86/kernel/head_64.S | 11 +---------- 2 files changed, 21 insertions(+), 10 deletions(-) diff --git