similar to: [PATCH] build: improve and simplify distro detection

Use /etc/os-release as first option, translating the distro name to the current identifier used. The other options (the release files) are left as following checks, avoiding them if any matches. --- m4/guestfs_appliance.m4 | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/m4/guestfs_appliance.m4 b/m4/guestfs_appliance.m4 index 8cff51e..b48da74 100644

On Thu, 2017-07-20 at 17:01 +0200, Pino Toscano wrote: > On Thursday, 20 July 2017 16:21:40 CEST Cédric Bosdonnat wrote: > > In the appliance used to build the packages for openSUSE, os-release > > is super minimal and only had ID_LIKE=suse. The code setting the > > DISTRO variable only searches for ID variable so far, resulting in > > invalid packagelist on openSUSE.

All SUSE distros have a ID_LIKE=suse, including the fake one used for building that has a ID=Dummy value. Without reading ID_LIKE on SUSE distros, the generated appliance packagelist is not correct. This fix reads ID_LIKE as a fallback if ID contains nothing. --- m4/guestfs_appliance.m4 | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/m4/guestfs_appliance.m4

On Fri, 2017-09-01 at 10:59 +0100, Daniel P. Berrange wrote: > On Fri, Sep 01, 2017 at 11:25:17AM +0200, Cédric Bosdonnat wrote: > > All SUSE distros have a ID_LIKE=suse, including the fake one used > > for building that has a ID=Dummy value. Without reading ID_LIKE > > on SUSE distros, the generated appliance packagelist is not correct. > > > > This fix reads

On Thursday, 20 July 2017 16:21:40 CEST Cédric Bosdonnat wrote: > In the appliance used to build the packages for openSUSE, os-release > is super minimal and only had ID_LIKE=suse. The code setting the > DISTRO variable only searches for ID variable so far, resulting in > invalid packagelist on openSUSE. > > This fix reads ID_LIKE as a fallback if ID contains nothing. > ---

In the appliance used to build the packages for openSUSE, os-release is super minimal and only had ID_LIKE=suse. The code setting the DISTRO variable only searches for ID variable so far, resulting in invalid packagelist on openSUSE. This fix reads ID_LIKE as a fallback if ID contains nothing. --- m4/guestfs_appliance.m4 | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

On Fri, Sep 01, 2017 at 11:25:17AM +0200, Cédric Bosdonnat wrote: > All SUSE distros have a ID_LIKE=suse, including the fake one used > for building that has a ID=Dummy value. Without reading ID_LIKE > on SUSE distros, the generated appliance packagelist is not correct. > > This fix reads ID_LIKE as a fallback if ID contains nothing. > --- > m4/guestfs_appliance.m4 | 10

Two (not related to each other) refactorings: Patches 1-12 split configure.ac into smaller files using the m4_include mechanism. Patches 13-15 split out parts of guestfs.pod (ie. guestfs(3)) into three new manual pages: guestfs-hacking(3) - how to extend and contribute to libguestfs guestfs-internals(3) - architecture and internals guestfs-security(3) - security and CVEs Patch 16 is a

The latter is a better way to disable the qemu display output as we need to, without enabling extra devices (which are disabled already, anyway). Also, related to the change above, ban the -display parameter from the ones that can be supplied by the user. --- configure.ac | 8 ++++---- src/launch-direct.c | 12 ++++++++---- src/launch.c | 1 + 3 files changed, 13 insertions(+), 8

The test for febootstrap-to-initramfs' --nocompress option was always failing for me on F11. Here's why: $ bash ~/w/co/libguestfs:210-comment-fix $ t=`febootstrap-to-initramfs 2>&1` [Exit 1] $ if ! echo $t|grep -sq -- --nocompress; then echo not found; fi not found Notice: without quotes, the [--nocompress] term expands to "k",

qemu has supported virtio-serial since forever, and we depend on much newer features now, so testing for virtio-serial is pointless. In fact allowing a set of possible qemu binaries to be supplied is also pointless, since packagers or even people building from source know what qemu binary they want to use. Now the possible options for --with-qemu are: * --with-qemu=search (or --with-qemu

Support the ID found in openSUSE Leap 15.0 in addition to the other SUSE-related IDs. While there is already --with-distro=ID to force the ID without using os-release, this makes it possible to build OOTB. --- m4/guestfs-appliance.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/guestfs-appliance.m4 b/m4/guestfs-appliance.m4 index 5c2bc3e8d..bcba4c1a1 100644 ---

It seems that all the newer versions of openSUSE have an 'opensuse-' prefix in their distro ID; hence, check for that prefix at once, keeping compatibility for the old "opensuse" ID. Followup of commit a4e53bcbc52594f8863e7866448640f7ac8ab0f9. --- m4/guestfs-appliance.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/guestfs-appliance.m4

--- configure.ac | 2 +- golang/Makefile.am | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 4e2bc65..9abec95 100644 --- a/configure.ac +++ b/configure.ac @@ -1530,7 +1530,7 @@ AS_IF([test "x$enable_golang" != "xno"],[ AC_CHECK_PROG([GOLANG],[go],[go],[no]) AS_IF([test "x$GOLANG" !=

This commit starts to split our massive, monolithic configure.ac file into smaller files, using the m4_include mechanism to combine them. I don't know if we should really do this, so I'm open to comments about it. However: - Our configure.ac script is 1800+ lines long, and that's pretty long. - configure.ac lacks structure; splitting it up might improve that. - From what I read,

Without this option, configure will fail when there is no display. Signed-off-by: Masami HIRATA <msmhrt at gmail.com> --- configure.ac | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index de8a064..61d6f69 100644 --- a/configure.ac +++ b/configure.ac @@ -593,16 +593,16 @@ working. AC_MSG_FAILURE([$QEMU version must be >=

Hi, this small series cherry-picks a couple of the portability fixes recently done in libguestfs to hivex. There should be no actual change on Linux. Thanks, -- Pino Pino Toscano (2): normalize iconv handling ruby: fix detection of ruby library bootstrap | 1 + configure.ac | 8 +++++++- lib/utf16.c | 3 +-- 3 files changed, 9 insertions(+), 3 deletions(-) -- 1.9.3

These three patches ought to fix configure script detection of Ruby, especially on Debian where the Ruby C extensions library can be something like '-lruby1.8'. Rich.

Add sort of "headers" to split most of the logical sections of the configure, so it is easier to get feedback on the progress of configure. --- configure.ac | 46 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+) diff --git a/configure.ac b/configure.ac index 7f9c1dac0..5ccf6f821 100644 --- a/configure.ac +++ b/configure.ac @@ -76,11 +76,15 @@

Brought to you by the "I haven't rebuilt the libguestfs universe in a while" saga -- now with working test suite. Pino Toscano (5): build: remove extra gnulib submodule build: remove extra checks and submodules build: stop using gnulib in test-harness build: remove unused gnulib modules Remove extra entries from podfiles .gitmodules | 3 -- Makefile.am