similar to: [PATCH] s390x: tests: regressions: Skip IDE tests on S/390.

When possible, make the disk image format explicit when invoking tools or using add-drive. This avoids warnings from qemu about the unspecified format for the image, and also makes qemu slightly faster (skipping the disk image probing). Tests checking the image probing are not touched. This changes also: - old-style invocations of tools (`$tool $filename`) into new style (`$tool -a $filename`)

-o rhv-upload requires nbdkit, so skip this test if it is not installed. --- v2v/test-v2v-o-rhv-upload.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/v2v/test-v2v-o-rhv-upload.sh b/v2v/test-v2v-o-rhv-upload.sh index 8bda7cc0b..29214a9db 100755 --- a/v2v/test-v2v-o-rhv-upload.sh +++ b/v2v/test-v2v-o-rhv-upload.sh @@ -28,6 +28,7 @@ set -x $TEST_FUNCTIONS skip_if_skipped skip_if_backend

-o rhv-upload requires python3, and nbdkit with the python3 plugin, so skip this test if they are not installed. --- v1 is: https://www.redhat.com/archives/libguestfs/2018-October/msg00008.html v2v/test-v2v-o-rhv-upload.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/v2v/test-v2v-o-rhv-upload.sh b/v2v/test-v2v-o-rhv-upload.sh index 8bda7cc0b..23d2ad7a0 100755 ---

On Mon, Oct 01, 2018 at 01:47:06PM +0200, Pino Toscano wrote: > -o rhv-upload requires nbdkit, so skip this test if it is not installed. > --- > v2v/test-v2v-o-rhv-upload.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/v2v/test-v2v-o-rhv-upload.sh b/v2v/test-v2v-o-rhv-upload.sh > index 8bda7cc0b..29214a9db 100755 > --- a/v2v/test-v2v-o-rhv-upload.sh > +++

On Mon, Oct 01, 2018 at 04:40:19PM +0200, Pino Toscano wrote: > -o rhv-upload requires python3, and nbdkit with the python3 plugin, so > skip this test if they are not installed. > --- > > v1 is: > https://www.redhat.com/archives/libguestfs/2018-October/msg00008.html > > v2v/test-v2v-o-rhv-upload.sh | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Hi, small series with small improvements to the tests. Pino Toscano (3): tests: specify the image format when possible tests: remove remaining relative paths to binaries fish: generate test-prep.sh with generator .gitignore | 1 + align/test-virt-alignment-scan.sh | 2 +- cat/Makefile.am | 2 +- cat/test-virt-cat.sh

It's not our job to worry about downstream packaging issues ... --- generator/tests.ml | 1 - tests/regressions/Makefile.am | 3 +- tests/regressions/test-noexec-stack.pl | 78 ---------------------------------- tests/regressions/tests.mk | 3 +- 4 files changed, 2 insertions(+), 83 deletions(-) delete mode 100755

It's not our job to worry about downstream packaging issues ... --- generator/tests.ml | 1 - tests/regressions/Makefile.am | 3 +- tests/regressions/test-noexec-stack.pl | 78 ---------------------------------- tests/regressions/tests.mk | 3 +- 4 files changed, 2 insertions(+), 83 deletions(-) delete mode 100755

Some of the libvirt XMLs for tests refer to a generated phony disk image, and so far the relative path used worked almost by chance. (For each disk, the path to it was ../test-data/etc, and since the overlay pointing to it is stored directly in $LIBGUESTFS_CACHEDIR, which is $buildir/tmp, then the relative path was resolved.) Instead, have configure place the right top-level directory in those

Instead of using the "global" blank-part test image, use a local version of it created with guestfish. --- p2v/.gitignore | 1 + p2v/Makefile.am | 7 ++++++- p2v/test-virt-p2v-nbdkit.sh | 4 ++-- p2v/test-virt-p2v.sh | 4 ++-- 4 files changed, 11 insertions(+), 5 deletions(-) diff --git a/p2v/.gitignore b/p2v/.gitignore index 673e8ad83..8495f6c2f 100644

Test: - Bad SHA1 sum - Bad SHA256 sum - Invalid lines in manifest (x2) - Good checksum and manifest These tests were originally written by Tomáš Golembiovský. All I have done is to integrate them into the virt-v2v test suite. --- .gitignore | 1 + v2v/Makefile.am | 22 +++++++- v2v/test-v2v-i-ova-bad-sha1.sh | 66

We don't support RHEL 5 upstream (see the 'oldlinux' branch for a version that works with RHEL 5). Therefore remove a bunch of hacks that were only needed on RHEL 5. --- appliance/packagelist.in | 2 - common-rules.mk | 8 - daemon/parted.c | 455 +++++++++++----------------------------- daemon/swap.c | 18 +-

Since Linux commit f663b5b38fff trimming vfat is now supported by Linux. This broke the test which assumed it was not supported. Use another filesystem (minix) which does not support trimming instead. Thanks: Daniel P. Berrangé and Pino Toscano. --- ...est-virt-sparsify-in-place-fstrim-unsupported.sh | 13 ++++++------- tests/test-functions.sh | 10 ++++++++++ 2

With recent nbdkit the skip test fails the rhv-upload test skip: $ nbdkit python3 --version nbdkit: error: cannot open plugin 'python3': /usr/local/lib/nbdkit/plugins/nbdkit-python3-plugin.so: cannot open shared object file: No such file or directory It seems that the python plugin is always installed as nbdkit-python-plugin.so, so the correct test now is: nbdkit

Add the configure result in config.sh, so it can be used as variable. --- config.sh.in | 2 ++ tests/test-v2v-o-rhv-upload.sh | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/config.sh.in b/config.sh.in index 061871a3..f3245379 100644 --- a/config.sh.in +++ b/config.sh.in @@ -18,3 +18,5 @@ # This shell script contains the results of some configure checks,

Previously I posted a work-in-progress preview of this patch series: https://www.redhat.com/archives/libguestfs/2017-February/msg00224.html This is the finished version that updates all of the shell-script based tests. It passes 'make check', 'make check-direct' and 'make check-slow'. Rich.

On Thursday, May 16, 2019 11:08:23 AM CEST Pino Toscano wrote: > Followup of commit f190e08d85556dac293ef15bfeee38e54471570f. > --- > v2v/Makefile.am | 2 ++ > v2v/test-v2v-o-json.sh | 58 ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 60 insertions(+) > create mode 100755 v2v/test-v2v-o-json.sh > > diff --git a/v2v/Makefile.am b/v2v/Makefile.am

Followup of commit f190e08d85556dac293ef15bfeee38e54471570f. --- v2v/Makefile.am | 2 ++ v2v/test-v2v-o-json.sh | 58 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 60 insertions(+) create mode 100755 v2v/test-v2v-o-json.sh diff --git a/v2v/Makefile.am b/v2v/Makefile.am index 39511022e..1c37d20b4 100644 --- a/v2v/Makefile.am +++ b/v2v/Makefile.am @@ -468,6 +468,7 @@ TESTS

Test case adapted from Hu Zhang's RHBZ#1242853, thanks. --- tests/regressions/Makefile.am | 2 + tests/regressions/rhbz1011907-1165785.sh | 66 ++++++++++++++++++++++++++++++++ 2 files changed, 68 insertions(+) create mode 100755 tests/regressions/rhbz1011907-1165785.sh diff --git a/tests/regressions/Makefile.am b/tests/regressions/Makefile.am index c4f60ae..026987b 100644 ---

Previously this output method was almost completely untested. This commit adds a fake ovirtsdk4 module so we can test the -o rhv-upload method fairly completely without needing an actual oVirt instance around. --- v2v/Makefile.am | 4 + .../ovirtsdk4/__init__.py | 146 ++++++++++++++++++ .../ovirtsdk4/types.py | 125