similar to: [PATCH v2] inspector: validate resulting XML files

Run xmllint to validate the XML output files of virt-inspector, so the schema is checked against actual output of virt-inspector. --- inspector/test-virt-inspector.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/inspector/test-virt-inspector.sh b/inspector/test-virt-inspector.sh index 2f55cdc..33d749c 100755 --- a/inspector/test-virt-inspector.sh +++ b/inspector/test-virt-inspector.sh @@

Add a single shell script to hold results of configure. Pino Toscano (2): build: add an empty config.sh tests: switch to config.sh for xmllint .gitignore | 4 +--- config.sh.in | 22 +++++++++++++++++++ configure.ac | 7 +----- ...luks.sh.in => test-virt-inspector-luks.sh} | 2 +-

Instead of generating test scripts from configure with the path of xmllint, export that path in config.sh, so the tests can be static scripts again. --- .gitignore | 3 --- config.sh.in | 2 ++ configure.ac | 6 ------ ...irt-inspector-luks.sh.in =>

This is my proposed alternative to the complicated test framework (https://www.redhat.com/archives/libguestfs/2015-August/msg00022.html). In this patch, when we want to run tests on installed packages we just copy in the installed binaries over the source directory, and run the test suite as normal. This is basically the same as the current (not used) contrib/make-check-on-installed.pl script,

v2: - Changes as suggested by Pino in previous review.

[This email is either empty or too large to be displayed at this time]

Hi, thanks for your response. Based from your advice I try to check the XML used the command "xmllint --noout /etc/icecast2/icecast.xml" . Because I got response "xmllint: command not found", I installed xmllint (sudo apt-get install libxml2-utils). After that, I check again (xmllint --noout /etc/icecast2/icecast.xml) and the result just return to the prompt (which means XML

Here's what I needed to build and run 1.20 on Debian/unstable. Perhaps the libcap2 dependency in the packagelist should only be added if libcap has actually been used in building guestfsd...

This has got to the stage where it actually works, both for running the tests in-tree and installed. The 'test-harness' script has become rather over-complex in the process however. Rich.

Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr> --- .gitignore | 1 + inspector/Makefile.am | 1 + inspector/expected-coreos.img.xml | 30 +++++++++++ tests/guests/Makefile.am | 6 +++ tests/guests/guest-aux/make-coreos-img.sh | 83 +++++++++++++++++++++++++++++++ tests/guests/guests.xml.in | 16

--- daemon/Makefile.am | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index e23ce86..af075d7 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -42,10 +42,10 @@ noinst_LIBRARIES = libprotocol.a libprotocol_a_SOURCES = guestfs_protocol.c guestfs_protocol.h libprotocol_a_CFLAGS = -Wall -Wno-unused -fno-strict-aliasing

Hi guys, I try to compile the libvirt-php but no luck, below are the output i got.. webserver:~/libvirt-php-0.4.3 # ./configure checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for a thread-safe mkdir -p... /bin/mkdir -p checking for gawk... gawk checking whether make sets $(MAKE)... yes checking for style of include used by

Fix one dist issue, and various builddir!=srcdir issues, also with the patch proposed in the Debian bug #946594. Patch #3 applies also to the virt-v2v repository, and will be committed there too (with references to the libguestfs commit). Pino Toscano (3): inspector: ship the actual test script tests: fix srcdir references build: fix make implicit dependencies on ml/mli files

-- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top

OPENSUSE 13.2 GNOME 3.14 ./configure make make check #Making check in m4 make[1]: Entering directory '/tmp/tinc-1.0.25/m4' make[1]: Nothing to be done for 'check'. make[1]: Leaving directory '/tmp/tinc-1.0.25/m4' Making check in src make[1]: Entering directory '/tmp/tinc-1.0.25/src' make[1]: Nothing to be done for 'check'. make[1]: Leaving directory

--- inspector/inspector.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/inspector/inspector.c b/inspector/inspector.c index 3583c61df..30d279987 100644 --- a/inspector/inspector.c +++ b/inspector/inspector.c @@ -347,6 +347,7 @@ output_root (xmlTextWriterPtr xo, char *root) char buf[32]; char *canonical_root; size_t size; + int is_bsd; XMLERROR

On Thu, Oct 05, 2017 at 06:55:53PM +0200, Pino Toscano wrote: > On Thursday, 5 October 2017 17:36:09 CEST Richard W.M. Jones wrote: > > --- > > inspector/inspector.c | 12 +++++++++++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > diff --git a/inspector/inspector.c b/inspector/inspector.c > > index 3583c61df..30d279987 100644 > > ---

This is a partial fix for https://bugzilla.redhat.com/show_bug.cgi?id=526717 Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://et.redhat.com/~rjones/libguestfs/ See what it can do: http://et.redhat.com/~rjones/libguestfs/recipes.html -------------- next

--- inspector/virt-inspector.pod | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/inspector/virt-inspector.pod b/inspector/virt-inspector.pod index f8744b1..1282608 100644 --- a/inspector/virt-inspector.pod +++ b/inspector/virt-inspector.pod @@ -68,6 +68,12 @@ them with separate I<-a> options. The format of the disk image is auto-detected. To override this and force a particular

--- inspector/test-virt-inspector.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inspector/test-virt-inspector.sh b/inspector/test-virt-inspector.sh index 86d70a8..02bbcad 100755 --- a/inspector/test-virt-inspector.sh +++ b/inspector/test-virt-inspector.sh @@ -29,7 +29,7 @@ fi # ntfs-3g can't set UUIDs right now, so ignore just that <uuid>. diff_ignore="-I