similar to: Re: [PATCH] appliance: more reliable check for the supermin appliance

Eric, what do you think of Pavel's analysis and/or suggested fix below? It seems all too plausible to me unfortunately :-( On Fri, May 05, 2017 at 03:46:45PM +0300, Pavel Butsykin wrote: > On 05.05.2017 12:27, Richard W.M. Jones wrote: > > > >Looks good. I'll push this if it passes 'make check && make check-valgrind' > >which I'm currently

On Tue, Apr 25, 2017 at 02:35:26PM +0300, Pavel Butsykin wrote: > The patch changes the order of the steps to search for fixed/supermin > appliance in accordance with documentation: > > "If the fixed appliance is found, libguestfs skips supermin entirely > and just runs qemu with the kernel, initrd and root disk from the > fixed appliance." Does anyone rely on the

On Thu, May 04, 2017 at 02:20:28PM +0300, Pavel Butsykin wrote: > This patch changes appliance search using paths with multiple directories. Now > all appliance checks will be done separately for each directory. For example > if the path LIBGUESTFS_PATH=/a:/b:/c, then all applainces are searched first in > /a, then in /b and then in /c. It allows to flexibly configure the libguestfs

This is largely code motion. --- src/appliance.c | 40 +++++++----------------------------- src/guestfs-internal.h | 1 + src/tmpdirs.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 63 insertions(+), 33 deletions(-) diff --git a/src/appliance.c b/src/appliance.c index 2cf6374..d293c2b 100644 --- a/src/appliance.c +++ b/src/appliance.c @@ -48,7 +48,7

On Tue, Apr 25, 2017 at 06:13:37PM +0300, Pavel Butsykin wrote: > On 25.04.2017 16:04, Richard W.M. Jones wrote: > >Can you see what: > > > > guestfish get-path > > /usr/lib64/guestfs > > >prints? Are you setting LIBGUESTFS_PATH at all? > > > > No. > > # ls /usr/lib64/guestfs > initrd kernel README.fixed root supermin.d > >

On Thu, Apr 27, 2017 at 03:54:44PM +0300, Pavel Butsykin wrote: [...] > >(2) If the fixed appliance was located somewhere else, you could do: > > > > LIBGUESTFS_PATH=/path/to/somewhere/else:/usr/lib64/guestfs > > export LIBGUESTFS_PATH > > > >and then it would look for the fixed appliance in > >/path/to/somewhere/else and use it. If the fixed

On Fri, Jun 23, 2017 at 04:12:35PM +0300, Pavel Butsykin wrote: > This feature allows you to use different image formats for the fixed > appliance. The raw format is used by default. > > Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com> > --- > lib/create.c | 5 +++-- > lib/guestfs-internal.h | 2 ++ > lib/launch-direct.c | 2 ++ >

On Fri, Jun 23, 2017 at 04:12:36PM +0300, Pavel Butsykin wrote: > Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com> > --- > m4/guestfs_appliance.m4 | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/m4/guestfs_appliance.m4 b/m4/guestfs_appliance.m4 > index 81c43879f..7e8d28271 100644 > --- a/m4/guestfs_appliance.m4 > +++

GCC has two warnings related to large stack frames. We were already using the -Wframe-larger-than warning, but this reduces the threshold from 10000 to 5000 bytes. However that warning only covers the static part of frames (not alloca). So this change also enables -Wstack-usage=10000 which covers both the static and dynamic usage (alloca and variable length arrays). Multiple changes are made

On Wed, Nov 02, 2016 at 09:50:20PM +0300, Pavel Butsykin wrote: > On 02.11.2016 18:01, Richard W.M. Jones wrote: > >From: Pavel Butsykin <pbutsykin@virtuozzo.com> > > > >This patch improves the search of grub config on EFI partition. This > >means that the config will be found not only for rhel but also for > >many other distributions. Tests were performed

On Tue, Jun 27, 2017 at 07:42:20PM +0300, Pavel Butsykin wrote: > This feature allows you to use different image formats for the fixed > appliance. The raw format is used by default. I wonder if you're stil using this feature? Unfortunately because of a recent change in libvirt it is no longer possible to have a backing file where libvirt will autodetect the format. See:

From: Pavel Butsykin <pbutsykin@virtuozzo.com> This patch improves the search of grub config on EFI partition. This means that the config will be found not only for rhel but also for many other distributions. Tests were performed on the following distributions: centos, fedora, ubuntu, suse. In all cases, the config path was /boot/efi/EFI/*distname*/grub.cfg The main purpose of the patch

From: Pavel Butsykin <pbutsykin@virtuozzo.com> This patch improves the search of grub config on EFI partition. This means that the config will be found not only for rhel but also for many other distributions. Tests were performed on the following distributions: centos, fedora, ubuntu, suse. In all cases, the config path was /boot/efi/EFI/*distname*/grub.cfg The main purpose of the patch

On Tuesday, 1 November 2016 17:07:04 CET Richard W.M. Jones wrote: > From: Pavel Butsykin <pbutsykin@virtuozzo.com> > > This patch improves the search of grub config on EFI partition. This > means that the config will be found not only for rhel but also for > many other distributions. Tests were performed on the following > distributions: centos, fedora, ubuntu, suse. In

On Wednesday, 2 November 2016 15:01:08 CET Richard W.M. Jones wrote: > From: Pavel Butsykin <pbutsykin@virtuozzo.com> > > This patch improves the search of grub config on EFI partition. This > means that the config will be found not only for rhel but also for > many other distributions. Tests were performed on the following > distributions: centos, fedora, ubuntu, suse.

From: Pavel Butsykin <pbutsykin@virtuozzo.com> This patch improves the search of grub config on EFI partition. This means that the config will be found not only for rhel but also for many other distributions. Tests were performed on the following distributions: centos, fedora, ubuntu, suse. In all cases, the config path was /boot/efi/EFI/*distname*/grub.cfg The main purpose of the patch

On Tuesday, 7 April 2020 14:59:11 CEST Tomáš Golembiovský wrote: > On Tue, Apr 07, 2020 at 02:33:20PM +0200, Pino Toscano wrote: > > On Tuesday, 7 April 2020 14:18:47 CEST Richard W.M. Jones wrote: > > > On Tue, Apr 07, 2020 at 01:25:02PM +0200, Pino Toscano wrote: > > > > The important thing is still that that you need to have space for the > > > >

On Tue, Apr 25, 2017 at 03:58:45PM +0300, Pavel Butsykin wrote: > On 25.04.2017 15:11, Richard W.M. Jones wrote: > >On Tue, Apr 25, 2017 at 02:35:26PM +0300, Pavel Butsykin wrote: > >>The patch changes the order of the steps to search for fixed/supermin > >>appliance in accordance with documentation: > >> > >>"If the fixed appliance is found,

On Tue, Jun 20, 2017 at 06:48:16PM +0300, Pavel Butsykin wrote: > On 20.06.2017 18:41, Richard W.M. Jones wrote: > >On Tue, Jun 20, 2017 at 06:34:28PM +0300, Pavel Butsykin wrote: > >>On 20.06.2017 17:47, Richard W.M. Jones wrote: > >>>On Tue, Jun 20, 2017 at 05:04:53PM +0300, Pavel Butsykin wrote: > >>>>I noticed that raw is intentionally used as image

On Sat, Jun 11, 2016 at 08:51:56PM +0300, Pavel Butsykin wrote: > The appliance memory size of 500 MB is insufficient in certain scenarios. In > partiuclar, semodule (which may be called by a guest tools uninstaller) often > triggers OOM (see https://bugzilla.redhat.com/426775) > > Increase it to 768 MB. > > Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com> >