similar to: Re: [PATCH v6 0/1] v2v bootloaders and augeas

On Fri, Apr 28, 2017 at 07:58:41PM +0300, Pavel Butsykin wrote: > > > On 28.04.2017 17:46, Pino Toscano wrote: > >On Wednesday, 19 April 2017 15:58:56 CEST Pavel Butsykin wrote: > >>I dare to raise an old topic :) It seemed to me that this patch already applied, > >>but recently discovered that it is not. > >> > >>As far as I understand we

On Wednesday, 19 April 2017 15:58:56 CEST Pavel Butsykin wrote: > I dare to raise an old topic :) It seemed to me that this patch already applied, > but recently discovered that it is not. > > As far as I understand we can't do a strict requirement to use Augeas >= 1.7.0. > But initially, the patch solves another problem. If we still can't do a hard > requirement for

On Fri, Apr 28, 2017 at 07:57:56PM +0300, Pavel Butsykin wrote: > On 28.04.2017 17:45, Pino Toscano wrote: > >On Wednesday, 19 April 2017 15:58:57 CEST Pavel Butsykin wrote: > >>This patch improves the search of grub config on EFI partition. This > >>means that the config will be found not only for rhel but also for > >>many other distributions. Tests were

On Wednesday, 19 April 2017 15:58:57 CEST Pavel Butsykin wrote: > This patch improves the search of grub config on EFI partition. This > means that the config will be found not only for rhel but also for > many other distributions. Tests were performed on the following > distributions: centos, fedora, ubuntu, suse. In all cases, the config > path was

On Tue, Nov 01, 2016 at 03:10:51PM +0300, Pavel Butsykin wrote: > On 01.11.2016 13:11, Richard W.M. Jones wrote: > >On Thu, Oct 27, 2016 at 08:22:30PM +0300, Pavel Butsykin wrote: > >> match typ with > >> | Grub1 -> > >>- if config_file = "/boot/efi/EFI/redhat/grub.conf" then > >>- g#aug_transform "grub"

On Wed, Apr 19, 2017 at 04:58:56PM +0300, Pavel Butsykin wrote: > I dare to raise an old topic :) It seemed to me that this patch already applied, > but recently discovered that it is not. > > As far as I understand we can't do a strict requirement to use Augeas >= 1.7.0. I'm not sure I know enough to review this patch, but on the issue of Augeas 1.7.0: As Augeas 1.7.0

On Tuesday, 1 November 2016 17:07:04 CET Richard W.M. Jones wrote: > From: Pavel Butsykin <pbutsykin@virtuozzo.com> > > This patch improves the search of grub config on EFI partition. This > means that the config will be found not only for rhel but also for > many other distributions. Tests were performed on the following > distributions: centos, fedora, ubuntu, suse. In

This patch improves the search of grub config on EFI partition. This means that the config will be found not only for rhel but also for many other distributions. Tests were performed on the following distributions: centos, fedora, ubuntu, suse. In all cases, the config path was /boot/efi/EFI/*distname*/grub.cfg The main purpose of the patch is to improve support for converting of vm with UEFI

On Thu, Oct 27, 2016 at 08:22:30PM +0300, Pavel Butsykin wrote: > match typ with > | Grub1 -> > - if config_file = "/boot/efi/EFI/redhat/grub.conf" then > - g#aug_transform "grub" "/boot/efi/EFI/redhat/grub.conf"; > - > + (match inspect.i_firmware with > + | I_BIOS -> () > + | I_UEFI _ -> g#aug_transform

From: Pavel Butsykin <pbutsykin@virtuozzo.com> This patch improves the search of grub config on EFI partition. This means that the config will be found not only for rhel but also for many other distributions. Tests were performed on the following distributions: centos, fedora, ubuntu, suse. In all cases, the config path was /boot/efi/EFI/*distname*/grub.cfg The main purpose of the patch

From: Pavel Butsykin <pbutsykin@virtuozzo.com> This patch improves the search of grub config on EFI partition. This means that the config will be found not only for rhel but also for many other distributions. Tests were performed on the following distributions: centos, fedora, ubuntu, suse. In all cases, the config path was /boot/efi/EFI/*distname*/grub.cfg The main purpose of the patch

On Wed, Nov 02, 2016 at 09:52:20PM +0300, Pavel Butsykin wrote: > But there is another point, we added a search for grub.conf/menu.lst in > /boot dir. This means that in some rare cases we can find the grub.conf > in non-standard locations(that will not be added to augeas). Can we > somehow handle the error aug_transform? Because if we could know that > augeas already contains the

On Wednesday, 2 November 2016 15:01:08 CET Richard W.M. Jones wrote: > From: Pavel Butsykin <pbutsykin@virtuozzo.com> > > This patch improves the search of grub config on EFI partition. This > means that the config will be found not only for rhel but also for > many other distributions. Tests were performed on the following > distributions: centos, fedora, ubuntu, suse.

On Thursday, 27 October 2016 20:22:30 CET Pavel Butsykin wrote: > This patch improves the search of grub config on EFI partition. This means that > the config will be found not only for rhel but also for many other distributions. > Tests were performed on the following distributions: centos, fedora, ubuntu, > suse. In all cases, the config path was /boot/efi/EFI/*distname*/grub.cfg

Augeas 1.7.0 was released a couple of days ago. By encouraging everyone to upgrade to this we can drop several calls to aug_transform and also our custom copies of two lenses, and a lot of related code. Rich.

Don't carry around Augeas lenses. It is fragile, since if the lens is added to upstream Augeas but the version number has not changed, then Augeas won't parse the target file at all. This specifically causes password adjustments to fail in RHEL 7.1. In future, if we need an Augeas lens, it must be added to Augeas, either upstream or as a downstream patch carried around by distros. ---

From: Pavel Butsykin <pbutsykin@virtuozzo.com> This patch improves the search of grub config on EFI partition. This means that the config will be found not only for rhel but also for many other distributions. Tests were performed on the following distributions: centos, fedora, ubuntu, suse. In all cases, the config path was /boot/efi/EFI/*distname*/grub.cfg The main purpose of the patch

On Friday 24 October 2014 16:00:15 Richard W.M. Jones wrote: > Don't carry around Augeas lenses. It is fragile, since if the lens is > added to upstream Augeas but the version number has not changed, then > Augeas won't parse the target file at all. This specifically causes > password adjustments to fail in RHEL 7.1. I disagree with this patch, in the current situation. The

Expose the aug_transform API through the library, so it's possible to add/remove Augeas transformations to handle files in custom places using existing lenses. --- daemon/augeas.c | 21 +++++++++++++++++++++ generator/actions.ml | 12 ++++++++++++ gobject/Makefile.inc | 2 ++ src/MAX_PROC_NR | 2 +- 4 files changed, 36 insertions(+), 1 deletion(-) diff --git a/daemon/augeas.c

Hi David, We have a general problem using Augeas in libguestfs and I wonder if you have any advice. The problem is that we often -- as with yesterday's patch -- add new config file paths to lenses. Or we want to parse config files which are not necessarily in the exact paths that Augeas is expecting. Now it's easy enough to parse such files using an arbitrary lens by calling