similar to: Re: [PATCH] appliance: reorder the steps to search for appliance

On Tue, Apr 25, 2017 at 02:35:26PM +0300, Pavel Butsykin wrote: > The patch changes the order of the steps to search for fixed/supermin > appliance in accordance with documentation: > > "If the fixed appliance is found, libguestfs skips supermin entirely > and just runs qemu with the kernel, initrd and root disk from the > fixed appliance." Does anyone rely on the

On Tue, Apr 25, 2017 at 06:13:37PM +0300, Pavel Butsykin wrote: > On 25.04.2017 16:04, Richard W.M. Jones wrote: > >Can you see what: > > > > guestfish get-path > > /usr/lib64/guestfs > > >prints? Are you setting LIBGUESTFS_PATH at all? > > > > No. > > # ls /usr/lib64/guestfs > initrd kernel README.fixed root supermin.d > >

On Thu, Apr 27, 2017 at 03:54:44PM +0300, Pavel Butsykin wrote: [...] > >(2) If the fixed appliance was located somewhere else, you could do: > > > > LIBGUESTFS_PATH=/path/to/somewhere/else:/usr/lib64/guestfs > > export LIBGUESTFS_PATH > > > >and then it would look for the fixed appliance in > >/path/to/somewhere/else and use it. If the fixed

On Fri, Apr 28, 2017 at 05:03:58PM +0300, Pavel Butsykin wrote: > On 27.04.2017 18:28, Richard W.M. Jones wrote: > > > >On Thu, Apr 27, 2017 at 03:55:10PM +0300, Pavel Butsykin wrote: > >>The flag determines the behavior of working with the appliance, and specifically > >>the choice to use the build supermin appliance or the fixed appliance. If the >

Eric, what do you think of Pavel's analysis and/or suggested fix below? It seems all too plausible to me unfortunately :-( On Fri, May 05, 2017 at 03:46:45PM +0300, Pavel Butsykin wrote: > On 05.05.2017 12:27, Richard W.M. Jones wrote: > > > >Looks good. I'll push this if it passes 'make check && make check-valgrind' > >which I'm currently

On Thu, May 04, 2017 at 02:20:28PM +0300, Pavel Butsykin wrote: > This patch changes appliance search using paths with multiple directories. Now > all appliance checks will be done separately for each directory. For example > if the path LIBGUESTFS_PATH=/a:/b:/c, then all applainces are searched first in > /a, then in /b and then in /c. It allows to flexibly configure the libguestfs

On Fri, Apr 28, 2017 at 05:04:15PM +0300, Pavel Butsykin wrote: > At least two control files (packages and base.tar.gz) are necessary for the > supermin appliance. > > Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com> > --- > lib/appliance.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/lib/appliance.c b/lib/appliance.c >

On Tue, Jun 20, 2017 at 06:48:16PM +0300, Pavel Butsykin wrote: > On 20.06.2017 18:41, Richard W.M. Jones wrote: > >On Tue, Jun 20, 2017 at 06:34:28PM +0300, Pavel Butsykin wrote: > >>On 20.06.2017 17:47, Richard W.M. Jones wrote: > >>>On Tue, Jun 20, 2017 at 05:04:53PM +0300, Pavel Butsykin wrote: > >>>>I noticed that raw is intentionally used as image

On Tue, Jun 20, 2017 at 06:34:28PM +0300, Pavel Butsykin wrote: > On 20.06.2017 17:47, Richard W.M. Jones wrote: > >On Tue, Jun 20, 2017 at 05:04:53PM +0300, Pavel Butsykin wrote: > >>I noticed that raw is intentionally used as image format for appliance > >>image. So I would like to ask, is there any reason to use raw as image > >>format for appliance? >

On Thu, Apr 27, 2017 at 03:55:10PM +0300, Pavel Butsykin wrote: > The flag determines the behavior of working with the appliance, and specifically > the choice to use the build supermin appliance or the fixed appliance. If the > flag is false then the libguestfs will only use the fixed appliance, otherwise > the build supermin appliance. > > This patch is aimed at solving the

This is largely code motion. --- src/appliance.c | 40 +++++++----------------------------- src/guestfs-internal.h | 1 + src/tmpdirs.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 63 insertions(+), 33 deletions(-) diff --git a/src/appliance.c b/src/appliance.c index 2cf6374..d293c2b 100644 --- a/src/appliance.c +++ b/src/appliance.c @@ -48,7 +48,7

Move the "FIXED APPLIANCE" section from libguestfs-make-fixed-appliance(1) to the general guestfs(3), so it's more visible and less hidden in the documentation of a rarely-used tool. Expand the FAQ question about libguestfs without supermin, mentioning the build options needed and pointing to the aforementioned new section. --- appliance/libguestfs-make-fixed-appliance.pod | 28

Move the "FIXED APPLIANCE" section from libguestfs-make-fixed-appliance(1) to the "INTERNALS" section of guestfs(3), so it's more visible and less hidden in the documentation of a rarely-used tool. Also slightly improve it. Expand the FAQ question about libguestfs without supermin, mentioning the build options needed and pointing to the aforementioned new section. ---

On Tue, Jun 20, 2017 at 05:04:53PM +0300, Pavel Butsykin wrote: > I noticed that raw is intentionally used as image format for appliance > image. So I would like to ask, is there any reason to use raw as image > format for appliance? The simple answer is because we create the appliance image (it's an ext2/3/4 filesystem) using e2fsprogs, and that library wouldn't know how to

Move the "FIXED APPLIANCE" section from libguestfs-make-fixed-appliance(1) to the general guestfs(3), so it's more visible and less hidden in the documentation of a rarely-used tool. Expand the FAQ question about libguestfs without supermin, mentioning the build options needed and pointing to the aforementioned new section. --- appliance/libguestfs-make-fixed-appliance.pod | 28

On Fri, Jun 23, 2017 at 04:12:36PM +0300, Pavel Butsykin wrote: > Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com> > --- > m4/guestfs_appliance.m4 | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/m4/guestfs_appliance.m4 b/m4/guestfs_appliance.m4 > index 81c43879f..7e8d28271 100644 > --- a/m4/guestfs_appliance.m4 > +++

On Tue, Jun 27, 2017 at 07:42:20PM +0300, Pavel Butsykin wrote: > This feature allows you to use different image formats for the fixed > appliance. The raw format is used by default. I wonder if you're stil using this feature? Unfortunately because of a recent change in libvirt it is no longer possible to have a backing file where libvirt will autodetect the format. See:

On Monday 15 June 2015 15:47:31 Richard W.M. Jones wrote: > On Wed, Jun 10, 2015 at 06:47:44PM +0200, Pino Toscano wrote: > > index e2ee1b5..eebab53 100644 > > --- a/src/guestfs.pod > > +++ b/src/guestfs.pod > > @@ -3540,6 +3540,30 @@ Finally, the child process sends asynchronous messages back to the > > main program, such as kernel log messages. You can register

On Wed, Jun 10, 2015 at 06:47:44PM +0200, Pino Toscano wrote: > index e2ee1b5..eebab53 100644 > --- a/src/guestfs.pod > +++ b/src/guestfs.pod > @@ -3540,6 +3540,30 @@ Finally, the child process sends asynchronous messages back to the > main program, such as kernel log messages. You can register a > callback to receive these messages. > > +=head1 FIXED APPLIANCE > +

On Fri, Jun 23, 2017 at 04:12:35PM +0300, Pavel Butsykin wrote: > This feature allows you to use different image formats for the fixed > appliance. The raw format is used by default. > > Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com> > --- > lib/create.c | 5 +++-- > lib/guestfs-internal.h | 2 ++ > lib/launch-direct.c | 2 ++ >