similar to: Re: [PATCH] appliance: reorder the steps to search for appliance

This is largely code motion. --- src/appliance.c | 40 +++++++----------------------------- src/guestfs-internal.h | 1 + src/tmpdirs.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 63 insertions(+), 33 deletions(-) diff --git a/src/appliance.c b/src/appliance.c index 2cf6374..d293c2b 100644 --- a/src/appliance.c +++ b/src/appliance.c @@ -48,7 +48,7

On Thu, Apr 27, 2017 at 03:54:44PM +0300, Pavel Butsykin wrote: [...] > >(2) If the fixed appliance was located somewhere else, you could do: > > > > LIBGUESTFS_PATH=/path/to/somewhere/else:/usr/lib64/guestfs > > export LIBGUESTFS_PATH > > > >and then it would look for the fixed appliance in > >/path/to/somewhere/else and use it. If the fixed

On Fri, Apr 28, 2017 at 05:04:15PM +0300, Pavel Butsykin wrote: > At least two control files (packages and base.tar.gz) are necessary for the > supermin appliance. > > Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com> > --- > lib/appliance.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/lib/appliance.c b/lib/appliance.c >

On Tue, Apr 25, 2017 at 06:13:37PM +0300, Pavel Butsykin wrote: > On 25.04.2017 16:04, Richard W.M. Jones wrote: > >Can you see what: > > > > guestfish get-path > > /usr/lib64/guestfs > > >prints? Are you setting LIBGUESTFS_PATH at all? > > > > No. > > # ls /usr/lib64/guestfs > initrd kernel README.fixed root supermin.d > >

This is the libguestfs companion patch to: https://www.redhat.com/archives/libguestfs/2013-September/msg00045.html Rich.

GCC has two warnings related to large stack frames. We were already using the -Wframe-larger-than warning, but this reduces the threshold from 10000 to 5000 bytes. However that warning only covers the static part of frames (not alloca). So this change also enables -Wstack-usage=10000 which covers both the static and dynamic usage (alloca and variable length arrays). Multiple changes are made

When writing to a RHEV target, virt-v2v launches the libguestfs appliance with euid:egid = 36:36, which is required to write to an NFS target using root_squash. Since the update to use an febootstrap cached appliance, this causes an error on startup as the cached files are owned by root, but the cache directory is owned by 36:36. The reason for this is that execve() resets euid and egid to uid and

Eric, what do you think of Pavel's analysis and/or suggested fix below? It seems all too plausible to me unfortunately :-( On Fri, May 05, 2017 at 03:46:45PM +0300, Pavel Butsykin wrote: > On 05.05.2017 12:27, Richard W.M. Jones wrote: > > > >Looks good. I'll push this if it passes 'make check && make check-valgrind' > >which I'm currently

On Tue, Apr 25, 2017 at 03:58:45PM +0300, Pavel Butsykin wrote: > On 25.04.2017 15:11, Richard W.M. Jones wrote: > >On Tue, Apr 25, 2017 at 02:35:26PM +0300, Pavel Butsykin wrote: > >>The patch changes the order of the steps to search for fixed/supermin > >>appliance in accordance with documentation: > >> > >>"If the fixed appliance is found,

On Thu, May 04, 2017 at 02:20:28PM +0300, Pavel Butsykin wrote: > This patch changes appliance search using paths with multiple directories. Now > all appliance checks will be done separately for each directory. For example > if the path LIBGUESTFS_PATH=/a:/b:/c, then all applainces are searched first in > /a, then in /b and then in /c. It allows to flexibly configure the libguestfs

This function was kind of like debug(), except that it didn't check the g->verbose flag and it only worked in the library (it would crash if used after fork). It also wasn't very useful. The sort of boot analysis done by tests/qemu/boot-analysis.c means that timestamping (some) messages is even less interesting than before. Remove it and replace calls with debug() instead. ---

Hi, this is a prototype of something I've around for some time. Basically it is about adding new appliances in addition to the main one currently used and kept up-to-date automatically: this way it is possible to create new appliances with extra packages, to be used in specific contexts (like virt-rescue, with more network/recovery tools) without filling the main appliance. It's still

Inspired by libvirt's virCommand* internal mini-library, this adds some internal APIs for running commands. The first patch contains the new APIs. The subsequent patches change various parts of the library over to use it. Rich.

Doing qemu feature detection in the direct backend takes ~100ms because we need to run `qemu -help' and `qemu -devices ?', and each of those interacts with glibc's very slow link loader. Fixing the link loader is really hard. Instead memoize the output of those two commands. This patch series first separates all the code dealing with qemu into a separate module (src/qemu.c) and

4b753c62089be663ac722e4a875bb061d259e87d missed a couple of uses of print_timestamped_message in launch.c. --- src/launch.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/launch.c b/src/launch.c index 9deb0cf..07a89ec 100644 --- a/src/launch.c +++ b/src/launch.c @@ -927,7 +927,7 @@ build_supermin_appliance (guestfs_h *g, const char *path, int r, len; if

Make all the static constant strings as char arrays, so they can be fully stored in read-only memory. --- align/scan.c | 2 +- builder/index-validate.c | 2 +- cat/cat.c | 2 +- cat/filesystems.c | 2 +- cat/log.c | 2 +- cat/ls.c | 2 +-

On Tuesday, 7 April 2020 14:59:11 CEST Tomáš Golembiovský wrote: > On Tue, Apr 07, 2020 at 02:33:20PM +0200, Pino Toscano wrote: > > On Tuesday, 7 April 2020 14:18:47 CEST Richard W.M. Jones wrote: > > > On Tue, Apr 07, 2020 at 01:25:02PM +0200, Pino Toscano wrote: > > > > The important thing is still that that you need to have space for the > > > >

https://bugzilla.redhat.com/show_bug.cgi?id=769680

Various changes/fixes to use smaller stack frames. Rich.

Description =========== This patch adds support of CMake meta build system, so you can generate Unix makefiles, VS 6.0-2017 projects and many more. Features ======== * Win32 and Linux tested * Travis CI test added * Generates working Visual Studio 6.0-2017 solutions * Generates working Unix Makefile * Supported options (<option> - <default value>): * `ENABLE_FLOATING_POINT` - on