similar to: [nbdkit PATCH] tls: Fix build on RHEL 5

Running 'make check' under a ThreadSanitizer build complains that test-layers leaks a pthread; while harmless, it is also an easy fix, by detaching the thread to ensure it gets cleaned up. Signed-off-by: Eric Blake <eblake@redhat.com> --- tests/test-layers.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/test-layers.c b/tests/test-layers.c index 00e6031..7b58699

It is possible for the round-up parameter to cause our desired size to exceed 2**63-1. But this error message is cryptic: $ ./nbdkit -f --filter=truncate pattern $(((1<<63)-1)) round-up=1m & $ qemu-nbd --list nbdkit: pattern[1]: error: .get_size function returned invalid value (-9223372036854775808) qemu-nbd: Failed to read initial magic: Unexpected end-of-file before all bytes were

The CLEANUP_FREE macro and friends can be useful to filters and in-tree plugins; as such, move them to common/ so more than just the server/ code can take advantage of our compiler magic. Signed-off-by: Eric Blake <eblake@redhat.com> --- common/utils/cleanup.h | 48 ++++++++++++++++++++++++++++++ server/internal.h | 12 +------- {server =>

On Fri, Dec 07, 2018 at 10:00:42AM -0600, Eric Blake wrote: > Use new 'name_of_*' functions to offer a bit more details about > messages being forwarded on to the remote server. > > Signed-off-by: Eric Blake <eblake@redhat.com> > --- > plugins/nbd/nbd.c | 8 +++++--- > plugins/nbd/Makefile.am | 3 ++- > 2 files changed, 7 insertions(+), 4 deletions(-)

Always truncating a log can wipe out useful history. Add an option to change this. Signed-off-by: Eric Blake <eblake@redhat.com> --- Hmm - logappend=false enables appending. Maybe we need a common utility function for parsing bool values (parse 0 and case-insensitive "off" or "false" as off, all others as true, or even report values that can't be parsed reasonably)

On Thu, Nov 16, 2017 at 09:13:55PM -0600, Eric Blake wrote: > Since we construct our error/debug messages via multiple calls > to stdio primitives, we are at risk of multiple threads interleaving > their output if they try to output at once. Add a mutex to group > related outputs into an atomic chunk. > > Signed-off-by: Eric Blake <eblake@redhat.com> > --- >

There's more that can be done (in particular, use of CLEANUP_FREE), but this is enough to at least see if I'm on the right track. I couldn't figure out an obvious difference between common/include and common/utils, but it looks like the former is for things that are inlineable via .h only, while the latter is when you need to link in a convenience library, so this landed in the

The upstream protocol recently promoted NBD_CMD_WRITE_ZEROES from experimental to a documented extension. Exposing support for this allows plugin writers to create sparse files when driven by a client that knows how to use the extension; meanwhile, even if a plugin does not support this extension, the server benefits from less network traffic from the client. Eric Blake (5): protocol: Support

We're still seeing sporadic failures of 'nbdkit nbd tls=', and I'm still trying to come up with a root cause fix (it may involve smarter use of gnutls_bye() in libnbd). In the meantime, here's what we know: when the hang/failure happens, the 'nbdkit nbd tls=' client process is stuck in a poll() waiting to see EOF from the server, while the 'nbdkit example1'

On Fedora 29, nbdkit-devel at 1.10.4 is too old for any of the tests/Makefile.am actions to run, but this also means we don't create any tls pki/ or keys.psk files that we then want to reuse during qemu testing, as evidenced by 'make check' failures such as: FAIL: interop-qemu-nbd-tls-certs ================================ qemu-nbd: Unable to access credentials

On Sat, Apr 27, 2019 at 04:26:45PM -0500, Eric Blake wrote: > Test the just-fixed bug in the truncate filter. Although it is in > general unsafe to shrink an image being served by the file plugin, the > test is careful to only issue operations on connection A after the > file has been resized back to its original length, in order to prove > whether the smaller size observed during

The previous commit broke the build during 'make check'; we want to test the in-tree header, not some (potentially stale or missing) installed header. Signed-off-by: Eric Blake <eblake at redhat.com> --- tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index c2d473a..9076d6b 100644 --- a/tests/Makefile.am

These patches should be ready to go in now; I will also post my work-in-progress for enabling full parallel handling that depends on these, but with that series, I was still getting crashes or hangs with test-socket-activation (I think I've nailed all the crashes I've seen, but the hang is rather insidious; see my other email

We've recently been hitting a transient hung rpm build when using make 4.3, due to a bug in test-nbd-tls-psk.sh. We're still trying to isolate the correct fix for that bug (it might be in the nbd plugin proper, but more likely is an issue in libnbd's tls handling of connection close), but in the meantime, this patch should at least cause a graceful fail rather than make hanging due to

Copies heavily after a similar addition recently made in nbdkit. --- I'm not sure if .1 or .3 fits better for the man page. With nbdkit, .1 made sense because 'nbdkit' is a standalone program; but with libnbd, our only standalone is nbdsh, yet naming it nbdsh-security seems off. docs/Makefile.am | 7 +++++++ docs/libnbd-security.pod | 32 ++++++++++++++++++++++++++++++++

On Mon, Sep 30, 2019 at 12:15:42PM -0500, Eric Blake wrote: > Test the just-fixed bug in --run failing to detect an nbdkit assertion > failure. > > While at it, sleep less when we don't actually need to wait for the > socket to be opened. > > Signed-off-by: Eric Blake <eblake@redhat.com> > --- > tests/test-captive.sh | 46

On 4/15/20 1:18 PM, Richard W.M. Jones wrote: > On Wed, Apr 15, 2020 at 01:09:21PM -0500, Eric Blake wrote: >> On 4/15/20 11:16 AM, Richard W.M. Jones wrote: >> >> In the subject, you describe $nbdkit_safe_stdio, but in the patch body... >> >>> --- >>> plugins/eval/nbdkit-eval-plugin.pod | 11 +++-------- >>> plugins/sh/nbdkit-sh-plugin.pod

There's enough here to need a review; some of it probably needs backporting to stable-1.12. This probably breaks tests on Haiku or other platforms that have not been as on-the-ball about atomic CLOEXEC; feel free to report issues that arise, and I'll help come up with workarounds (even if we end up leaving a rare fd leak on less-capable systems). Meanwhile, I'm still working on my

On 4/15/20 11:16 AM, Richard W.M. Jones wrote: In the subject, you describe $nbdkit_safe_stdio, but in the patch body... > --- > plugins/eval/nbdkit-eval-plugin.pod | 11 +++-------- > plugins/sh/nbdkit-sh-plugin.pod | 18 +++++++++++++++++- > plugins/sh/call.c | 8 ++++++-- > tests/test-single-sh.sh | 4 ++++ > 4 files changed, 30

Low-level pthread locks should not fail except in extreme cases of programmer bugs; we're better off calling attention to such bugs rather than just assuming that they work and continuing on with possibly inconsistent state. Signed-off-by: Eric Blake <eblake@redhat.com> --- server/connections.c | 20 ++++++++++++-------- server/locks.c | 42