similar to: [PATCH] v2v: -o vdsm, -o rhev: Don't create compat=0.10 images;

Support for RHEV with RHEL 6 nodes required us to output the old style qcow2 compat=0.10 images. Since RHEV 3.6 GA, RHEL 6 has not been supported as a RHEV node type. Since RHV 4.1, compat=1.1 is supported. Support for compat=1.1 is uncertain in RHV 4.0 even on RHEL 7 nodes. There are significant downsides to using qcow2 compat=0.10 instead of the modern default (compat=1.1). Therefore this

Support for RHEV with RHEL 6 nodes required us to output the old style qcow2 compat=0.10 images. Since RHEV 3.6 GA, RHEL 6 has not been supported as a RHEV node type. Since RHV 4.1, compat=1.1 is supported. (Support for compat=1.1 is uncertain in RHV 4.0 even on RHEL 7 nodes.) There are significant downsides to using qcow2 compat=0.10 instead of the modern default (compat=1.1). Therefore this

Extend open_guestfs to take an optional ?identifier parameter. Use this parameter in virt-v2v which is currently the only place where we use the handle identifier. --- mllib/common_utils.ml | 3 ++- mllib/common_utils.mli | 2 +- v2v/output_rhev.ml | 3 +-- v2v/output_vdsm.ml | 3 +-- v2v/v2v.ml | 3 +-- v2v/windows.ml | 3 +-- 6 files changed, 7 insertions(+), 10

On Wed, Oct 21, 2015 at 03:53:33PM +0200, Pino Toscano wrote: > Use the common open_guestfs to open Guestfs handles, so we get > debugging, tracing, and other common options set. > --- > v2v/convert_windows.ml | 4 +--- > v2v/input_disk.ml | 2 +- > v2v/input_libvirt_other.ml | 2 +- > v2v/input_ova.ml | 2 +- > v2v/output_glance.ml | 2 +- >

Use the common open_guestfs to open Guestfs handles, so we get debugging, tracing, and other common options set. --- v2v/convert_windows.ml | 4 +--- v2v/input_disk.ml | 2 +- v2v/input_libvirt_other.ml | 2 +- v2v/input_ova.ml | 2 +- v2v/output_glance.ml | 2 +- v2v/output_null.ml | 2 +- v2v/output_rhev.ml | 2 +- v2v/output_vdsm.ml | 2 +-

You can now use -o rhv (-o rhev is supported for compatibility). --- v2v/Makefile.am | 8 +- v2v/OVF.ml | 30 +++---- v2v/OVF.mli | 2 +- v2v/changeuid.mli | 4 +- v2v/cmdline.ml | 12 +-- v2v/convert_windows.ml

You can now use -o rhv (-o rhev is supported for compatibility). --- p2v/gui.c | 5 +- p2v/virt-p2v.pod | 13 ++- v2v/Makefile.am | 8 +- v2v/OVF.ml | 30 +++---- v2v/OVF.mli | 2 +- v2v/changeuid.mli

v3: Change the flag from --vdsm-compat-11 to --vdsm-compat=1.1 Also the --machine-readable output has changed. I have also added a test. Rich.

This makes them visible in the help text of -i and -o. --- v2v/input_disk.ml | 5 ++++- v2v/output_local.ml | 5 ++++- v2v/output_rhev.ml | 5 ++++- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/v2v/input_disk.ml b/v2v/input_disk.ml index 17ad61d..508f16a 100644 --- a/v2v/input_disk.ml +++ b/v2v/input_disk.ml @@ -101,4 +101,7 @@ class input_disk input_format disk = object

Extend Modules_list to handle also aliases for input and output modules, and use this to register the existing aliases. --- v2v/input_disk.ml | 2 +- v2v/modules_list.ml | 25 +++++++++++++++++++++---- v2v/modules_list.mli | 8 ++++---- v2v/output_local.ml | 2 +- v2v/output_rhev.ml | 2 +- 5 files changed, 28 insertions(+), 11 deletions(-) diff --git a/v2v/input_disk.ml

On Tue, Jan 20, 2015 at 02:53:43PM +0200, Shahar Havivi wrote: > >From 87f448fc8b3243ad5d01acb65efb0c710d811a93 Mon Sep 17 00:00:00 2001 > From: Shahar Havivi <shaharh@redhat.com> > Date: Tue, 20 Jan 2015 14:41:23 +0200 > Subject: [PATCH] v2v: -o vdsm should assume data domain at -os path > > Unlike -o rhev which have only one data domin, -o rhev can and usually

Unlike -o rhev which have only one data domin, -o vdsm can and usually does have multiple data domain. The path to vdsm is pre mounted so no need to assume nfs path with -os Example: -o vdsm -os /rhev/data-center/<data-center-uuid>/<data-domain-uuid> Bug-Url: https://bugzilla.redhat.com/1176591 Signed-off-by: Shahar Havivi <shaharh@redhat.com> --- v2v/output_vdsm.ml

On Thursday, 6 February 2020 18:20:19 CET Richard W.M. Jones wrote: > In the guestfs_disk_create API we have traditionally allowed you to > set backingfile without setting backingformat. The meaning of this is > to let qemu autodetect the backing format when opening the overlay > disk. > > However libvirt >= 6.0 refuses to even pass such disks to qemu (see >

On 26.01.15 09:11, Richard W.M. Jones wrote: > On Tue, Jan 20, 2015 at 05:19:54PM +0200, Shahar Havivi wrote: > > >From ff9261b201283f7bff16dc41721480e2e0a9f80f Mon Sep 17 00:00:00 2001 > > From: Shahar Havivi <shaharh@redhat.com> > > Date: Tue, 20 Jan 2015 14:41:23 +0200 > > Subject: [PATCH] v2v: -o vdsm should assume data domain at -os path > > >

On Monday, 9 March 2020 11:40:46 CET Richard W.M. Jones wrote: > On Mon, Mar 09, 2020 at 11:07:20AM +0100, Pino Toscano wrote: > > On Thursday, 6 February 2020 18:20:19 CET Richard W.M. Jones wrote: > > > In the guestfs_disk_create API we have traditionally allowed you to > > > set backingfile without setting backingformat. The meaning of this is > > > to let

In the guestfs_disk_create API we have traditionally allowed you to set backingfile without setting backingformat. The meaning of this is to let qemu autodetect the backing format when opening the overlay disk. However libvirt >= 6.0 refuses to even pass such disks to qemu (see https://bugzilla.redhat.com/show_bug.cgi?id=1798148). For this reason, move the autodetection earlier and make it

On Mon, Mar 09, 2020 at 11:19:39AM +0000, Richard W.M. Jones wrote: > On Mon, Mar 09, 2020 at 12:07:08PM +0100, Pino Toscano wrote: > > On Monday, 9 March 2020 11:40:46 CET Richard W.M. Jones wrote: > > > On Mon, Mar 09, 2020 at 11:07:20AM +0100, Pino Toscano wrote: > > > > On Thursday, 6 February 2020 18:20:19 CET Richard W.M. Jones wrote: > > > > > In

On Tue, Jan 20, 2015 at 05:19:54PM +0200, Shahar Havivi wrote: > >From ff9261b201283f7bff16dc41721480e2e0a9f80f Mon Sep 17 00:00:00 2001 > From: Shahar Havivi <shaharh@redhat.com> > Date: Tue, 20 Jan 2015 14:41:23 +0200 > Subject: [PATCH] v2v: -o vdsm should assume data domain at -os path > > Unlike -o rhev which have only one data domin, -o vdsm can and usually >

On 20.01.15 12:59, Richard W.M. Jones wrote: > On Tue, Jan 20, 2015 at 02:53:43PM +0200, Shahar Havivi wrote: > > > >From 87f448fc8b3243ad5d01acb65efb0c710d811a93 Mon Sep 17 00:00:00 2001 > > From: Shahar Havivi <shaharh@redhat.com> > > Date: Tue, 20 Jan 2015 14:41:23 +0200 > > Subject: [PATCH] v2v: -o vdsm should assume data domain at -os path > >

On Mon, Mar 09, 2020 at 12:07:08PM +0100, Pino Toscano wrote: > On Monday, 9 March 2020 11:40:46 CET Richard W.M. Jones wrote: > > On Mon, Mar 09, 2020 at 11:07:20AM +0100, Pino Toscano wrote: > > > On Thursday, 6 February 2020 18:20:19 CET Richard W.M. Jones wrote: > > > > In the guestfs_disk_create API we have traditionally allowed you to > > > > set