similar to: [PATCH] launch: libvirt: Autodetect backing format for drive overlays (RHBZ#1354335).

On Tue, Jun 27, 2017 at 07:42:20PM +0300, Pavel Butsykin wrote: > This feature allows you to use different image formats for the fixed > appliance. The raw format is used by default. I wonder if you're stil using this feature? Unfortunately because of a recent change in libvirt it is no longer possible to have a backing file where libvirt will autodetect the format. See:

On Fri, Jun 23, 2017 at 04:12:35PM +0300, Pavel Butsykin wrote: > This feature allows you to use different image formats for the fixed > appliance. The raw format is used by default. > > Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com> > --- > lib/create.c | 5 +++-- > lib/guestfs-internal.h | 2 ++ > lib/launch-direct.c | 2 ++ >

From: "Richard W.M. Jones" <rjones at redhat.com> You can now add remote NBD drives using: ><fs> add-drive "" format:raw protocol:nbd server:localhost (Note that you also need to add port:NNNN if the server is running on a non-standard port). The corresponding qemu-nbd service can be started by doing: qemu-nbd disk.img -t This commit also adds a test. ---

There were various places in the library where we open coded making temporary filenames. This uses the utility function instead. --- lib/appliance-uefi.c | 4 +++- lib/command.c | 5 +++-- lib/drives.c | 4 +++- lib/inspect-icon.c | 12 +++++++++--- lib/launch-direct.c | 5 ++--- lib/launch-libvirt.c | 5 ++--- lib/launch-uml.c | 5 ++--- 7 files changed, 24

QEMU upstream has broken snapshot=on ... again. These two patches stop using it entirely. Instead we run 'qemu-img create' to create overlay disks as required. Note that the libvirt and UML backends were already doing this: The libvirt backend because <transient/> has never worked, and the UML backend was running uml_mkcow because the UML-equivalent syntax of snapshot=on was

When creating the qemu-img command, use the guestfs_int_cmd_add_arg & guestfs_int_cmd_add_arg_format APIs to add the proper filename directly, without creating a string for it. This should cause no functional change. --- lib/create.c | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/lib/create.c b/lib/create.c index 60e467fb6..fcc5855e0 100644

Ancient qemu 1.5 (in RHEL 7) does not understand the file.file.filename= and file.driver= parameters. Go back to using the old-style file= and format= parameters when we're not trying to set the file.backing.file.locking=off parameter. Fixes commit 9fe592808ccfd9ed184b88ca9c6cad2e1798dee3. Thanks: Yongkui Guo, Václav Kadlčík. --- lib/launch-direct.c | 31 +++++++++++++++++++++---------- 1

A lot of code runs 'qemu-img create' or 'truncate' to create blank disk images. In the past I resisted adding an API to do this, since it essentially duplicates what you can already do using other tools (ie. qemu-img). However this does simplify calling code quite a lot since qemu-img is somewhat error-prone to use (eg: don't try to create a disk called "foo:bar")

On Thursday, 6 February 2020 18:20:19 CET Richard W.M. Jones wrote: > In the guestfs_disk_create API we have traditionally allowed you to > set backingfile without setting backingformat. The meaning of this is > to let qemu autodetect the backing format when opening the overlay > disk. > > However libvirt >= 6.0 refuses to even pass such disks to qemu (see >

On Monday, 9 March 2020 11:40:46 CET Richard W.M. Jones wrote: > On Mon, Mar 09, 2020 at 11:07:20AM +0100, Pino Toscano wrote: > > On Thursday, 6 February 2020 18:20:19 CET Richard W.M. Jones wrote: > > > In the guestfs_disk_create API we have traditionally allowed you to > > > set backingfile without setting backingformat. The meaning of this is > > > to let

On Mon, Mar 09, 2020 at 11:19:39AM +0000, Richard W.M. Jones wrote: > On Mon, Mar 09, 2020 at 12:07:08PM +0100, Pino Toscano wrote: > > On Monday, 9 March 2020 11:40:46 CET Richard W.M. Jones wrote: > > > On Mon, Mar 09, 2020 at 11:07:20AM +0100, Pino Toscano wrote: > > > > On Thursday, 6 February 2020 18:20:19 CET Richard W.M. Jones wrote: > > > > > In

In the guestfs_disk_create API we have traditionally allowed you to set backingfile without setting backingformat. The meaning of this is to let qemu autodetect the backing format when opening the overlay disk. However libvirt >= 6.0 refuses to even pass such disks to qemu (see https://bugzilla.redhat.com/show_bug.cgi?id=1798148). For this reason, move the autodetection earlier and make it

[dropping libvir-list - this is a usage question, not a development question] On 09/02/2013 11:29 PM, Guozhonghua wrote: > I had test the command virsh blockcommit, but it failed, with the libvirt version 1.1.0, and qemu version 1.6.0. > Is this feature being developing? Thanks The feature is supported, but you have to use it correctly. In particular, your backing chain MUST label the

When the result guestfs_disk_format() is not known, free the string before returning an error. --- lib/launch-libvirt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/launch-libvirt.c b/lib/launch-libvirt.c index e4961f201..844023b80 100644 --- a/lib/launch-libvirt.c +++ b/lib/launch-libvirt.c @@ -197,6 +197,7 @@ get_source_format_or_autodetect (guestfs_h *g, struct drive *drv)

On Mon, Mar 09, 2020 at 12:07:08PM +0100, Pino Toscano wrote: > On Monday, 9 March 2020 11:40:46 CET Richard W.M. Jones wrote: > > On Mon, Mar 09, 2020 at 11:07:20AM +0100, Pino Toscano wrote: > > > On Thursday, 6 February 2020 18:20:19 CET Richard W.M. Jones wrote: > > > > In the guestfs_disk_create API we have traditionally allowed you to > > > > set

Commit 588af1953e5f7ab74009b9175cc5d3efb8bb651a started with a very conservative list of permitted backing formats (just "raw" or "qcow2"). We can allow almost any format permitted by qemu, but this commit just adds "vmdk" to this whitelist. --- src/create.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/create.c b/src/create.c index

If you use the libguestfs tools which open disk images read-only (eg. virt-df), with formats such as 'vdi', then you will see an error: error: invalid value for backingformat parameter 'vdi' This is because opening a disk image read-only will try to create a qcow2 file with the original image as a backing file. However the list of permitted backing formats was very restrictive

QEMU does not accept options unrecognized by the block driver in use. Disable locking only for read-only disks that are file-backed, as that's the only block driver it is supported with. Signed-off-by: Lars Seipel <ls@slrz.net> --- lib/launch-direct.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/launch-direct.c b/lib/launch-direct.c index

On Mon, Mar 09, 2020 at 11:07:20AM +0100, Pino Toscano wrote: > On Thursday, 6 February 2020 18:20:19 CET Richard W.M. Jones wrote: > > In the guestfs_disk_create API we have traditionally allowed you to > > set backingfile without setting backingformat. The meaning of this is > > to let qemu autodetect the backing format when opening the overlay > > disk. > >

On Mon, Apr 18, 2016 at 02:49:07PM +0200, Pino Toscano wrote: > The drive used for the appliance is a raw (sparse) disk: specify that > explicitly in its -drive qemu command line options, so qemu can skip the > autodetection of its format and save a tiny bit of time. > --- > src/launch-direct.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git