similar to: [PATCH] mllib, customize: Don't add -g option to ocamlmklib command line.

On Tuesday 06 October 2015 13:30:46 Richard W.M. Jones wrote: > --- > mllib/common_utils.ml | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mllib/common_utils.ml b/mllib/common_utils.ml > index f8fa8fd..f9c45cc 100644 > --- a/mllib/common_utils.ml > +++ b/mllib/common_utils.ml > @@ -20,8 +20,6 @@ open Printf > > open

On Mon, Aug 31, 2015 at 06:49:55PM +0200, Pino Toscano wrote: > Move --debug-gc as common option for all the OCaml-based tools, even a > couple of them which didn't have it previously. > > As implementation note, make set_debug_gc private to > set_standard_options, as it needed to be moved otherwise, and it is no > more required as public function. ACK series. I guess

On Monday, 18 July 2016 09:38:43 CEST Richard W.M. Jones wrote: > On Mon, Jul 18, 2016 at 10:13:30AM +0200, Pino Toscano wrote: > > Since we are using gnulib already, make use of xstrtol to parse the > > integer arguments to avoid extra suffixes, etc. > > > > Fixes commit 0f7bf8f714898c606e5d5015fff5b7803dcd1aee. > > --- > > mllib/getopt-c.c | 34

On Tue, Aug 02, 2016 at 07:14:09PM +0200, Pino Toscano wrote: > run_command uses Unix.create_process which forks a child process, and > executes execve: the latter fails when the executable does not exist, > triggering the exit which, in older OCaml versions [1], also runs the > at_exit handlers. > > Since there is not much that can be done to avoid this on the OCaml > side,

On Monday, 18 July 2016 11:46:46 CEST Richard W.M. Jones wrote: > --- Note that this changes the way -foo options are handled: this basically makes them as --foo, but still working as -foo because getopt_long_only is used. IMHO either add a new M".." ([M]edium or [T]runcated or [D]ash or ...), or turn S to get a string instead. > - let validate_key key = > - if

On Wednesday 01 July 2015 17:36:20 Richard W.M. Jones wrote: > On Wed, Jul 01, 2015 at 05:49:06PM +0200, Pino Toscano wrote: > > Collect this small snippet to get the part of a string after the last > > occurrency of a character; replace with it the current snippets doing > > the same. > > > > Should be just code motion. > > --- > >

On Wed, Jul 08, 2015 at 04:42:18PM +0200, Pino Toscano wrote: > + error (f_"subscription-manager configuration required for this operation") This error message should refer to the --sm-config option in some way, so the error message is actionable. --- Patches 1-5 are fine and can go upstream now. I can't say that I'm overjoyed by the new config file format that we

On Wednesday, 7 December 2016 17:13:08 CET Tomáš Golembiovský wrote: > Added two new optional arguments to nsplit: > > * noempty: if set to false empty elements are not stored in the returned > list. The default is to keep the empty elements > > * count: specifies how many splits to perform; negative count > (the default) means do as many splits as possible > >

On Mon, May 11, 2015 at 07:22:58PM +0200, Pino Toscano wrote: > On Monday 11 May 2015 11:11:50 Richard W.M. Jones wrote: > > OUnit2 has an OUnit (v1) compatibility module. Unfortunately it > > is rather gravely broken: > > https://forge.ocamlcore.org/tracker/?func=detail&aid=1392&group_id=162&atid=730 > > > > Since there is no new release fixing this,

On Monday, 18 July 2016 14:43:03 CEST Richard W.M. Jones wrote: > > > - let validate_key key = > > > - if String.length key == 0 || key == "-" || key == "--" > > > - || key.[0] != '-' then > > > - invalid_arg (sprintf "invalid option key: '%s'" key) > > > + let validate_key = function >

On Sunday, 18 December 2016 23:16:31 CET Tomáš Golembiovský wrote: > Added two new optional arguments to nsplit: > > * noempty: if set to false empty elements are not stored in the returned > list. The default is to keep the empty elements > > * count: specifies how many splits to perform; negative count > (the default) means do as many splits as possible > >

On Wednesday, 12 April 2017 14:33:09 CEST Cédric Bosdonnat wrote: > --- > dib/utils.ml | 4 ---- > mllib/common_utils.ml | 5 +++++ > mllib/common_utils.mli | 3 +++ > 3 files changed, 8 insertions(+), 4 deletions(-) It looks like virt-builder-repository does not use do_cp anymore, so this patch can be put aside for now. -- Pino Toscano

Binaries should be rebuilt if mllib.cma/mllib.cmxa or customize.cma/customize.cmxa change. Fixes commit 1e2877c6f4d1d254026d38b1cac4895d8dba7d5d. --- builder/Makefile.am | 12 ++++++++++-- customize/Makefile.am | 3 ++- dib/Makefile.am | 5 ++++- get-kernel/Makefile.am | 5 ++++- mllib/Makefile.am | 15 ++++++++++++--- resize/Makefile.am | 5 ++++- sparsify/Makefile.am

On Thursday, 15 June 2017 19:06:00 CEST Richard W.M. Jones wrote: > Create a module ‘C_utils’ containing functions like ‘drive_name’ and > ‘shell_unquote’ which come from the C utilities. > > The new directory ‘common/mlutils’ also contains the ‘Unix_utils’ > wrappers around POSIX functions missing from the OCaml stdlib. > --- I fear we are spreading the code among too many

On Thursday, 15 June 2017 19:05:54 CEST Richard W.M. Jones wrote: > The new module ‘Std_utils’ contains only functions which are pure > OCaml and depend only on the OCaml stdlib. Therefore these functions > may be used by the generator. Hm can we please use a better name than Std_utils? Otherwise there's a bit of confusion between two generic names such as Std_utils and

On Thu, Jul 07, 2016 at 06:08:43PM +0100, Richard W.M. Jones wrote: > On Thu, Jul 07, 2016 at 07:00:46PM +0200, Pino Toscano wrote: > > On Thursday 07 July 2016 17:30:03 Richard W.M. Jones wrote: > > > This adds imperative list manipulation functions inspired by Perl. > > > The functions are passed list refs which get updated in place. > > > > > > This

On Monday 03 November 2014 19:36:21 Pino Toscano wrote: > +val do_ssh_inject_unix : Guestfs.guestfs -> string -> ssh_key_selector -> unit > +(** ... *) Err... this is supposed to be: (** Inject on a generic Unix system (Linux, FreeBSD, etc) the ssh key for the specified user. *) (already fixed locally.) -- Pino Toscano

On Thursday, 23 March 2017 10:02:47 CEST Cédric Bosdonnat wrote: > This function will allow more OCAML-ish processing of xpath queries > with multiple results. s/OCAML/OCaml/ s/xpath/XPath/ > --- > mllib/xpath_helpers.ml | 9 +++++++++ > mllib/xpath_helpers.mli | 4 ++++ > 2 files changed, 13 insertions(+) > > diff --git a/mllib/xpath_helpers.ml

On Tuesday 11 August 2015 15:05:04 Richard W.M. Jones wrote: > On Tue, Aug 11, 2015 at 03:45:11PM +0200, Pino Toscano wrote: > > Small helper to normalize an architecture string, so it is easier to > > compare them and check for compatibilities. > > > > Make use of it in guest_arch_compatible, simplifying it. > > Have a look at: >

On Thursday 07 July 2016 17:30:03 Richard W.M. Jones wrote: > This adds imperative list manipulation functions inspired by Perl. > The functions are passed list refs which get updated in place. > > This allows us to replace some awkward pure functional code like: > > let xs = ys in > let xs = if foo then xs @ zs else xs in > > with: > > let xs = ref ys in