similar to: [PATCH] appliance: touch /etc/fstab when enabling the network (RHBZ#1224795)

Workaround for Ubuntu which uses this script to try to start a systemd service. That won't work because systemd is not used inside the appliance. See: https://bugs.launchpad.net/ubuntu/+source/supermin/+bug/1824236 Thanks: Ioanna Alifieraki --- appliance/init | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/appliance/init b/appliance/init index 4f2b55822..b1c4d09ea

dhcpcd requires an interface name as parameter to work. We are now getting it from /proc/sys/net/ipv4/conf/ folder children. dhclient on Debian also has the problem, thus use the guessed interface name for it too. --- appliance/init | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/appliance/init b/appliance/init index cca62e7..d5a428d 100755 --- a/appliance/init +++

On Thu, Oct 02, Richard W.M. Jones wrote: > +if grep -sq guestfs_network=1 /proc/cmdline; then > + dhclient > +fi dhclient will be missing at least in openSUSE. Not an issue now, does the script fail if the command fails to execute due to ENOENT? Olaf

I had tried this approach, to add /etc/dhcp/dhclient-enter-hooks.d/resolved to excludefiles, however it didn't work. As far as I know, this hook is included in the base image and according to [1], the current implementation does not apply excludefiles to the base image. Jo [1] https://github.com/libguestfs/supermin/blob/b2401285cd3e3d42006fc164ef1f046cc35a50c4/src/mode_build.ml#L137 On

v2: - Make virbr0 configurable. - Fix the tests.

qemu in SLIRP mode offers DHCP services to the appliance. We don't use them, but use a fixed IP address intead. This changes the appliance to get its IP address using DHCP. Note: This is only used when the network is enabled. dhclient is somewhat slower, but the penalty (a few seconds) is only paid for network users. We could consider using the faster systemd dhcp client instead. ---

On Thursday, 18 April 2019 11:53:39 CEST Richard W.M. Jones wrote: > Workaround for Ubuntu which uses this script to try to start a systemd > service. That won't work because systemd is not used inside the > appliance. See: > > https://bugs.launchpad.net/ubuntu/+source/supermin/+bug/1824236 > > Thanks: Ioanna Alifieraki > --- > appliance/init | 4 +++- > 1

Here are two patches: one fixes the gpg-agent causing unmount to fail after running dnf to install packages. The other ones fixes dhcpcd call in the init program to provide it an interface name. Cédric Bosdonnat (2): appliance init: find NIC name for dhcpcd Make sure gpg-agent is terminated before umount appliance/init | 3 ++- customize/customize_run.ml | 3 ++- 2 files

Read the content of /proc/cmdline using bash features, and use its [[ ... ]] expression to find texts in a variable. This shaves off 5 grep invocations. --- appliance/init | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/appliance/init b/appliance/init index f6fe9b9..8d662fa 100755 --- a/appliance/init +++ b/appliance/init @@ -75,7 +75,9 @@ $UDEVD --daemon

dhcpcd requires an interface name as parameter to work. We are now getting it from /proc/sys/net/ipv4/conf/ folder children. --- appliance/init | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/appliance/init b/appliance/init index cca62e7..ef18959 100755 --- a/appliance/init +++ b/appliance/init @@ -111,7 +111,8 @@ if test "$guestfs_network" = 1; then if

qemu in SLIRP mode offers DHCP services to the appliance. We don't use them, but use a fixed IP address intead. This changes the appliance to get its IP address using DHCP. Note: This is only used when the network is enabled. dhclient is somewhat slower, but the penalty (a few seconds) is only paid for network users. We could consider using the faster systemd dhcp client instead. ---

Hi Rich, I set LIBGUESTFS_DEBUG=1 LIBGUESTFS_TRACE=1 when calling virt-builder, and here is the log: [ 0.1] Downloading: file:///home/myan/work/libguestfs/builder/website/ubuntu-14.04.xz [ 1.4] Planning how to build this image [ 1.4] Uncompressing [ 4.4] Opening the new disk libguestfs: trace: set_verbose true libguestfs: trace: set_verbose = 0 libguestfs: trace: set_tmpdir

v3: - Various changes to dhclient/dhcpcd as discussed on the mailing list.

On Thu, Oct 02, Richard W.M. Jones wrote: > The script won't fail, but the network won't work. What's the > alternative on SuSE? I think that would be dhcpcd, which is also used by NetworkManager. Olaf

On Thu, Oct 02, 2014 at 01:43:46PM +0200, Olaf Hering wrote: > On Thu, Oct 02, Richard W.M. Jones wrote: > > > +if grep -sq guestfs_network=1 /proc/cmdline; then > > + dhclient > > +fi > > dhclient will be missing at least in openSUSE. Not an issue now, does > the script fail if the command fails to execute due to ENOENT? The script won't fail, but the

On Thu, Oct 02, 2014 at 01:53:45PM +0200, Olaf Hering wrote: > On Thu, Oct 02, Richard W.M. Jones wrote: > > > The script won't fail, but the network won't work. What's the > > alternative on SuSE? > > I think that would be dhcpcd, which is also used by NetworkManager. It turns out we don't package dhcpcd in Fedora. If we did the following, would it

Hi All, I been using virt-builder to create testing VMs (most ubuntu) for a while, and it works great. But when I cloned the git repo today and found the process becoming extremely slow, please see the output below. log that produced by pre-installed vendor package: virt-builder ubuntu-14.04 --firstboot-command 'useradd -m -p "" myan; chage -d 0 myan; usermod -aG sudo myan;' [

Yeah, it's definitely an issue with dhclient. I patched the init script to use dhcpcd instead and everything is working as expected now. I've attached a log containing the strace of dhclient if that helps you or someone else in the future. Thanks for all your help Rich. Shawn On Tue, Jun 30, 2015 at 9:53 AM, Richard W.M. Jones <rjones@redhat.com> wrote: > On Tue, Jun 30, 2015

Rich you're right, I forgot to run make. I added 'set -x' and reran make and then ran 'virt-builder -v -x' and it seems to hang at dhclient (see attached log). Shawn On Tue, Jun 30, 2015 at 9:17 AM, Richard W.M. Jones <rjones@redhat.com> wrote: > On Tue, Jun 30, 2015 at 09:07:25AM -0600, Shawn Greig wrote: > > - I tried forcing TCG and it gets to the same spot

This is just code refactoring. --- src/launch.c | 172 +++++++++++++++++++++++++++++++++++++---------------------- 1 file changed, 109 insertions(+), 63 deletions(-) diff --git a/src/launch.c b/src/launch.c index 46d7ab9..84d5e82 100644 --- a/src/launch.c +++ b/src/launch.c @@ -293,9 +293,7 @@ guestfs_impl_config (guestfs_h *g, #endif #if defined(__aarch64__) -#define EARLYPRINTK "