similar to: Re: list-filesystems and btrfs snapshots

On Tuesday 01 March 2016 11:17:19 Cédric Bosdonnat wrote: > The list of filesystems that is printed when there was an error prints > the internal mountable string even for the btrfs subvolumes. Let's > printing a valid -m option value instead. > --- > fish/options.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/fish/options.c

virt-filesystem -l tries to get the size of btrfs subvolumes, which results in an error. Teach it to skip the subvolumes. --- cat/filesystems.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/cat/filesystems.c b/cat/filesystems.c index f1c2852..f679517 100644 --- a/cat/filesystems.c +++ b/cat/filesystems.c @@ -476,9 +476,27 @@ do_output_filesystems

virt-filesystem -l tries to get the size of btrfs subvolumes, which results in an error. Teach it to skip the subvolumes. --- cat/filesystems.c | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/cat/filesystems.c b/cat/filesystems.c index f1c2852..cfdac86 100644 --- a/cat/filesystems.c +++ b/cat/filesystems.c @@ -476,9 +476,28 @@ do_output_filesystems

On Wed, Jul 06, 2016 at 05:33:01PM +0300, Maxim Perevedentsev wrote: > Hello everyone! > > I have an issue with OpenSUSE-42.1 (I guess this is the only distro > with btrfs snapshots by default). > As we remember, list_filesystems returns btrfs snapshots along with devices. > > ><fs> list-filesystems > /dev/sda1: swap > btrfsvol:/dev/sda2/@: btrfs >

The list of filesystems that is printed when there was an error prints the internal mountable string even for the btrfs subvolumes. Let's printing a valid -m option value instead. --- fish/options.c | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/fish/options.c b/fish/options.c index da5015d..9222b69 100644 --- a/fish/options.c +++

The list of filesystems that is printed when there was an error prints the internal mountable string even for the btrfs subvolumes. Let's printing a valid -m option value instead. --- fish/options.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/fish/options.c b/fish/options.c index da5015d..5c09bfb 100644 --- a/fish/options.c +++ b/fish/options.c @@

Hey there! Here are a few patches to fix unrelated things: one fixes the configure for older ncurses releases having no pkg-config files. The other two are fixing what Richard mentioned about guestfs subvolumes display Cédric Bosdonnat (3): configure: handle older version of ncurses api: add mountable_device and mountable_subvolume fish: fix btrfs subvolumes display in error case

These two functions allow the user to split the mountable strings into a device and a subvolume if any. See this thread on the mailing list for the rationale: https://www.redhat.com/archives/libguestfs/2016-February/msg00247.html --- generator/actions.ml | 25 +++++++++++++++++++++++++ po/POTFILES | 1 + src/Makefile.am | 1 + src/mountable.c | 48

These two functions allow the user to split the mountable strings into a device and a subvolume if any. See this thread on the mailing list for the rationale: https://www.redhat.com/archives/libguestfs/2016-February/msg00247.html --- generator/actions.ml | 26 ++++++++++++++++++++++++++ po/POTFILES | 1 + src/Makefile.am | 1 + src/mountable.c | 51

These two functions allow the user to split the mountable strings into a device and a subvolume if any. See this thread on the mailing list for the rationale: https://www.redhat.com/archives/libguestfs/2016-February/msg00247.html --- generator/actions.ml | 26 ++++++++++++++++++++++++++ po/POTFILES | 1 + src/Makefile.am | 1 + src/mountable.c | 51

Hi all, Here is version 2 of the patch series, including the changes for Pino's remarks. Cédric Bosdonnat (3): configure: handle older version of ncurses api: add mountable_device and mountable_subvolume fish: fix btrfs subvolumes display in error case fish/options.c | 28 ++++++++++++++++++++++++++- generator/actions.ml | 26 +++++++++++++++++++++++++

Hi there, Latest and greatest version including all new remarks from both Pino and Rich. Cédric Bosdonnat (3): configure: handle older version of ncurses api: add mountable_device and mountable_subvolume fish: fix btrfs subvolumes display in error case fish/options.c | 28 ++++++++++++++++++++++++++- generator/actions.ml | 26 +++++++++++++++++++++++++ m4/guestfs_libraries.m4

On Thu, 2016-02-25 at 19:10 +0000, Richard W.M. Jones wrote: > On Thu, Feb 25, 2016 at 05:50:57PM +0100, Pino Toscano wrote: > > When listing the subvolumes of a btrfs filesystem, ignore the > > default > > subvolume: we get the content of it when mounting the whole device > > (without specifying any particular subvolume), so avoid listing it > > twice. > >

On Fri, Jul 08, 2016 at 01:58:07PM +0300, Maxim Perevedentsev wrote: > On 07/07/2016 06:59 PM, Richard W.M. Jones wrote: > > > >However I'm not convinced that this means my statement before about > >set_uuid should take a Mountable instead of a Device is wrong. It > >could still be changed to take a Mountable, and either we'd have to > >document that

On Thu, Jul 07, 2016 at 06:04:14PM +0300, Maxim Perevedentsev wrote: > This is needed to skip btrfs subvolumes from output > of list_filesystems where device is needed. > --- > mllib/common_utils.ml | 10 ++++++++++ > mllib/common_utils.mli | 3 +++ > 2 files changed, 13 insertions(+) > > diff --git a/mllib/common_utils.ml b/mllib/common_utils.ml > index

On Thursday 07 July 2016 16:54:20 Richard W.M. Jones wrote: > On Thu, Jul 07, 2016 at 06:04:14PM +0300, Maxim Perevedentsev wrote: > > This is needed to skip btrfs subvolumes from output > > of list_filesystems where device is needed. > > --- > > mllib/common_utils.ml | 10 ++++++++++ > > mllib/common_utils.mli | 3 +++ > > 2 files changed, 13

This patcheset fixes errors in virt-sysprep and virt-sparsify. Here we have a common functionality: is_btrfs_subvolume. Doesn't it make sense to turn it into guestfs API? Also I found an issue. In 'virt-sysprep fs-uuids', the uuids for ALL filesystems are regenerated as many times as many roots are in guest. Is it done intentionally? Maxim Perevedentsev (3): mllib: add checking

I'm pleased to announce libguestfs 1.34, a library and set of tools for accessing and modifying virtual machine disk images. This release took about 8 months of work by many contributors. Amongst the new features are large performance improvements, substantial enhancements to virt-p2v & virt-v2v, better SELinux support, and APIs for doing forensic analysis of disk images. See the release

sparsify case: modified guestfs_is_lv mllib: fixed is_btrfs_subvolume Maxim Perevedentsev (3): mllib: add checking for btrfs subvolume lvm: modify guestfs_is_lv to take mountable sysprep: fix btrfs subvolume processing in fs-uuids daemon/lvm.c | 6 ++++-- generator/actions.ml | 6 +++--- mllib/common_utils.ml | 7 +++++++

On Tue, 2016-03-01 at 13:35 +0100, Pino Toscano wrote: > On Tuesday 01 March 2016 11:17:19 Cédric Bosdonnat wrote: [...] > > + if (asprintf (&p, "%s:/:subvol=%s", device, volume) == -1) { > > + perror ("asprintf"); > > + exit (EXIT_FAILURE); > > + } > > + } else { > > + p =