similar to: [PATCH 1/2] inspection: Find Ubuntu logo from an alternate location (RHBZ#1352761).

This patch series changes a small part of the library to use __attribute__((cleanup(...))) to automatically free memory when pointers go out of the current scope. In general terms this seems to be a small win although you do have to use it carefully. For functions where you can completely get rid of the "exit code paths", it can simplify things. For a good example, see the

From: Michael Scherer <misc at zarb.org> Without this, configure will always enable erlang, no matter what argument are passed. Now, we can disable it, even if configure still need the erlang compiler for some obscure reason. --- configure.ac | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 337a3ed..e0bed2f 100644 ---

See individual patches. Pino Toscano (3): inspect: bump size limit for Mageia guests inspect: factor out find_png helper function inspect: revamp icon extraction for *SUSE guests lib/inspect-icon.c | 39 +++++++++++++++++++++++++-------------- 1 file changed, 25 insertions(+), 14 deletions(-) -- 2.20.1

v1 -> v2: - Remove the unnecessary calls to guestfs_int_lazy_make_tmpdir in the final patch. Rich.

Miscellaneous small cleanups in lib/ directory. Rich.

Hi, the libguestfs library uses a number of external tools; for some of them, we search for them at build time, enabling some feature only if found, and later on assuming at runtime they are installed. However, the situation is more complex than that: - hardcoding the full path means that there is an incoherency in the way some of the tools are used, as some other tools (e.g. qemu-img) are

The icon is installed by x11-themes/gentoo-artwork, which is not installed by default (and most probably only on "desktop" installations), although it's the best hit so far... --- lib/inspect-icon.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/lib/inspect-icon.c b/lib/inspect-icon.c index 623591aa6..e785a2172 100644 --- a/lib/inspect-icon.c +++

In RHEL-based distros, the provided icons have (obviously) different sizes than the RHEL ones, used in icon_rhel as reference. Since 100K should be a reasonable threshold for avoid keeping a per-distro list of limits, just use it as only size limit. --- src/inspect-icon.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/inspect-icon.c b/src/inspect-icon.c index

Newer versions do not have the 24px distributor.png icon; OTOH they have the 48px version, so look for that one before the 24px one. Also, bump the size limit to 10K, as newer versions of the icon are bigger than 3K. --- lib/inspect-icon.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/lib/inspect-icon.c b/lib/inspect-icon.c index 0cc8e92ad..623591aa6 100644 ---

Hi, the libguestfs library uses a number of external tools; for some of them, we search for them at build time, enabling some feature only if found, and later on assuming at runtime they are installed. However, the situation is more complex than that: - hardcoding the full path means that there is an incoherency in the way some of the tools are used, as some other tools (e.g. qemu-img) are

v9 was here: https://www.redhat.com/archives/libguestfs/2017-July/msg00139.html This depends on these three series (the first two being single minor patches): https://www.redhat.com/archives/libguestfs/2017-July/msg00207.html https://www.redhat.com/archives/libguestfs/2017-July/msg00209.html https://www.redhat.com/archives/libguestfs/2017-July/msg00215.html There is no substantive change. I

This depends on the patch series "[PATCH 00/27] Reimplement many daemon APIs in OCaml." (https://www.redhat.com/archives/libguestfs/2017-July/msg00098.html) v8 was posted here: https://www.redhat.com/archives/libguestfs/2017-June/msg00274.html v9: - I split up the mega-patch into a more reviewable series of smaller, incremental patches. There are some other changes vs v8, but

This fixes almost everything. Note that it adds an extra commit which fixes the whole utf8/iconv business. It's probably better to list what isn't fixed: (1) I didn't leave the osinfo code around because I'm still haven't looked too closely at virt-builder-repository. Can't we just fetch this code from the git history when we need it? (2) I didn't change the way

v10: https://www.redhat.com/archives/libguestfs/2017-July/msg00245.html No actual change here, but I rebased and retested. Also this series now does not depend on any other patch series since everything else needed is upstream. Rich.

Use a 64px icon which is in the menu-icons-default package, hopefully part of the default installation of any flavour. Updates commit 9928296c1ca8df5bd8f108ed00039adc6468cac3. Thanks to: Xiang Hua Chen. --- lib/inspect-icon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/inspect-icon.c b/lib/inspect-icon.c index 84d4e4a..695f038 100644 --- a/lib/inspect-icon.c +++

Followup of commit a4ef6716b4119e476949c55f1bc12d81e735f0c0. --- lib/inspect-icon.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/lib/inspect-icon.c b/lib/inspect-icon.c index 5c7da0476..725af574b 100644 --- a/lib/inspect-icon.c +++ b/lib/inspect-icon.c @@ -67,6 +67,7 @@ static char *icon_cirros (guestfs_h *g, size_t *size_r); static char *icon_voidlinux (guestfs_h *g,

Use a better icon for RHEL guests, still provided by redhat-logos (or equivalent in downstream distributions), and which fits a better definition of logo for the distribution. Thanks to Ray Strode for the hints. --- lib/inspect-icon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/inspect-icon.c b/lib/inspect-icon.c index e785a2172..5c7da0476 100644 ---

v6 was posted here: https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html and this requires the utilities refactoring posted here: https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html Inspection is now complete[*], although not very well tested. I'm intending to compare the output of many guests using old & new virt-inspector to see if I can find any

Since Void Linux provides only an /etc/os-release with no VERSION_ID field, then special-case it to avoid that the os-release parsing ignore it. This provides basic distro identification, and icon. --- generator/actions.ml | 4 ++++ inspector/virt-inspector.rng | 1 + src/guestfs-internal.h | 1 + src/inspect-fs-unix.c | 14 ++++++++++++-- src/inspect-fs.c |

v5: https://www.redhat.com/archives/libguestfs/2017-June/msg00065.html Since v5, this now implements inspection almost completely for Linux and Windows guests. Rich.