similar to: Proposal to remove two virt-v2v command line options

The first two patches implement the change discussed here: https://www.redhat.com/archives/libguestfs/2016-April/msg00178.html The third patch fixes the mapping of inspection data to OVF VmType which was inherited directly from old virt-v2v and had never been changed. It had a number of problems. The fourth patch is only slightly related to the others. It adds an extra slow test to ensure that

Since Linux commit f663b5b38fff trimming vfat is now supported by Linux. This broke the test which assumed it was not supported. Use another filesystem (minix) which does not support trimming instead. Thanks: Daniel P. Berrangé and Pino Toscano. --- ...virt-sparsify-in-place-fstrim-unsupported.sh | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git

Since Linux commit f663b5b38fff trimming vfat is now supported by Linux. This broke the test which assumed it was not supported. Use another filesystem (minix) which does not support trimming instead. Thanks: Daniel P. Berrangé and Pino Toscano. --- ...est-virt-sparsify-in-place-fstrim-unsupported.sh | 13 ++++++------- tests/test-functions.sh | 10 ++++++++++ 2

On Wed, Sep 05, 2018 at 04:53:03PM +0100, Daniel P. Berrangé wrote: > On Wed, Sep 05, 2018 at 04:45:51PM +0100, Richard W.M. Jones wrote: > > On Wed, Sep 05, 2018 at 04:41:01PM +0100, Daniel P. Berrangé wrote: > > > On Wed, Sep 05, 2018 at 04:37:05PM +0100, Richard W.M. Jones wrote: > > > > > > > > Here's a fun one: > > > > > > >

This reverts the change made for RHBZ#1168144. The warning is now always displayed. It would be nice to make the warning actionable, but there is not a lot that end users can do since fstrim is such a complex topic interacting with all filesystem and storage layers. --- v2v/v2v.ml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/v2v/v2v.ml b/v2v/v2v.ml index

On Friday, 12 August 2016 10:37:29 CEST Richard W.M. Jones wrote: > This reverts the change made for RHBZ#1168144. The warning is now > always displayed. > > It would be nice to make the warning actionable, but there is not a > lot that end users can do since fstrim is such a complex topic > interacting with all filesystem and storage layers. > --- > v2v/v2v.ml | 6

On Friday, 12 August 2016 22:19:09 CEST Richard W.M. Jones wrote: > On Fri, Aug 12, 2016 at 04:50:31PM +0200, Pino Toscano wrote: > > On Friday, 12 August 2016 10:37:29 CEST Richard W.M. Jones wrote: > > > This reverts the change made for RHBZ#1168144. The warning is now > > > always displayed. > > > > > > It would be nice to make the warning

On Fri, Aug 12, 2016 at 04:50:31PM +0200, Pino Toscano wrote: > On Friday, 12 August 2016 10:37:29 CEST Richard W.M. Jones wrote: > > This reverts the change made for RHBZ#1168144. The warning is now > > always displayed. > > > > It would be nice to make the warning actionable, but there is not a > > lot that end users can do since fstrim is such a complex topic

On Wed, Sep 05, 2018 at 04:41:01PM +0100, Daniel P. Berrangé wrote: > On Wed, Sep 05, 2018 at 04:37:05PM +0100, Richard W.M. Jones wrote: > > > > Here's a fun one: > > > > + guestfish -N test-virt-sparsify-in-place-fstrim-unsupported.img=fs:vfat exit > > + virt-sparsify --in-place test-virt-sparsify-in-place-fstrim-unsupported.img > > + tee

The version libguestfs-winsupport installed is well 7.1-3.el7 and the qemu-kvm-rhev is 2.1.2-2.el7 In fact the qemu-img convert hangs. Alain Alain VONDRA Chargé d'exploitation des Systèmes d'Information Direction Administrative et Financière +33 1 44 39 77 76 UNICEF France 3 rue Duguay Trouin 75006 PARIS www.unicef.fr -----Message d'origine----- De : Richard W.M. Jones

The ioctl failure is not an error, but it's unexpected, and maybe hints at something deeper. What version of libguestfs-winsupport is installed? It should be 7.1-3.el7 (assuming this is RHEL 7), which has support for fstrim of aligned NTFS partitions. - - - Now on to the real problem ... 'qemu-img convert' is running, and then fails. Does it hang or crash? I would enable core

On Sat, Nov 30, 2019 at 01:12:31 +0100, ort_libvirt@bergersen.no wrote: > Hi! > > I need to convert a KVM virtual machine from LVM to a qcow2 image, and wonder if this is the best way to do it (*1): > [$] qemu-img convert -O qcow2 /dev/vg_name/lv_name/ /var/lib/libvirt/images/image_name.qcow2 > > If this is the best way to do this, will this keep the information on:

https://bugzilla.redhat.com/show_bug.cgi?id=1342398#c6 --- v2v/OVF.ml | 138 ++++++++++++++++++++++++++++++++++--------------------------- 1 file changed, 76 insertions(+), 62 deletions(-) diff --git a/v2v/OVF.ml b/v2v/OVF.ml index 8a6f13e..0599306 100644 --- a/v2v/OVF.ml +++ b/v2v/OVF.ml @@ -184,6 +184,15 @@ and get_ostype = function typ distro major minor arch product;

This *may* be required by some filesystems in order for fstrim to work. I'm not actually sure if this is true, but it's what virt-sparsify --in-place does, and that utility has been tested a lot more in regards to trimming. --- v2v/v2v.ml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/v2v/v2v.ml b/v2v/v2v.ml index 8365aae..8ae3dec 100644 --- a/v2v/v2v.ml +++

On Wed, Sep 05, 2018 at 04:37:05PM +0100, Richard W.M. Jones wrote: > > Here's a fun one: > > + guestfish -N test-virt-sparsify-in-place-fstrim-unsupported.img=fs:vfat exit > + virt-sparsify --in-place test-virt-sparsify-in-place-fstrim-unsupported.img > + tee test-virt-sparsify-in-place-fstrim-unsupported.log > [ 2.4] Trimming /dev/sda1 > [ 7.5] Sparsify in-place

On Wed, Sep 05, 2018 at 04:45:51PM +0100, Richard W.M. Jones wrote: > On Wed, Sep 05, 2018 at 04:41:01PM +0100, Daniel P. Berrangé wrote: > > On Wed, Sep 05, 2018 at 04:37:05PM +0100, Richard W.M. Jones wrote: > > > > > > Here's a fun one: > > > > > > + guestfish -N test-virt-sparsify-in-place-fstrim-unsupported.img=fs:vfat exit > > > +

Here's a fun one: + guestfish -N test-virt-sparsify-in-place-fstrim-unsupported.img=fs:vfat exit + virt-sparsify --in-place test-virt-sparsify-in-place-fstrim-unsupported.img + tee test-virt-sparsify-in-place-fstrim-unsupported.log [ 2.4] Trimming /dev/sda1 [ 7.5] Sparsify in-place operation completed with no errors + grep 'warning:.*fstrim'

Hi Richard, That didn't resolve the issue. Now I'm getting the following error. Please advice. *[root@kvm16 ~]#* virt-v2v -ic esx://10.16.32.13/?no_verify=1 yardqakvm -o rhev -os 10.16.32.16:/vm-images/export_domain --network rhevm libvirt error code: 42, message: Domain not found: No domain with name 'yardqakvm'

This option is needed by vdsm for writing the ovf to a specific directory. The default is current directory. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1176598 Signed-off-by: Shahar Havivi <shaharh@redhat.com> --- v2v/cmdline.ml | 5 +++++ v2v/output_vdsm.ml | 16 +++++++--------- v2v/output_vdsm.mli | 1 + v2v/test-v2v-o-vdsm-options.sh |

This option is needed by vdsm for writing the ovf to a specific directory. The default is current directory. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1176598 Signed-off-by: Shahar Havivi <shaharh@redhat.com> --- v2v/cmdline.ml | 5 +++++ v2v/output_vdsm.ml | 16 +++++++--------- v2v/output_vdsm.mli | 1 + v2v/test-v2v-o-vdsm-options.sh |