similar to: Malformed XML if LIBGUESTFS_HV is defined.

Hi, this series cleans up the Python sources, either static or generated, including also tests, to make them PEP 8 compliant; see https://www.python.org/dev/peps/pep-0008/ and tools like pep8. Almost all the issues reported by pep8 are fixed, reducing the issues from 3818 to 7. The changes should have no effect on the actual code, while it will help Python users with consistency with other

Fixes the majority of the pycodestyle issues in the Python bindings, leaving only an overly length line in setup.py. Add a simple optional pycodestyle-based test to avoid regressions in the future. Pino Toscano (7): python: PEP 8: adapt empty lines python: PEP 8: adapt whitespaces in lines python: tests: catch specific exception python: tests: improve variable naming python: tests:

Fixes all the pycodestyle issues in the Python bindings, overring one that does not make sense to change (and it's in setup.py, so almost irrelevant). Add a simple optional pycodestyle-based test to avoid regressions in the future. Pino Toscano (8): python: PEP 8: adapt empty lines python: PEP 8: adapt whitespaces in lines python: tests: catch specific exception python: tests:

Instead of running all the tests manually, the unittest module has a 'discovery' mode to run tests by importing them from a directory: this requires the tests to have different filenames, since they need to be imported as modules now (hence an empty __init__.py is added), and the current naming does not match the convention. Using unittest as loader/runner brings another change: tests

On Thu, Dec 12, 2019 at 11:01:02AM +0100, Vincent Danjean wrote: > [resend to the good (cloned) bug, sorry for the message in the original bug, > it was a mistake] > > Hi, > > On Thu, 5 Dec 2019 11:12:56 +0000 "Richard W.M. Jones" <rjones@redhat.com> wrote: > > I believe this is a new bug and nothing much to do with: > >

Verify the returned values of Python Object constructor functions are not NULL before adding them to a collection. This is particularly relevant when constructing Unicode strings in Python 3 as they will return NULL if non UTF-8 characters are present. Signed-off-by: Matteo Cafasso <noxdafox@gmail.com> --- generator/python.ml | 102 ++++++++++++++++++++++++++---------------

On 16.09.14 15:09, Richard W.M. Jones wrote: > On Tue, Sep 16, 2014 at 05:06:57PM +0300, Shahar Havivi wrote: > > I am using upstream qemu while using this local variables: > > export PATH=/home/shahar/git/qemu:$PATH > > export LIBGUESTFS_HV=/home/shahar/git/qemu/x86_64-softmmu/qemu-system-x86_64 > > > > Is that sufficient? > > Yup, upstream qemu should

On 16.09.14 14:21, Richard W.M. Jones wrote: > On Tue, Sep 16, 2014 at 04:04:02PM +0300, Shahar Havivi wrote: > > Hi, > > > > I am trying to convert from esx server to local directory a VM names CSB, > > Its build from source 77b371b18b6a7ad37105a595931514f542a04396 > > > > When running: > > LIBGUESTFS_BACKEND=direct ./run ./v2v/virt-v2v -ic

On 17.09.14 10:02, Richard W.M. Jones wrote: > On Wed, Sep 17, 2014 at 10:58:18AM +0300, Shahar Havivi wrote: > > On 16.09.14 15:09, Richard W.M. Jones wrote: > > > On Tue, Sep 16, 2014 at 05:06:57PM +0300, Shahar Havivi wrote: > > > > I am using upstream qemu while using this local variables: > > > > export PATH=/home/shahar/git/qemu:$PATH > > >

On Thu, Jul 31, 2014 at 03:32:18PM -0700, Zetan Drableg wrote: > Ok - > By the way, I looked into updating out KVM versions. Since we already > have so many KVM servers of this version in production, I can't easily > forklift update everything without much testing. > > exec /usr/libexec/qemu-kvm -s -S "$@" > > export LIBGUESTFS_HV=/root/work/qemu-wrapper

[Let's keep this on the mailing list] On Thu, Jul 31, 2014 at 02:48:25PM -0700, Zetan Drableg wrote: > Hi Richard, > I created qemu-wrapper: > #!/bin/bash -x > > exec gdbserver :1234 /usr/libexec/qemu-kvm "$@" gdbserver will end up debugging the qemu process, not the guest inside. This is not useful. You need to do something like: exec /usr/libexec/qemu-kvm -s

Make sure they can build also in no as-neede setups. Pino Toscano (1): utils: split string list functions in own file build: use split stringlist functions from common/utils utils/Makefile.am | 2 + utils/guestfs-stringlists-utils.h | 30 +++++ utils/guestfs-utils.h | 7 +- utils/stringlists-utils.c | 197 ++++++++++++++++++++++++++++++ utils/utils.c

- run bindtests.opt only if available - use ocamlc -custom - Don't try to install native code if it hasn't been built (Thanks to Olaf Hering) --- mllib/Makefile.am | 2 +- ocaml/Makefile.am | 7 ++++++- ocaml/examples/Makefile.am | 11 ++++------- ocaml/run-bindtests | 2 ++ 4 files changed, 13 insertions(+), 9 deletions(-) diff --git a/mllib/Makefile.am

qemu has supported virtio-serial since forever, and we depend on much newer features now, so testing for virtio-serial is pointless. In fact allowing a set of possible qemu binaries to be supplied is also pointless, since packagers or even people building from source know what qemu binary they want to use. Now the possible options for --with-qemu are: * --with-qemu=search (or --with-qemu

Some general comments on using the patch: * For libguestfs I chose to add -compat deprecated-input=reject,deprecated-output=hide This is only enabled in developer builds of libguestfs when we are running qemu directly (not via libvirt). The patch for this is attached. * What's the point/difference in having reject vs crash? * I hope that by hiding deprecated QAPI fields we may

On Wed, Sep 17, 2014 at 10:58:18AM +0300, Shahar Havivi wrote: > On 16.09.14 15:09, Richard W.M. Jones wrote: > > On Tue, Sep 16, 2014 at 05:06:57PM +0300, Shahar Havivi wrote: > > > I am using upstream qemu while using this local variables: > > > export PATH=/home/shahar/git/qemu:$PATH > > > export

On Sun, Sep 21, 2014 at 04:16:59PM +0300, Shahar Havivi wrote: > On 17.09.14 10:02, Richard W.M. Jones wrote: > > On Wed, Sep 17, 2014 at 10:58:18AM +0300, Shahar Havivi wrote: > > > On 16.09.14 15:09, Richard W.M. Jones wrote: > > > > On Tue, Sep 16, 2014 at 05:06:57PM +0300, Shahar Havivi wrote: > > > > > I am using upstream qemu while using this

Cast the value to the "int_type" representing the "long" value for test_rint64, so the test works again with Python 3. --- python/t/test090RetValues.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/python/t/test090RetValues.py b/python/t/test090RetValues.py index 7ff51f0..24d97b4 100644 --- a/python/t/test090RetValues.py +++

New option -compat lets you configure what to do when deprecated interfaces get used. This is intended for testing users of the management interfaces. It is experimental. -compat deprecated-input=<in-policy> configures what to do when deprecated input is received. Available policies: * accept: Accept deprecated commands and arguments (default) * reject: Reject them * crash: Crash

- use assertIsInstance, assertNotEqual, and assertIsNotNone as more specific checks (will produce better logging) - use assertRaises when expecting exceptions being thrown - when testing internal_test_rhashtable, instead of checking type and elements of the return values just check the return value as a whole (easier and already getting all the work needed by unittest) ---