Displaying 20 results from an estimated 500 matches similar to: "[PATCH] Reduce GUESTFS_PRIVATE usage"
2017 Jan 25
0
[PATCH v2 2/7] lib: Move utilities to new directory common/utils.
Just code motion.
This commit makes it clearer what is a utility and what is part of the
library. It also makes it clear that we should rename:
guestfs-internal-frontend.h -> utils.h
guestfs-internal-frontend-cleanups.h -> cleanups.h (?)
but this commit does not make that change.
---
.gitignore | 10 ++---
Makefile.am
2015 Oct 14
0
[PATCH 2/2] lib: Add comment and regression test for case where main process has large heap.
Thanks: Dan Berrangé for identifying the problem.
---
.gitignore | 1 +
src/command.c | 11 +++++++
tests/regressions/Makefile.am | 13 +++++++-
tests/regressions/test-big-heap.c | 69 +++++++++++++++++++++++++++++++++++++++
4 files changed, 93 insertions(+), 1 deletion(-)
create mode 100644 tests/regressions/test-big-heap.c
diff --git
2017 Jun 15
0
[PATCH v6 05/41] utils: Split out cleanups into common/cleanups.
Those cleanups which only depend on libc, gnulib or libxml2 are split
out into a separate common/cleanups directory.
---
.gitignore | 3 +-
Makefile.am | 4 +-
align/Makefile.am | 2 +
builder/Makefile.am | 4 +
cat/Makefile.am
2015 Oct 14
2
[PATCH 1/2] lib: info: Move common code for setting child rlimits.
This is almost just refactoring, but I also set the memory
limit to really 1 GB, and not 1×10⁹.
---
src/info.c | 27 +++++++++++++++------------
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/src/info.c b/src/info.c
index d7f45f0..616ef50 100644
--- a/src/info.c
+++ b/src/info.c
@@ -56,6 +56,7 @@ static yajl_val get_json_output (guestfs_h *g, const char *filename);
static char
2017 Jan 20
5
[PATCH 0/5] Rename src/ to lib/ and move common code to common/
This patch series moves some files and directories around but is only
code motion (or supposed to be).
A new directory, common/, is created for all of the common code which
is currently shared in random ways between parts of the project.
And src/ becomes lib/ (the largest change, but mostly mechanical).
In full this series makes the following changes:
src/libprotocol -> common/protocol
2013 Jan 30
1
[PATCH] Make internal-only functions and structures private
Certain functions are intended to be internal only, but we currently
export them anyway. This change moves them into a separate section of
guestfs.h protected by a GUESTFS_PRIVATE variable. This change also
enables private structs, but doesn't implement any.
This change only affects the C api. Language bindings aren't affected,
but probably should be in the future.
---
align/Makefile.am
2017 Jan 25
10
[PATCH v2 0/7] Rename src/ to lib/ and move common code to common/
Previous patch series was posted here:
https://www.redhat.com/archives/libguestfs/2017-January/msg00059.html
v2 simply extends this patch series to cover the extra directories
common/edit, common/progress, common/windows and common/parallel.
The only remaining item is to consider whether we should rename mllib
to something else, mlcommon was my suggestion.
Rich.
2017 Aug 10
3
[PATCH] ruby: fix order of CFLAGS
Shuffle the order of the various CFLAGS used when building the Ruby
extension: first the flags from manywarnings (gnulib), then libguestfs
own CFLAGS, and then -DGUESTFS_PRIVATE=1 (so it is not overridden).
This matches also what happens in automake parts, and makes it possible
to override any flags from manywarnings also in the Ruby extension.
---
ruby/ext/guestfs/extconf.rb.in | 5 +++--
1
2019 Apr 23
8
[PATCH 0/7] Make deprecation warnings more prominent
Since there are deprecated APIs, make sure that users notice they are
deprecated in more prominent ways than done so far:
- using deprecated C functions now warns by default
- it is possible to use the C library making sure no deprecated function
is ever used
- Python/Ruby/Perl scripts now get warning messages (configured
according to their own systems) when deprecated functions are used
The
2017 Jun 19
0
[PATCH v7 10/13] utils: Split out structs cleanups and printing into common/structs.
These won't be used by the daemon, so interferes with us using
common/utils in the daemon, so they are moved to a different library.
---
.gitignore | 8 +++---
Makefile.am | 4 ++-
align/Makefile.am | 2 ++
align/scan.c | 1 +
cat/Makefile.am | 10 ++++++++
2017 Jan 25
0
[PATCH v2 1/7] lib: Share common protocol and errnostring libraries with the library and daemon.
This commit, which is just code motion, moves the common XDR protocol
code (libprotocol) and the common errno handling (liberrnostring) into
libraries which are each built once and shared between the library and
daemon.
---
.gitignore | 20 +++++--------
Makefile.am | 1 +
common/errnostring/Makefile.am | 45 +++++++++++++++++++++++++++++
2017 May 04
0
Re: [PATCH v1 2/2] build: add ./configure --with-guestfs-path option
On Thu, May 04, 2017 at 02:20:29PM +0300, Pavel Butsykin wrote:
> Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com>
> ---
> lib/Makefile.am | 1 -
> m4/guestfs_appliance.m4 | 11 +++++++++++
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/lib/Makefile.am b/lib/Makefile.am
> index 063706f8f..18b6dd678 100644
> ---
2016 Feb 26
1
Displaying mountables in the error output of guestfish etc
Cédric pointed out this problem we have:
$ guestmount -a /var/lib/libvirt/images/sles12sp1-pv.img -m '/dev/sda1:/:subvol=.snapshots/2/snapshot:btrfs' /mnt
libguestfs: error: mount_vfs: /dev/sda1 on / (options: 'subvol=.snapshots/2/snapshot'): mount: mount(2) failed: No such file or directory
guestmount: '/dev/sda1' could not be mounted.
guestmount: Check mount(8) man page
2013 May 16
3
[PATCH] Use pkg-config for Python
At least libpython2.7-dev and libpython3.3-dev on current
Debian/unstable ship with pkg-config files. As with the pkg-config
check for Lua, we check for versioned and an unversioned .pc files.
---
configure.ac | 35 ++++++++++++++++++++---------------
python/Makefile.am | 2 +-
2 files changed, 21 insertions(+), 16 deletions(-)
diff --git a/configure.ac b/configure.ac
index
2015 Feb 03
1
Re: make install ignoring PREFIX for bash_completion
> > After using 'python sdist', can't you use the tarball (in python/dist)
> > in order to create a venv directly?
>
> I think I will be able to install the python library in the venv using
> the tarball. However, won't my liguestfs application require some of
> the binaries installed as part of 'make install' for running? I am
> trying to not
2019 May 28
1
[PATCH] build: build C sources using OCaml API with CAML_NAME_SPACE
This way no non-namespaced OCaml C symbols are used, reducing the risk
of clashes with other code.
The only exception is ocaml-augeas, which does not build with
CAML_NAME_SPACE; it will be fixed upstream, and it affects only
ocaml-augeas itself.
---
builder/Makefile.am | 2 ++
common/mllibvirt/Makefile.am | 1 +
common/mlpcre/Makefile.am | 1 +
common/mlprogress/Makefile.am | 1 +
2013 Feb 18
4
Some fixes for building the Debian package for 1.20.2
I needed to add a few patches to be able to build libguestfs 1.20.2
out of tree. Mostly srcdir/builddir issues -- I think that I had
posted something for building the daemon before.
As mentioned on IRC, I found that compiling (Ruby bindings) caused
config.h file shipped with the Ruby headers to be included rather than
${builddir}/config.h. This can be fixed because the relevant checks
can be
2017 Jun 09
12
[PATCH 00/12] Refactor utility functions.
This turned out to be rather more involved than I thought.
We have lots of utility functions, spread all over the repository,
with not a lot of structure. This moves many of them under common/
and structures them so there are clear dependencies.
This doesn't complete the job by any means. Other items I had on my
to-do list for this change were:
- Split up mllib/common_utils into:
-
2015 Oct 23
1
[PATCH v3] perl: Switch to using Module::Build.
version 3:
- Split requires into configure_requires/etc.
- Use lists for extra_compiler_flags, extra_linker_flags.
- Suppress .packlist file.
- Set the release_status field.
Rich.
2019 Dec 20
0
[common/libguestfs PATCH 2/2] build: use split stringlist functions from common/utils
The OCaml and Python bindings directly use the utils.c source in
common/utils, mostly for guestfs_int_free_string_list. That source
contained also functions using gnulib functions, however without
linking to gnulib. When building with default build flags (e.g. without
as-needed mode), the gnulib symbols cannot be resolved, leading to
unusable OCaml and Python libraries.
As solution, update the