similar to: [PATCH] v2v: Copy *.dll files since they can be part of the driver (RHBZ#1311373).

Since v1: - Fix a bug in the calculation of lc_basename. By luck this doesn't affect anything given the contents of the current ISO. - Don't copy the WdfCoInstaller*.dll files. Rich.

On Fri, Mar 04, 2016 at 01:58:12PM +0300, Roman Kagan wrote: > On Fri, Mar 04, 2016 at 09:11:00AM +0000, Richard W.M. Jones wrote: > > Commit 47b5f245bec908f803f0a89c3b1e3166cfe33aad originally introduced > > the filtering of files by extension. For the QXL driver at least, > > there is a qxldd.dll file which is part of the driver, so that must be > > copied to the

v2 -> v3 - Don't make a special case for WdfCoInstaller* files. There is a difference of opinion about whether copying these is necessary, but it seems like it is not harmful. Rich.

On Fri, Mar 04, 2016 at 09:11:00AM +0000, Richard W.M. Jones wrote: > Commit 47b5f245bec908f803f0a89c3b1e3166cfe33aad originally introduced > the filtering of files by extension. For the QXL driver at least, > there is a qxldd.dll file which is part of the driver, so that must be > copied to the guest as well. > > This patch will cause 'WdfCoInstaller*.dll' files to be

Windows QXL drivers include also qxldd.dll which used to get filtered out and not copied over into the guest. As a result QXL driver failed to install due to a missing file. Correct that, and update the tests accordingly. Signed-off-by: Roman Kagan <rkagan@virtuozzo.com> --- v2v/fake-virtio-win/drivers/i386/Win7/qxldd.dll | 1 + v2v/test-v2v-in-place.sh | 1 +

On Tue, Oct 27, 2015 at 12:02:40PM +0000, Richard W.M. Jones wrote: > On Tue, Oct 27, 2015 at 02:08:42PM +0300, Roman Kagan wrote: > > On Tue, Oct 27, 2015 at 09:12:41AM +0000, Richard W.M. Jones wrote: > > > On Mon, Oct 26, 2015 at 09:00:03PM +0300, Roman Kagan wrote: > > > > Windows QXL drivers include also qxldd.dll which used to get filtered > > > >

On Tue, Oct 27, 2015 at 09:12:41AM +0000, Richard W.M. Jones wrote: > On Mon, Oct 26, 2015 at 09:00:03PM +0300, Roman Kagan wrote: > > Windows QXL drivers include also qxldd.dll which used to get filtered > > out and not copied over into the guest. As a result QXL driver failed > > to install due to a missing file. > > (* Skip files without specific extensions. *)

On Wed, Nov 07, 2018 at 12:53:20PM +0100, Tomáš Golembiovský wrote: > Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> > --- > v2v/convert_linux.ml | 2 ++ > v2v/windows_virtio.ml | 30 ++++++++++++++++++++++++++++++ > v2v/windows_virtio.mli | 4 ++++ > 3 files changed, 36 insertions(+) > > diff --git a/v2v/convert_linux.ml b/v2v/convert_linux.ml >

There was no source directory for EL8 guest agent (only EL6 and EL7). RHBZ#1791802 Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> --- v2v/windows_virtio.ml | 1 + 1 file changed, 1 insertion(+) diff --git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml index 5ec7664b..86bc8c0a 100644 --- a/v2v/windows_virtio.ml +++ b/v2v/windows_virtio.ml @@ -192,6 +192,7 @@ and

There was no source directory for EL8 guest agent (only EL6 and EL7). RHBZ#1791802 Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> --- v2v/windows_virtio.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml index 5ec7664b..6ddc488a 100644 --- a/v2v/windows_virtio.ml +++ b/v2v/windows_virtio.ml @@ -192,7 +192,7 @@ and

When trying to install files from virtio-win as directory, check for directory existance using absolute paths. Otherwise, is_directory is called on relative paths such as "linux/el7" which obviously do not exist. Fixes commit 1c85b64c1c3a4d5267b952102375cb78f18a85c4. --- v2v/windows_virtio.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v2v/windows_virtio.ml

Some virtio-win drivers contain more files than just *.{cat,inf,sys}. They are filtered out currently, which prevents the drivers from being installed by PnP. Stop filtering driver files by extension, and copy all of them instead. Signed-off-by: Roman Kagan <rkagan at virtuozzo.com> --- v2v/windows_virtio.ml | 11 ----------- 1 file changed, 11 deletions(-) diff --git

Now that all the stuff related to Windows virtio drivers has been moved into a dedicated module, it makes sense to move the definition of virtio_win there, too, and stop passing it around as a parameter. Signed-off-by: Roman Kagan <rkagan@virtuozzo.com> --- v2v/convert_windows.ml | 9 +-------- v2v/windows_virtio.ml | 13 ++++++++++--- v2v/windows_virtio.mli | 2 +- 3 files changed, 12

Thanks: Steven Rosenberg --- v2v/windows_virtio.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml index 59b0bf493..56c7a6757 100644 --- a/v2v/windows_virtio.ml +++ b/v2v/windows_virtio.ml @@ -338,7 +338,7 @@ and copy_from_virtio_win g inspect srcdir destdir filter missing = ) paths ) ) - else if is_regular_file

Support virtio drivers for Windows Server 2016 once they are available. Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> --- v2v/windows_virtio.ml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml index 354aa19..334e347 100644 --- a/v2v/windows_virtio.ml +++ b/v2v/windows_virtio.ml @@ -330,6 +330,8 @@ and

On Thursday, 21 November 2019 12:11:01 CET Tomáš Golembiovský wrote: > The detection was incorrectly matching only 32-bit installer on all > architectures. > > Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> > --- > v2v/windows_virtio.ml | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/v2v/windows_virtio.ml

changes in v5: - simplified expression in copy_drivers - new commit fixing path constructions - indentation fixes changes in v4: - fix call to install_local changes in v2: - moved copy_drivers above copy_files - renamed copy_files to copy_from_virtio_win - renamed install to install_local - use rpm instead of yum This installs packages with QEMU Guest Agent when converting Linux machine. The

On Sat, Jan 26, 2019 at 01:19:58PM +0100, Tomáš Golembiovský wrote: > The debug message was slightly changed too to better match the similar > message for ISO case. It refers to the root directory instead of the > specific subdirectory inside guest tools. > > Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> > --- > v2v/windows_virtio.ml | 6 +++--- > 1 file

changes in v2: - moved copy_drivers above copy_files - renamed copy_files to copy_from_virtio_win - renamed install to install_local - use rpm instead of yum This installs packages with QEMU Guest Agent when converting Linux machine. The packages should be available on guest tools ISO. The patches work "as-is" but probably deserve some more attention: - it is "abusing"

On Wed, 7 Nov 2018 15:31:56 +0000 "Richard W.M. Jones" <rjones@redhat.com> wrote: > On Wed, Nov 07, 2018 at 12:53:17PM +0100, Tomáš Golembiovský wrote: > > changes in v3: > > - fix call to install_local > > > > changes in v2: > > - moved copy_drivers above copy_files > > - renamed copy_files to copy_from_virtio_win > > - renamed