similar to: [PATCH] php: restructure and expand tests

So far the failure of some test would have not reported a non-zero return value by run-tests.php. Since now all the PHP tests pass, we can ask for failures to be fatal, by exporting REPORT_EXIT_STATUS=1 for run-tests.php. --- php/run-php-tests.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/php/run-php-tests.sh b/php/run-php-tests.sh index 6f9ae10..e498987 100755 ---

From: Pino Toscano <ptoscano at redhat.com> Move unsetting of LIBGUESTFS_DEBUG & LIBGUESTFS_TRACE into the php-for-tests.sh wrapper. Fixes commit 0d69eab98f0bd5dd2d218ce5adcafdeb13f9d90d. --- php/extension/php-for-tests.sh.in | 12 ++++++++++++ php/run-php-tests.sh | 12 ------------ 2 files changed, 12 insertions(+), 12 deletions(-) diff --git

This reverts commit 0d69eab98f0bd5dd2d218ce5adcafdeb13f9d90d. --- php/run-php-tests.sh | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/php/run-php-tests.sh b/php/run-php-tests.sh index 80758bd..e5cfc0d 100755 --- a/php/run-php-tests.sh +++ b/php/run-php-tests.sh @@ -28,13 +28,10 @@ cd extension # won't get passed down to the script. Furthermore,

I've pushed 10 commits which just clean up errors found by 'make syntax-check'. The remaining syntax-check errors are attached below. I think many of them are false alarms. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages.

Generate a simple bindtests test for the PHP binding, so it is possible to easily test all the argument types. Unlike the bindtests for other languages, optional arguments are not tested, due to the limitations of optional arguments in PHP (or maybe they way we implement them). --- .gitignore | 1 + generator/bindtests.ml | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++

... and why they are (probably) not errors. > bindtextdomain > daemon/guestfsd.c > erlang/erl-guestfs-proto.c > examples/copy_over.c > examples/create_disk.c > examples/display_icon.c > examples/inspect_vm.c > examples/mount_local.c > examples/virt-dhcp-address.c > tests/c-api/test-add-drive-opts.c > tests/c-api/test-add-libvirt-dom.c >

Introduce a new kind of bindings tests, 090-retvalues, to check all the possible return values in bindings; start implementing them for scripting languages such as GObject introspection, Perl, PHP, Python, and Ruby, reusing existing implementations where existing. --- docs/guestfs-hacking.pod | 1 + gobject/Makefile.am | 4 +-

Useful because it tests returning a single structure. --- docs/guestfs-hacking.pod | 1 + ocaml/Makefile.am | 2 ++ ocaml/t/guestfs_080_version.ml | 27 +++++++++++++++++++++++++++ perl/t/080-version.t | 36 ++++++++++++++++++++++++++++++++++++ 4 files changed, 66 insertions(+) create mode 100644 ocaml/t/guestfs_080_version.ml create mode 100644

If you have a struct containing ?field?, eg: type t = { field : int } then previously to pattern-match on this type, eg. in function parameters, you had to write: let f { field = field } = (* ... use field ... *) In OCaml >= 3.12 it is possible to abbreviate cases where the field being matched and the variable being bound have the same name, so now you can just write: let f {

--- ocaml/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am index ea41377..10a38f7 100644 --- a/ocaml/Makefile.am +++ b/ocaml/Makefile.am @@ -111,10 +111,11 @@ test_progs_bc = \ t/guestfs_040_create_multiple.bc \ t/guestfs_050_handle_properties.bc \ t/guestfs_060_explicit_close.bc \ - t/guestfs_065_implicit_close.bc \

This rather complex set of patches allow non-optargs functions to gain optional arguments, while preserving source and binary backwards compatibility. The problem is that we cannot add an optional argument to an existing function. For example, we might want to add flags to the 'lvresize' API which currently has no optional arguments.

Hi, I have a few corrections for OPENssh-2.9p1 solaris packaging. I use to configure: setenv CFLAGS -I/opt/local/include setenv LDFLAGS "-R/opt/JGMAzlib/lib -L/opt/JGMAzlib/lib" ./configure --prefix=/opt/OPENssh --with-tcp-wrappers --sysconfdir=/etc/opt/OPENssh --localstatedir=/var/opt/OPENssh --with-pid-dir=/var/opt/OPENssh/run --with-ssl-dir=/opt/OPENssl --with-ipv4-default

Reported by Nikos Skalkotos https://aur.archlinux.org/packages/libguestfs/ --- Makefile.am | 2 +- po/POTFILES | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 5defbce..663958d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -320,7 +320,7 @@ po/POTFILES: configure.ac rm -f $@ $@-t cd $(srcdir); \ find $(DIST_SUBDIRS) -name '*.c' -o

If the connection is not local, paths of disks will refer to the remote host, which were mistakenly handled as local paths (in the best case failing to open a non-existing disk, and in the worst case opening a different disk!). In case the disks are remote resources like ssh or ceph, nothing guarantees that the hostname can be reached from the local machine, or even that it is actually the same on

Hopefully this time ...

Add sort of "headers" to split most of the logical sections of the configure, so it is easier to get feedback on the progress of configure. --- configure.ac | 46 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+) diff --git a/configure.ac b/configure.ac index 7f9c1dac0..5ccf6f821 100644 --- a/configure.ac +++ b/configure.ac @@ -76,11 +76,15 @@

For v6: This is mainly just a rebase, but I have also added tests in the ocaml/ language bindings directory, and for all the OCaml-written virt tools. Rich.

Per my previous email: https://www.redhat.com/archives/libguestfs/2017-September/msg00203.html I'd like to talk about requiring a more modern version of the OCaml compiler. These commits show some of the code changes which would be possible with OCaml >= 3.12 [which it turns out we already require by accident] and also with OCaml >= 4.02. The latter is my favoured option. Rich.

v7: The only changes since v6 are those suggested by Pino in the review of v5.

I should probably start by saying this patch series isn't ready for review yet. This patch series adds a test harness to libguestfs. It allows us to run the tests outside the ordinary 'make check' path in the build tree. In particular, you can use this to run tests when libguestfs has been installed. 'make check' and the other 'make check-*' rules still work. The