similar to: [PATCH 1/2] tmpdirs: centralize permissions handling

Revert "tmpdirs: Blame systemd because su is broken." This reverts commit 9464304d7a6b9b01e9eee32620ef3831e2b10875. Replace with an actionable error message. --- lib/tmpdirs.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/lib/tmpdirs.c b/lib/tmpdirs.c index bda3ee694..804c58be0 100644 --- a/lib/tmpdirs.c +++ b/lib/tmpdirs.c @@ -180,18 +180,22 @@

--- lib/tmpdirs.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/tmpdirs.c b/lib/tmpdirs.c index 605bf90fb..bda3ee694 100644 --- a/lib/tmpdirs.c +++ b/lib/tmpdirs.c @@ -24,6 +24,7 @@ #include <stdio.h> #include <stdlib.h> +#include <errno.h> #include <sys/types.h> #include <sys/stat.h> #include <libintl.h> @@ -185,7

--- src/tmpdirs.c | 45 ++++++++++++++++++++++++++++++++++----------- 1 file changed, 34 insertions(+), 11 deletions(-) diff --git a/src/tmpdirs.c b/src/tmpdirs.c index afa3dd4..293e4ea 100644 --- a/src/tmpdirs.c +++ b/src/tmpdirs.c @@ -16,6 +16,10 @@ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ +/** + * Handle temporary directories. + */ + #include

Extract the bit of code for lazy creation of a temporary directory, so it can be used for more directories as well. This is just code motion, with no behaviour changes. --- src/tmpdirs.c | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/src/tmpdirs.c b/src/tmpdirs.c index 9154d8b..2ae9c74 100644 --- a/src/tmpdirs.c +++ b/src/tmpdirs.c @@ -119,6

Introduce an internal helper to create paths for sockets; will be useful for changing later the logic for placing sockets. --- src/guestfs-internal.h | 1 + src/launch-direct.c | 4 +++- src/launch-libvirt.c | 10 ++++++---- src/launch.c | 15 +++++++++++++++ 4 files changed, 25 insertions(+), 5 deletions(-) diff --git a/src/guestfs-internal.h b/src/guestfs-internal.h index

Introduce a new read-only API to get a path where to store temporary sockets: this is different than tmpdir, as we need short paths for sockets (due to sockaddr_un::sun_path), and is either XDG_RUNTIME_DIR if set, or /tmp. Adapt guestfs_int_create_socketname to create sockets in that location, checking whether the resulting path still fits in the limited buffer. Furthermore, print sockdir and

Introduce a new read-only API to get a path where to store temporary sockets: this is different from tmpdir, as we need short paths for sockets (due to sockaddr_un::sun_path), and it is either XDG_RUNTIME_DIR if set, or /tmp; adapt guestfs_int_create_socketname to create sockets in that location. Furthermore, print sockdir and XDG_RUNTIME_DIR in test-tool for debugging. --- fish/guestfish.pod

On Wed, Feb 03, 2016 at 01:17:42PM +0100, Pino Toscano wrote: > Introduce a new read-only API to get a path where to store temporary > sockets: this is different from tmpdir, as we need short paths for > sockets (due to sockaddr_un::sun_path), and it is either > XDG_RUNTIME_DIR if set, or /tmp; adapt guestfs_int_create_socketname > to create sockets in that location. > >

Introduce an internal helper to create paths for sockets -- will be useful for changing later the logic for placing sockets. Futhermore, check that the length of sockets won't overflow the buffer for their filenames. --- src/guestfs-internal.h | 1 + src/launch-direct.c | 4 +++- src/launch-libvirt.c | 10 ++++++---- src/launch.c | 17 +++++++++++++++++ 4 files changed, 27

The API for UNIX sockets limits the path to a static size (usually 104 or 108 characters, NULL included), which is internally represented as UNIX_PATH_MAX. If the temporary directory set is long enough (e.g. when running tools as uninstalled, using "run") then these socket paths get trucated, if not even cause failures when binding the sockets. Introduce a new internal API to create

On Fri, Jan 29, 2016 at 07:25:30PM +0100, Pino Toscano wrote: > The API for UNIX sockets limits the path to a static size (usually 104 > or 108 characters, NULL included), which is internally represented as > UNIX_PATH_MAX. If the temporary directory set is long enough (e.g. > when running tools as uninstalled, using "run") then these socket paths > get trucated, if not

On 21/08/15 22:46, Andrew Neuschwander wrote: > On 08/21/2015 02:04 PM, Leon Fauster wrote: >> Am 21.08.2015 um 21:08 schrieb ????????? ???????? <nevis2us at infoline.su>: >>>> On CentOS 7, I'm building a large C++ package with rpmbuild. Arachne >>>> (https://www.broadinstitute.org/crd/wiki/index.php/Arachne_Main_Page). >>>> During the

Puppeteers, I''ve seen things in the documentation to make me think this is possible but I''m not sure how to implement it. Here''s what I''d like to do: puppetd pulls down a config file, say httpd.conf BEFORE puppetd moves it to $path, I''d like to have it check it''s integrity with apachectl configtest IF configtest passes, then puppetd should

Am 21.08.2015 um 21:08 schrieb ????????? ???????? <nevis2us at infoline.su>: >> On CentOS 7, I'm building a large C++ package with rpmbuild. Arachne >> (https://www.broadinstitute.org/crd/wiki/index.php/Arachne_Main_Page). >> During the debuginfo extraction stage, I get the following error: >> + /usr/lib/rpm/find-debuginfo.sh --strict-build-id -m --run-dwz

Hey all, I've downloaded the latest CentOS 5.0 and the md5sums look good. I loop-back mounted the ISOs and pulled all of the RPMs out into a single dir. I have an existing PXE environment with several different distros to which I added 5.0. RPMs are served from my HTTPS server. I used the isolinux.cfg that was provided and all *looks* good. The problem is that on 4 *very* different

This drops all FUA and flush requests. --- filters/fua/nbdkit-fua-filter.pod | 27 +++++++++++++++++---- filters/fua/fua.c | 39 +++++++++++++++++++++++++++---- tests/test-fua.sh | 33 ++++++++++++++++---------- 3 files changed, 79 insertions(+), 20 deletions(-) diff --git a/filters/fua/nbdkit-fua-filter.pod b/filters/fua/nbdkit-fua-filter.pod index

On Monday 08 February 2016 19:34:10 Richard W.M. Jones wrote: > On Wed, Feb 03, 2016 at 01:17:42PM +0100, Pino Toscano wrote: > > Introduce a new read-only API to get a path where to store temporary > > sockets: this is different from tmpdir, as we need short paths for > > sockets (due to sockaddr_un::sun_path), and it is either > > XDG_RUNTIME_DIR if set, or /tmp; adapt

This is largely code motion. --- src/appliance.c | 40 +++++++----------------------------- src/guestfs-internal.h | 1 + src/tmpdirs.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 63 insertions(+), 33 deletions(-) diff --git a/src/appliance.c b/src/appliance.c index 2cf6374..d293c2b 100644 --- a/src/appliance.c +++ b/src/appliance.c @@ -48,7 +48,7

Error out early if the path to the socket will not fit into sockaddr_un::sun_path, as we will not be able to connect to it. --- src/launch-unix.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/launch-unix.c b/src/launch-unix.c index 740c554..973e14b 100644 --- a/src/launch-unix.c +++ b/src/launch-unix.c @@ -47,6 +47,12 @@ launch_unix (guestfs_h *g, void *datav, const char

Doing qemu feature detection in the direct backend takes ~100ms because we need to run `qemu -help' and `qemu -devices ?', and each of those interacts with glibc's very slow link loader. Fixing the link loader is really hard. Instead memoize the output of those two commands. This patch series first separates all the code dealing with qemu into a separate module (src/qemu.c) and