similar to: [PATCH] New API: part_get_disk_guid and part_set_disk_guid.

Some OSes (e.g. Windows Server 2012 R2) fail to boot if the disk GPT GUID has changed. To preserve disk guid e.g. during virt-resize, we need a way to get/set disk GUIDs. --- daemon/parted.c | 60 ++++++++++++++++++++++++++++++++++++++++++++++++++++ generator/actions.ml | 37 ++++++++++++++++++++++++++++++++ src/MAX_PROC_NR | 2 +- 3 files changed, 98 insertions(+), 1 deletion(-) diff

Some OSes (e.g. Windows Server 2012 R2) fail to boot after virt-resize due to changed disk guid. To fix it, we add new APIs: part_get_disk_guid part_set_disk_guid part_set_disk_guid_random We also preserve disk GUID in virt-resize. Maxim Perevedentsev (3): New API: part_get_disk_guid and part_set_disk_guid. New API: part_set_disk_guid_random. resize: preserve GPT disk GUID.

New APIs: part_set_gpt_type part_get_gpt_type --- appliance/packagelist.in | 1 + daemon/parted.c | 129 +++++++++++++++++++++++++++++++++++++++++++++++ generator/actions.ml | 30 +++++++++++ generator/tests_c_api.ml | 7 +++ generator/types.ml | 5 ++ src/MAX_PROC_NR | 2 +- 6 files changed, 173 insertions(+), 1 deletion(-) diff --git

Provides a way to set a new randomly-generated GUID to disk. --- daemon/parted.c | 15 +++++++++++++++ generator/actions.ml | 15 +++++++++++++++ src/MAX_PROC_NR | 2 +- 3 files changed, 31 insertions(+), 1 deletion(-) diff --git a/daemon/parted.c b/daemon/parted.c index 40f9676..22cd92b 100644 --- a/daemon/parted.c +++ b/daemon/parted.c @@ -988,3 +988,18 @@ do_part_set_disk_guid

On Wed, Sep 26, 2018 at 09:57:22AM +0200, Fabien Dupont wrote: > Hi, > > There has been discussion about the OpenStack output and Richard asked for > a public thread on this list, so here it is. > > For v2v from VMware to RHV, there is a Python script that does some extra > steps to create the virtual machine after the disks have been converted. We > want to have the same

Hi, There has been discussion about the OpenStack output and Richard asked for a public thread on this list, so here it is. For v2v from VMware to RHV, there is a Python script that does some extra steps to create the virtual machine after the disks have been converted. We want to have the same behavior for OpenStack, i.e. have virt-v2v create the instance once the volumes have been created.

On Wed, Sep 26, 2018 at 11:39 AM Richard W.M. Jones <rjones@redhat.com> wrote: > On Wed, Sep 26, 2018 at 09:57:22AM +0200, Fabien Dupont wrote: > > Hi, > > > > There has been discussion about the OpenStack output and Richard asked > for > > a public thread on this list, so here it is. > > > > For v2v from VMware to RHV, there is a Python script that

virt-resize didn't preserve the per-partition GPT GUID. Now that guests using UEFI are becoming common (basically it's the default on aarch64) we need to take into account that sometimes the partition GUID is used by the bootloader NVRAM variables to identify the boot partition, so it must be preserved across resize. This bug caused the 'virt-builder --size' option to fail on

This action moves second(backup) GPT header to the end of the disk. It is usable in in-place image expanding, since free space after second GPT header is unusable. To use additional space, we have to move second header. This is what sgdisk -e does. However, sgdisk -e may perform additional actions if the partition table has unexpected params (e.g. if we call sgdisk -e /dev/sda1, it may fix

This action moves second(backup) GPT header to the end of the disk. It is usable in in-place image expanding, since free space after second GPT header is unusable. To use additional space, we have to move second header. This is what sgdisk -e does. However, sgdisk -e may perform additional actions if the partition table has unexpected params (e.g. if we call sgdisk -e /dev/sda1, it may fix

Please take a look. This feature is necessary for in-place image expanding. On 12/01/2015 06:28 PM, Maxim Perevedentsev wrote: > This action moves second(backup) GPT header to the end of the disk. > It is usable in in-place image expanding, since free space after > second GPT header is unusable. To use additional space, we have > to move second header. This is what sgdisk -e does.

This action moves second(backup) GPT header to the end of the disk. It is usable in in-place image expanding, since free space after second GPT header is unusable. To use additional space, we have to move second header. This is what sgdisk -e does. However, sgdisk -e may perform additional actions if the partition table has unexpected params (e.g. if we call sgdisk -e /dev/sda1, it may fix

GUESTFSD_EXT_CMD was used by OpenSUSE to track which external commands are run by the daemon and package those commands into the appliance. It is no longer used by recent SUSE builds, so remove it. Thanks: Pino Toscano, Olaf Hering. --- daemon/9p.c | 3 +- daemon/available.c | 7 +-- daemon/base64.c | 6 +-- daemon/blkid.c | 10 ++---

add udev_settle calls to print_partition_table and sgdisk_info_extract_field because the inspect-os calls guestfs_part_get_parttype and guestfs_part_get_gpt_guid for all parition devices found and this causes intermittent with opening block devices that are certainly present yet RESOLVE_DEVICE macro would fail wiht ENOENT. --- daemon/parted.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff

GUESTFSD_EXT_CMD is used by OpenSUSE to track which external commands are run by the daemon and package those commands into the appliance. However because this uses linker trickery it won't work from OCaml code. Replace it with a [nearly] standard C mechanism. Files still have to declare the external commands they will use, eg: DECLARE_EXTERNAL_COMMANDS ("btrfs",

Changed disk GUID makes some OSes fail to boot. To enable virt-resize to support such OSes we have to preserve disk GUID. --- resize/resize.ml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/resize/resize.ml b/resize/resize.ml index d6dd9a5..8ff4793 100644 --- a/resize/resize.ml +++ b/resize/resize.ml @@ -407,6 +407,13 @@ read the man page virt-resize(1).

This is a simpler patch that removes GUESTFSD_EXT_CMD completely.

Allow reading and setting the GPT partition attribute flags. --- daemon/parted.ml | 18 +++++++++++++++++- daemon/parted.mli | 3 +++ generator/actions_core.ml | 40 ++++++++++++++++++++++++++++++++++++++++ generator/proc_nr.ml | 2 ++ lib/MAX_PROC_NR | 2 +- 5 files changed, 63 insertions(+), 2 deletions(-) diff --git a/daemon/parted.ml b/daemon/parted.ml

From: "Richard W.M. Jones" <rjones at redhat.com> This reverts commit a9c8123c72db47bcab8dd738e8d5256a9ae87f11. --- daemon/file.c | 18 +++--------------- daemon/parted.c | 3 +-- 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/daemon/file.c b/daemon/file.c index 057e15d..91746e0 100644 --- a/daemon/file.c +++ b/daemon/file.c @@ -525,7 +525,7 @@

Replace GUESTFSD_EXT_CMD with a command line option ‘./guestfsd --print-external-commands’