similar to: Re: Note regarding bin2s.pl

On 12.01.2016 12:10, Richard W.M. Jones wrote: > On Tue, Jan 12, 2016 at 10:05:00AM +0000, Richard W.M. Jones wrote: >> On Tue, Jan 12, 2016 at 07:57:03AM +0100, Hilko Bengen wrote: >>> Helge, >>> >>> I have applied all the architecture-specific bits but not the bin2s >>> script yet. TBH, so far I don't see what is wrong about export and use

On Tue, Jan 12, 2016 at 06:21:14PM +0100, Helge Deller wrote: > On 12.01.2016 12:10, Richard W.M. Jones wrote: > > On Tue, Jan 12, 2016 at 10:05:00AM +0000, Richard W.M. Jones wrote: > >> On Tue, Jan 12, 2016 at 07:57:03AM +0100, Hilko Bengen wrote: > >>> Helge, > >>> > >>> I have applied all the architecture-specific bits but not the bin2s

On Tue, Jan 12, 2016 at 10:05:00AM +0000, Richard W.M. Jones wrote: > On Tue, Jan 12, 2016 at 07:57:03AM +0100, Hilko Bengen wrote: > > Helge, > > > > I have applied all the architecture-specific bits but not the bin2s > > script yet. TBH, so far I don't see what is wrong about export and use > > of the "_binary_init_size" constant. > >

Hi, this patch replaces the first simpler version: https://www.redhat.com/archives/libguestfs/2017-August/msg00117.html The approach now is to use a C snippet, which should pose way less compatibility issues. Thanks, Pino Toscano (1): Switch binary embedding to a C source .gitignore | 2 +- src/Makefile.am | 18 +++++++++--------- src/{bin2s.pl => bin2c.pl} |

Not all the architectures can cope correctly with unaligned data, and thus the embedded init written is bogus (since it will contain random padding at the beginning, and truncated of the same amount at the end). To overcome that, make sure the rodata section with the embedded init is always aligned to 8 bytes, which should work fine for both 32bit and 64bit architectures. --- src/bin2s.pl | 1 +

objcopy needs "output-target" and "binary-architecture" parameters which makes it necessary to keep a list of known architectures. The bin2s.pl script generates input for the GNU assembler which should produce an object file that is equivalent to that produced by objcopy. I have successfully tested the change on an amd64 Debian/unstable system. --- helper/Makefile.am |

The current approach of writing a custom assembler snippet has few issues: - the assembler needs to manually things like the correct section, disabling the executable stack, and so on - the symbols are global, and exported with an awkward interface (i.e. uint8_t offsets) - the assembler source is built with a manual rule - the embedded data is not properly aligned according to the needs of

--- helper/init.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/helper/init.c b/helper/init.c index 0ca3135..2b5dacf 100644 --- a/helper/init.c +++ b/helper/init.c @@ -163,8 +163,10 @@ main () chdir ("/"); - /* Run /init from ext2 filesystem. */ + mount_proc (); print_uptime (); + + /* Run /init from ext2 filesystem. */ execl

This allows sharing of the read only data between supermin binaries running on the same machine. Thanks: Christian Vogel See thread: https://news.ycombinator.com/item?id=10816921 --- src/bin2s.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin2s.pl b/src/bin2s.pl index 0f892f8..ccb060b 100755 --- a/src/bin2s.pl +++ b/src/bin2s.pl @@ -26,7 +26,7 @@ print $ofh

Fix the build system to support a build directory different than the source directory: - fix the include path to gnulib - properly depend on and use files in the source directory - fix the ocaml dependency calculation, making sure it picks the files from all the places --- src/Makefile.am | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/Makefile.am

From: Hilko Bengen <bengen@debian.org> RWMJ: - Patch taken from Debian downstream package. - The default in the original patch was to disable the tests. I have changed this to default to enable them instead. - Removed AC_SUBST as the variable was not being used. Cc: Hilko Bengen <bengen@debian.org> --- Makefile.am | 5 ++++- configure.ac | 8 ++++++++ 2 files changed, 12

From: Hilko Bengen <bengen at hilluzination.de> --- erlang/Makefile.am | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/erlang/Makefile.am b/erlang/Makefile.am index f336375..2c9e359 100644 --- a/erlang/Makefile.am +++ b/erlang/Makefile.am @@ -32,7 +32,7 @@ erlang_bindir = $(libdir)/erlang/lib/$(PACKAGE_NAME)-$(PACKAGE_VERSION)/ebin erlang_bin_DATA = guestfs.beam

From: Hilko Bengen <bengen at hilluzination.de> On installations where no native OCaml compiler is available, the test program can't be compiled and so we get this message: ,---- | checking for function caml_raise_with_args... not found `---- This breaks building of the OCaml bindings. ,---- | gcc -std=gnu99 -I.. -I/usr/lib/ocaml -I../ocaml -I../lib -g -O2 -fPIC -Wall -c hivex_c.c

Hi, While working on Debian packages of hivex 1.2.5, I came across a test failure for the Python bindings with Python 2.7 on the i386 architecture. (The tests ran fine on amd64.) ,---- | $ make -C python check | make[1]: Entering directory `/home/bengen/src/deb/hivex/hivex.git/python' | 010-import.py | 020-open.py | 021-close.py | 200-write.py | python: hivex-py.c:52: get_handle: Assertion

Add the email address for authors. It will be better. Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- AUTHORS | 48 ++++++++++++++++++++++++------------------------ 1 files changed, 24 insertions(+), 24 deletions(-) diff --git a/AUTHORS b/AUTHORS index 0d6fb3c..702de5d 100644 --- a/AUTHORS +++ b/AUTHORS @@ -1,24 +1,24 @@ -Angus Salkeld -Ani Peter -Charles Duffy -Daniel

I needed to add a few patches to be able to build libguestfs 1.20.2 out of tree. Mostly srcdir/builddir issues -- I think that I had posted something for building the daemon before. As mentioned on IRC, I found that compiling (Ruby bindings) caused config.h file shipped with the Ruby headers to be included rather than ${builddir}/config.h. This can be fixed because the relevant checks can be

v1 -> v2: - If we split out the init program into a separate init/ directory, that makes it much easier to build against an alternate libc. I tried to build against uClibc, but uClibc requires an entire build chain, which looked like it was going to be a massive ballache. Rich.

* Richard W.M. Jones: > On Fri, Feb 28, 2014 at 02:35:56PM +0100, Hilko Bengen wrote: >> diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am >> index 5dd2c9b..708b2e7 100644 >> --- a/ocaml/Makefile.am >> +++ b/ocaml/Makefile.am > [...] >> +# Tell version 3.79 and up of GNU make to not build goals in this >> +# directory in parallel. >> +.NOTPARALLEL:

--- images/README | 14 ++++++++++++ images/mkzero/Makefile | 9 ++++++++ images/mkzero/mkzero.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++++ images/special | Bin 0 -> 8192 bytes 4 files changed, 82 insertions(+) create mode 100644 images/mkzero/Makefile create mode 100644 images/mkzero/mkzero.c create mode 100644 images/special diff --git a/images/README

Hi, when pushing libguestfs 1.27.53 (1:1.27.53-1) through my build setup befor uploading it to Debian, I noticed that "guestfs_internal_lstatlist@Base", a symbol that has been there since 1.20, is now missing. This causes dpkg-gensymbols(1) whose job it is to compare the symbols from the newly-built libraries to the known state to fail. If the guestfs_internal_* functions are not