similar to: [PATCH] launch: add missing headers on Darwin

On Wednesday 04 November 2015 12:05:31 Margaret Lewicka wrote: > Including sys/un.h for sockaddr_un and sys/fcntl.h for > O_CLOEXEC/O_NONBLOCK. > --- > src/launch-libvirt.c | 1 + > src/launch-unix.c | 4 ++++ > 2 files changed, 5 insertions(+) > > diff --git a/src/launch-libvirt.c b/src/launch-libvirt.c > index 1649884..ad07210 100644 > ---

On Friday 06 February 2015 10:03:37 Richard W.M. Jones wrote: > On Thu, Feb 05, 2015 at 10:53:06PM +0000, Margaret Lewicka wrote: > > Hello, > > > > I'm attempting to create a Homebrew formula to get libguestfs to > > compile on Mac OS X. I've managed to achieve success with several > > monkey patches, but since Homebrew's policy is to contact

Hello, I'm attempting to create a Homebrew formula to get libguestfs to compile on Mac OS X. I've managed to achieve success with several monkey patches, but since Homebrew's policy is to contact maintainers about proper fixes in upstream, I would like to ask if there are any plans to fix these issues. I'm afraid I don't know C well enough to propose decent solutions myself.

>From Apple's xdr.h: "If your code invokes an xdrproc_t callback, it must be modified to pass a third parameter, which may simply be zero." --- src/proto.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/proto.c b/src/proto.c index 92ae84d..57f4882 100644 --- a/src/proto.c +++ b/src/proto.c @@ -252,7 +252,12 @@ guestfs___send (guestfs_h *g, int proc_nr, *

--- src/inspect-apps.c | 13 ++++++++++++- src/inspect-fs-windows.c | 6 ++++++ src/journal.c | 5 +++++ 3 files changed, 23 insertions(+), 1 deletion(-) diff --git a/src/inspect-apps.c b/src/inspect-apps.c index 20cf00a..8fbae9c 100644 --- a/src/inspect-apps.c +++ b/src/inspect-apps.c @@ -35,11 +35,22 @@ #include <sys/endian.h> #endif -/* be32toh is usually a macro

On 4 November 2015 at 12:37, Pino Toscano <ptoscano@redhat.com> wrote: [...] > NACK, these OS-specific blocks are hard to maintain, and it makes no > sense to enclose POSIX headers in them. > > Can you please try the attached patch? I see Rich already pushed your > patch, but IMHO that should be reverted and this one should go... Happy to. However, these same header files

On Wed, Feb 11, 2015 at 09:52:59PM +0000, Margaret Lewicka wrote: > On 11 February 2015 at 19:23, Richard W.M. Jones <rjones@redhat.com> wrote: > > On Wed, Feb 11, 2015 at 07:20:33PM +0000, Margaret Lewicka wrote: > [...] > >> Proposing a patch to gnulib, even should they accept it, does not fix > >> the underlying issue, which is, essentially, that gnulib

On Thursday 12 February 2015 17:39:45 Margaret Lewicka wrote: > --- > lib/error.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/error.c b/lib/error.c > index 6683197..36a3db7 100644 > --- a/lib/error.c > +++ b/lib/error.c > @@ -113,9 +113,13 @@ int strerror_r (); > # endif > # endif > > +#if defined __APPLE__ && defined

On Thursday 12 February 2015 18:58:17 Margaret Lewicka wrote: > On 12 February 2015 at 18:50, Pino Toscano <ptoscano@redhat.com> wrote: > [...] > > We import gnulib as git submodule from the upstream gnulib.git, so > > this should be sent to its mailing list; see also > > https://www.gnu.org/software/gnulib/ > > > > (Personally, I'm not sure that the

On Mon, Feb 09, 2015 at 11:06:16AM +0000, Margaret Lewicka wrote: > gnulib's error.c requires program_name to be externally defined > for !_LIBC systems. This defines program_name for Darwin only. > --- > configure.ac | 3 +++ > src/Makefile.am | 6 ++++++ > src/program_name.c | 4 ++++ > 3 files changed, 13 insertions(+) > create mode 100644

On Wed, Feb 11, 2015 at 07:20:33PM +0000, Margaret Lewicka wrote: > On 11 February 2015 at 13:46, Richard W.M. Jones <rjones@redhat.com> wrote: > [...] > > On non-glibc, error.c says: > > > > /* The calling program should define program_name and set it to the > > name of the executing program. */ > > extern char *program_name; > > > >

On Mon, Feb 09, 2015 at 10:56:54AM +0100, Pino Toscano wrote: > On Friday 06 February 2015 10:03:37 Richard W.M. Jones wrote: > > On Thu, Feb 05, 2015 at 10:53:06PM +0000, Margaret Lewicka wrote: > > > +/* Fixes for Mac OS X */ > > > +#if defined __APPLE__ && defined __MACH__ > > > +#include <sys/un.h> > > > +#endif > > > +#ifndef

On 12 February 2015 at 18:42, Pino Toscano <ptoscano@redhat.com> wrote: [...] > We link to libcrypt because it provides crypt(), at least on GNU libc > and on the FreeBSD libc; it seems not the case on Mac OS X, looking > at your patch. > I'd say that this should turn into a proper configure check, trying to > use crypt() without extra libraries and if not possible with

On Thu, Feb 05, 2015 at 10:53:06PM +0000, Margaret Lewicka wrote: > Hello, > > I'm attempting to create a Homebrew formula to get libguestfs to > compile on Mac OS X. I've managed to achieve success with several > monkey patches, but since Homebrew's policy is to contact maintainers > about proper fixes in upstream, I would like to ask if there are any > plans to

On Monday 09 February 2015 11:06:17 Margaret Lewicka wrote: > On JDK 8, doclint is enabled by default with strict validation of HTML > tags, which causes the build to fail. See > http://blog.joda.org/2014/02/turning-off-doclint-in-jdk-8-javadoc.html > --- > java/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/java/Makefile.am

Hello, Are there any chances of next stable release appearing soonish? I'm getting pushback from Homebrew maintainers about the massive amount of patching required to build the current stable on Mac, since all the patches have been merged in after last stable. (I'm also getting pushback about the 4GB download of virtual appliance, but as I understand that one is non-optional. Don't

* Replace LD_LIBRARY_PATH with DYLD_LIBRARY_PATH for Darwin * Remove the -lcrypt flag for Darwin (unsupported) --- configure.ac | 13 +++++++++++++ run.in | 10 +++++----- v2v/link.sh.in | 2 +- 3 files changed, 19 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index d68190a..295de11 100644 --- a/configure.ac +++ b/configure.ac @@ -582,6 +582,19 @@ fi

On Thursday 12 February 2015 17:28:46 Margaret Lewicka wrote: > --- > src/inspect-apps.c | 13 ++++++++++++- > src/inspect-fs-windows.c | 6 ++++++ > src/journal.c | 5 +++++ > 3 files changed, 23 insertions(+), 1 deletion(-) > > diff --git a/src/inspect-apps.c b/src/inspect-apps.c > index 20cf00a..8fbae9c 100644 > --- a/src/inspect-apps.c > +++

I also made the code a bit more robust about closing the socket along error paths. --- generator/states-connect.c | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/generator/states-connect.c b/generator/states-connect.c index ba8b240..a69b70f 100644 --- a/generator/states-connect.c +++ b/generator/states-connect.c @@ -27,6 +27,7 @@ #include

On Wed, Jul 31, 2019 at 04:31:32PM -0500, Eric Blake wrote: > This reverts commit 25206df20275aeff346d9b86adf5e9be99cc9e43. > > An upcoming patch wants to ensure no leaked fds from the server to a > child process. POSIX has required O_CLOEXEC since 2008, and although > current POSIX doesn't yet specify full atomic interfaces everywhere > such as SOCK_CLOEXEC, it does have