similar to: [PATCH] Bugfix in number parsing in vfs_min_size.

Tried to make it in accordance with your comments. Difference to v1: Added reply_with_error where necessary. Changed name get_min_size -> vfs_min_size. Difference to v2: Changed name to vfs_minimum_size. Changed parsing to xstrtol + STR* macros where possible. Maxim Perevedentsev (2): New API: vfs_min_size Include resize2fs_P into vfs_min_size. daemon/Makefile.am | 1 +

Tried to make it in accordance with your comments. Difference to v1: Added reply_with_error where necessary. Changed name get_min_size -> vfs_min_size. Difference to v2: Changed name to vfs_minimum_size. Changed parsing to xstrtol + STR* macros where possible. Difference to v3: Decapitalize error messages. Maxim Perevedentsev (2): New API: vfs_minimum_size Include resize2fs_P into

This call provides the way to get minimum size of filesystem. This is needed for shrinking. The return units are bytes. --- daemon/Makefile.am | 1 + daemon/daemon.h | 1 + daemon/fs-min-size.c | 46 +++++++++++++++++++++++++++ daemon/ntfs.c | 87 ++++++++++++++++++++++++++++++++++++++++++++++++++++ generator/actions.ml | 19 ++++++++++++ po/POTFILES | 1 +

On Monday 19 October 2015 17:05:02 Maxim Perevedentsev wrote: > This call provides the way to get minimum size of filesystem. > This is needed for shrinking. The return units are bytes. > > --- > daemon/Makefile.am | 1 + > daemon/daemon.h | 1 + > daemon/fs-min-size.c | 46 ++++++++++++++++++++++++++++++++ > daemon/ntfs.c | 75

Tried to make it in accordance with your comments. Difference to v1: Added reply_with_error where necessary. Changed name get_min_size -> vfs_min_size. Maxim Perevedentsev (2): New API: vfs_min_size Include resize2fs_P into vfs_min_size. daemon/Makefile.am | 1 + daemon/daemon.h | 2 ++ daemon/ext2.c | 45 ++++++++++++++++++++++++++----- daemon/fs-min-size.c | 49

--- daemon/btrfs.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++++++++ daemon/daemon.h | 1 + daemon/fs-min-size.c | 50 ++++++++++++++++++++++++++++++++++++- generator/actions.ml | 6 ++++- 4 files changed, 124 insertions(+), 2 deletions(-) diff --git a/daemon/btrfs.c b/daemon/btrfs.c index ddb029d..d2d85f3 100644 --- a/daemon/btrfs.c +++ b/daemon/btrfs.c @@ -2190,3 +2190,72

This call provides the way to get minimum size of filesystem. This is needed for shrinking. The return units are bytes. --- daemon/Makefile.am | 1 + daemon/daemon.h | 1 + daemon/fs-min-size.c | 46 +++++++++++++++++++++++++++ daemon/ntfs.c | 87 ++++++++++++++++++++++++++++++++++++++++++++++++++++ generator/actions.ml | 19 ++++++++++++ po/POTFILES | 1 +

--- daemon/daemon.h | 1 + daemon/ext2.c | 62 +++++++++++++++++++++++++++++++++++++++++++++------- daemon/fs-min-size.c | 3 +++ generator/actions.ml | 20 ++++------------- src/MAX_PROC_NR | 2 +- 5 files changed, 63 insertions(+), 25 deletions(-) diff --git a/daemon/daemon.h b/daemon/daemon.h index 3b0266d..8bcc9bd 100644 --- a/daemon/daemon.h +++ b/daemon/daemon.h @@

Tried to make it in accordance with your comments. Maybe you can suggest a better name for API? Maxim Perevedentsev (2): New API: get_min_size Include resize2fs_P into get_min_size. daemon/Makefile.am | 1 + daemon/daemon.h | 2 ++ daemon/ext2.c | 37 ++++++++++++++++++++++++---- daemon/fs-min-size.c | 49 +++++++++++++++++++++++++++++++++++++ daemon/ntfs.c | 68

On Thu, Oct 22, 2015 at 08:05:37PM +0300, Maxim Perevedentsev wrote: > +/* btrfs command add a new command > + * inspect-internal min-dev-size <path> > + * since v4.2 > + * We could check whether 'btrfs' supports > + * 'min-dev-size' command by checking the output of > + * 'btrfs --help' command. > + */ > +static int >

--- daemon/btrfs.c | 72 ++++++++++++++++++++++++++++++++++++++++++++++++++++ daemon/daemon.h | 1 + daemon/fs-min-size.c | 33 ++++++++++++++++++++---- generator/actions.ml | 6 ++++- 4 files changed, 106 insertions(+), 6 deletions(-) diff --git a/daemon/btrfs.c b/daemon/btrfs.c index ddb029d..1e0a9a2 100644 --- a/daemon/btrfs.c +++ b/daemon/btrfs.c @@ -2190,3 +2190,75 @@

This call provides the way to get minimum size of filesystem. This is needed for shrinking. The return units are bytes. --- daemon/Makefile.am | 1 + daemon/daemon.h | 1 + daemon/fs-min-size.c | 46 ++++++++++++++++++++++++++++++++ daemon/ntfs.c | 75 ++++++++++++++++++++++++++++++++++++++++++++++++++++ generator/actions.ml | 16 +++++++++++ po/POTFILES | 1 +

On 10/19/2015 07:45 PM, Pino Toscano wrote: > On Monday 19 October 2015 17:05:02 Maxim Perevedentsev wrote: > >> + const char *size_pattern = "You might resize at ", >> + *full_pattern = "Volume is full", >> + *cluster_size_pattern = "Cluster size", >> + *volume_size_pattern = "Current volume

--- daemon/btrfs.c | 71 ++++++++++++++++++++++++++++++++++++++++++++++++++++ daemon/daemon.h | 1 + daemon/fs-min-size.c | 34 ++++++++++++++++++++++++- generator/actions.ml | 6 ++++- 4 files changed, 110 insertions(+), 2 deletions(-) diff --git a/daemon/btrfs.c b/daemon/btrfs.c index ddb029d..652a17e 100644 --- a/daemon/btrfs.c +++ b/daemon/btrfs.c @@ -2190,3 +2190,74 @@

Get minimum size of NTFS filesystem in bytes. This is used primarily for shrinking images. In case of a full images ntfsresize returns error code and does not print minimum size. So we calculate it manually by rounding 'volume size' up to 'cluster size'. --- daemon/ntfs.c | 68 ++++++++++++++++++++++++++++++++++++++++++++++++++++ generator/actions.ml | 17 +++++++++++++

On 10/19/2015 07:45 PM, Pino Toscano wrote: > On Monday 19 October 2015 17:05:02 Maxim Perevedentsev wrote: >> +int64_t >> +ntfs_min_size (const char *device) >> +{ >> + CLEANUP_FREE char *err = NULL, *out = NULL; >> + CLEANUP_FREE_STRING_LIST char **lines = NULL; >> + int r; >> + size_t i; >> + char *p; >> + int64_t ret, volume_size =

This call provides the way to get minimum size of filesystem. This is needed for shrinking. The return units are bytes. --- daemon/Makefile.am | 1 + daemon/daemon.h | 1 + daemon/fs-min-size.c | 46 +++++++++++++++++++++++++++++++++++ daemon/ntfs.c | 68 ++++++++++++++++++++++++++++++++++++++++++++++++++++ generator/actions.ml | 15 ++++++++++++ po/POTFILES | 1 +

Tried to make it in accordance with your comments. Difference to v1: Added reply_with_error where necessary. Changed name get_min_size -> vfs_min_size. Difference to v2: Changed name to vfs_minimum_size. Changed parsing to xstrtol + STR* macros where possible. Maxim Perevedentsev (2): New API: vfs_min_size Include resize2fs_P into vfs_min_size. daemon/Makefile.am | 1 +

--- daemon/daemon.h | 1 + daemon/ext2.c | 45 +++++++++++++++++++++++++++++++++++++++------ daemon/fs-min-size.c | 3 +++ generator/actions.ml | 20 ++++---------------- src/MAX_PROC_NR | 2 +- 5 files changed, 48 insertions(+), 23 deletions(-) diff --git a/daemon/daemon.h b/daemon/daemon.h index a690152..61b61e7 100644 --- a/daemon/daemon.h +++ b/daemon/daemon.h @@ -224,6

Since we are using gnulib already, make use of xstrtol to parse the integer arguments to avoid extra suffixes, etc. Fixes commit 0f7bf8f714898c606e5d5015fff5b7803dcd1aee. --- mllib/getopt-c.c | 34 ++++++++++++++++++++++++---------- 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/mllib/getopt-c.c b/mllib/getopt-c.c index 1f129a7..2d3f9b6 100644 --- a/mllib/getopt-c.c +++